From: Peter Zijlstra <peterz@infradead.org>
To: mojha@codeaurora.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:smp/urgent] cpu/hotplug: Remove skip_onerr field from cpuhp_step structure
Date: Fri, 31 Aug 2018 10:33:16 +0200 [thread overview]
Message-ID: <20180831083316.GR24082@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <tip-935aad3015fb4afc0b7ef6e6c18175b95461de47@git.kernel.org>
On Thu, Aug 30, 2018 at 04:03:58AM -0700, tip-bot for Mukesh Ojha wrote:
> Commit-ID: 935aad3015fb4afc0b7ef6e6c18175b95461de47
> Gitweb: https://git.kernel.org/tip/935aad3015fb4afc0b7ef6e6c18175b95461de47
> Author: Mukesh Ojha <mojha@codeaurora.org>
> AuthorDate: Tue, 28 Aug 2018 12:24:54 +0530
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Thu, 30 Aug 2018 12:59:30 +0200
> @@ -644,12 +637,6 @@ static void cpuhp_thread_fun(unsigned int cpu)
>
> WARN_ON_ONCE(!cpuhp_is_ap_state(state));
>
> - if (st->rollback) {
> - struct cpuhp_step *step = cpuhp_get_step(state);
> - if (step->skip_onerr)
> - goto next;
> - }
> -
> if (cpuhp_is_atomic_state(state)) {
> local_irq_disable();
> st->result = cpuhp_invoke_callback(cpu, state, bringup, st->node, &st->last);
Can you fold this in?
../kernel/cpu.c: In function ‘cpuhp_thread_fun’:
../kernel/cpu.c:663:1: warning: label ‘next’ defined but not used [-Wunused-label]
---
kernel/cpu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index c544baf75e77..aa7fe85ad62e 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -660,7 +660,6 @@ static void cpuhp_thread_fun(unsigned int cpu)
st->should_run = false;
}
-next:
cpuhp_lock_release(bringup);
if (!st->should_run)
next prev parent reply other threads:[~2018-08-31 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 6:54 [PATCH] cpu/hotplug: Remove skip_onerr field from cpuhp_step structure Mukesh Ojha
2018-08-28 7:55 ` Peter Zijlstra
2018-08-30 11:03 ` [tip:smp/urgent] " tip-bot for Mukesh Ojha
2018-08-31 8:33 ` Peter Zijlstra [this message]
2018-08-31 12:14 ` Thomas Gleixner
2018-08-31 12:15 ` tip-bot for Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831083316.GR24082@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mojha@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).