From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4B6C433F4 for ; Fri, 31 Aug 2018 12:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20FF220661 for ; Fri, 31 Aug 2018 12:17:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20FF220661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728309AbeHaQZI (ORCPT ); Fri, 31 Aug 2018 12:25:08 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:41433 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727359AbeHaQZI (ORCPT ); Fri, 31 Aug 2018 12:25:08 -0400 Received: by mail-qt0-f194.google.com with SMTP id t39-v6so14206416qtc.8; Fri, 31 Aug 2018 05:17:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0BDHD9c3sqtOqHZ83do4BeF2hzl3IWB4t57/JuXPXRs=; b=ZTxJyY1Z8smZWet9tl+IBVNDxY4slcb3n0RAJ/3QucLVU3A2Rkx3BCUuhXLdJ3rcul M64XbGjdsDA7GmlaxQihWDDSl6dLRaGOe9tpxwDUhp0x0kqBKn1qvUxnNYC2A21WpEL3 cMOzt5LTf7y8GPFOhe8rTnB5JUNgUBbrpCC9H6zdKdZSzIKOKyD83LQdO6S+if/o2ztJ eB1afAME4v2iyb8ZVyzAgGU80mpNxD1RJ9yeLe5z/gtw5MX/Di+EVy4JHd6hkThpqNig vVXFIIi+GpKTp2EhaEwSEWQdtXrakcARKtKmtib/wV/U+7WuP2DyRLPqW0DylF3WlDdB jUjw== X-Gm-Message-State: APzg51AdWsdUhl12lfcZEu9za+UILATd0XRa+4vEmzRF/mre1LLzL+CR S+R7KpNrKeTnvJN/oPRVNQ== X-Google-Smtp-Source: ANB0VdaTdC4iWPX90R1qYoa2LcNhNvKQHAgjXIuPmd5fK82fPqu8XkDEUSEnTI0wuPlmdIw7sqs9OA== X-Received: by 2002:ac8:392e:: with SMTP id s43-v6mr15550683qtb.68.1535717873943; Fri, 31 Aug 2018 05:17:53 -0700 (PDT) Received: from localhost (mobile-166-170-28-234.mycingular.net. [166.170.28.234]) by smtp.gmail.com with ESMTPSA id 15-v6sm6615392qtx.44.2018.08.31.05.17.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Aug 2018 05:17:53 -0700 (PDT) Date: Fri, 31 Aug 2018 08:17:51 -0400 From: Rob Herring To: Ricardo Ribalda Delgado Cc: David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Zhouyang Jia , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 8/8] dt-binding: mtd: Document gpio-addr-flash Message-ID: <20180831121751.GA22256@bogus> References: <20180821143152.32293-1-ricardo.ribalda@gmail.com> <20180821143152.32293-9-ricardo.ribalda@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180821143152.32293-9-ricardo.ribalda@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 21, 2018 at 04:31:52PM +0200, Ricardo Ribalda Delgado wrote: > Add documentation for gpio-addr-flash. This binding allow creating > flash devices that are paged using GPIOs. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Ricardo Ribalda Delgado > --- > .../bindings/mtd/gpio-addr-flash.txt | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt > > diff --git a/Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt b/Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt > new file mode 100644 > index 000000000000..4279e8cad09b > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt > @@ -0,0 +1,46 @@ > +Memory Mapped flash with some address lines addressed using GPIOs That's ugly... > + > +Handle the case where a flash device is mostly addressed using physical > +line and supplemented by GPIOs. This way you can hook up say a 8MiB flash > +to a 2MiB memory range and use the GPIOs to select a particular range. > + > + - compatible : "cfi-gpio-addr-flash" Why a new compatible? Shouldn't just adding some address gpios to an existing flash device binding be sufficient? > + - reg : Address range of the mtd chip that is memory mapped, this is, > + on the previous example 2MiB. > + - bank-width : Width (in bytes) of the bank. Equal to the > + device width times the number of interleaved chips. > + - probe-type : (optional) "cfi_probe", "jedec_probe". How the mtd chip > + is going to be probed. If omitted, assumed to be equal to "cfi_probe". > + - #address-cells, #size-cells : Must be present if the device has > + sub-nodes representing partitions (see below). In this case > + both #address-cells and #size-cells must be equal to 1. > + > +The device tree may optionally contain sub-nodes describing partitions of the > +address space. See partition.txt for more detail. > + > +Example: > + > + cfi_flash_0: cfi_flash { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "cfi-gpio-addr-flash"; > + bank-width = <2>; > + reg = < 0x00300000 0x00200000 >; > + gpios = <&gpio_0 3 0>, <&gpio_0 4 0>; > + partition@0 { > + reg = < 0x0 0x200000 >; > + label = "Golden Bitstream"; > + }; > + partition@200000 { > + reg = < 0x200000 0x200000 >; > + label = "User Bitstream"; > + }; > + partition@400000 { > + reg = < 0x400000 0x200000 >; > + label = "V4L Controls"; > + }; > + partition@600000 { > + reg = < 0x600000 0x200000 >; > + label = "Production Data"; > + }; > + } ; > -- > 2.18.0 >