From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8FDAC433F5 for ; Sun, 2 Sep 2018 17:55:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 622B220658 for ; Sun, 2 Sep 2018 17:55:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="knfn8CeX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 622B220658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbeIBWLv (ORCPT ); Sun, 2 Sep 2018 18:11:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:48742 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726065AbeIBWLv (ORCPT ); Sun, 2 Sep 2018 18:11:51 -0400 Received: from archlinux (unknown [176.12.107.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2783A20841; Sun, 2 Sep 2018 17:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1535910917; bh=mg8rNLtNHrdgAWov/defOyOZPD0qPPVSOXkE6w48ioc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=knfn8CeX+vy9jI7jClR9LQySwjQyQG9464pvgDDxTc98pA+9iEznl9GBgqbRUznSx xpTA9oN+o0PVXbf4HwntnmSEaNYjuf4HCIaGMJ3S0t2xw9S2axeMnqnegnDi0ocNgx WreFo55vFJEnbLW/vIrpSRaCd+1G4cQ9IbO/+ZIQ= Date: Sun, 2 Sep 2018 18:55:05 +0100 From: Jonathan Cameron To: Rob Herring Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , linux-iio@vger.kernel.org Subject: Re: [PATCH] iio: Convert to using %pOFn instead of device_node.name Message-ID: <20180902185505.330efb32@archlinux> In-Reply-To: <20180828015252.28511-22-robh@kernel.org> References: <20180828015252.28511-1-robh@kernel.org> <20180828015252.28511-22-robh@kernel.org> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Aug 2018 20:52:23 -0500 Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Jonathan Cameron > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Cc: linux-iio@vger.kernel.org > Signed-off-by: Rob Herring Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 4 ++-- > drivers/iio/adc/rcar-gyroadc.c | 12 ++++++------ > drivers/iio/frequency/adf4350.c | 2 +- > 3 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > index b093ecddf1a8..c30c002f1fef 100644 > --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c > +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > @@ -708,8 +708,8 @@ static int pm8xxx_of_xlate(struct iio_dev *indio_dev, > * mux. > */ > if (iiospec->args_count != 2) { > - dev_err(&indio_dev->dev, "wrong number of arguments for %s need 2 got %d\n", > - iiospec->np->name, > + dev_err(&indio_dev->dev, "wrong number of arguments for %pOFn need 2 got %d\n", > + iiospec->np, > iiospec->args_count); > return -EINVAL; > } > diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c > index dcb50172186f..4e982b51bcda 100644 > --- a/drivers/iio/adc/rcar-gyroadc.c > +++ b/drivers/iio/adc/rcar-gyroadc.c > @@ -343,8 +343,8 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev) > for_each_child_of_node(np, child) { > of_id = of_match_node(rcar_gyroadc_child_match, child); > if (!of_id) { > - dev_err(dev, "Ignoring unsupported ADC \"%s\".", > - child->name); > + dev_err(dev, "Ignoring unsupported ADC \"%pOFn\".", > + child); > continue; > } > > @@ -381,16 +381,16 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev) > ret = of_property_read_u32(child, "reg", ®); > if (ret) { > dev_err(dev, > - "Failed to get child reg property of ADC \"%s\".\n", > - child->name); > + "Failed to get child reg property of ADC \"%pOFn\".\n", > + child); > return ret; > } > > /* Channel number is too high. */ > if (reg >= num_channels) { > dev_err(dev, > - "Only %i channels supported with %s, but reg = <%i>.\n", > - num_channels, child->name, reg); > + "Only %i channels supported with %pOFn, but reg = <%i>.\n", > + num_channels, child, reg); > return ret; > } > } > diff --git a/drivers/iio/frequency/adf4350.c b/drivers/iio/frequency/adf4350.c > index 6d768431d90e..f4748ff243f7 100644 > --- a/drivers/iio/frequency/adf4350.c > +++ b/drivers/iio/frequency/adf4350.c > @@ -388,7 +388,7 @@ static struct adf4350_platform_data *adf4350_parse_dt(struct device *dev) > if (!pdata) > return NULL; > > - strncpy(&pdata->name[0], np->name, SPI_NAME_SIZE - 1); > + snprintf(&pdata->name[0], SPI_NAME_SIZE - 1, "%pOFn", np); > > tmp = 10000; > of_property_read_u32(np, "adi,channel-spacing", &tmp);