linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tlv320aic31xx: Remove regulator notification handling
Date: Mon, 3 Sep 2018 12:30:38 +0100	[thread overview]
Message-ID: <20180903113038.GG10302@sirena.org.uk> (raw)
In-Reply-To: <20180831181737.29516-1-afd@ti.com>

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

On Fri, Aug 31, 2018 at 01:17:37PM -0500, Andrew F. Davis wrote:
> The notification handler sets the reset line but never re-enables it
> as no one is listening for an enable event, this is certainly broken
> and was most likely just copied from other CODECs, remove this code.

Why not fix it?  The usual pattern would be to take the CODEC out of
reset when bringing the bias back to standby.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-09-03 11:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31 18:17 [PATCH] ASoC: tlv320aic31xx: Remove regulator notification handling Andrew F. Davis
2018-09-03 11:30 ` Mark Brown [this message]
2018-09-04 14:50   ` Andrew F. Davis
2018-09-04 14:57     ` Mark Brown
2018-09-04 15:03       ` Andrew F. Davis
2018-09-04 15:49         ` Mark Brown
2018-09-04 15:55           ` Andrew F. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180903113038.GG10302@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=afd@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).