From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tlv320aic31xx: Add MICBIAS off setting
Date: Tue, 4 Sep 2018 17:21:01 +0100 [thread overview]
Message-ID: <20180904162101.GK12993@sirena.org.uk> (raw)
In-Reply-To: <5e7fdb87-651d-6056-9323-7a29573b6300@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On Tue, Sep 04, 2018 at 11:02:14AM -0500, Andrew F. Davis wrote:
> On 09/04/2018 10:56 AM, Mark Brown wrote:
> > I'm really having a lot of trouble seeing MICBIAS_OFF as a useful
> > voltage to specify in DT in the first place.
> I don't see the usefulness in specifying any bias voltage in DT at all,
> it is a configuration and can be made at runtime, it has no place in DT.
> But it is already here, so lets allow all available voltages a board may
> need and the CODEC can supply, even 0.
It is very rare for it to be useful to select the bias voltage at
runtime - it's usually something that's decided by the electrical
engineering at system design time and linked to selection of passive
components rather than something that a user could usefully vary. I
suspect in the situations where it is useful to vary it you'd want a
layer of indirection mapping it onto some user observable behaviour (or
the system should just do this autonomously as with the various low
power mic detect solutions out there). What situations are you aware of
where runtime configuration is useful?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-09-04 16:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 18:05 [PATCH] ASoC: tlv320aic31xx: Add MICBIAS off setting Andrew F. Davis
2018-09-03 11:26 ` Mark Brown
2018-09-04 13:55 ` Andrew F. Davis
2018-09-04 14:41 ` Mark Brown
2018-09-04 14:43 ` Andrew F. Davis
2018-09-04 14:55 ` Mark Brown
2018-09-04 15:10 ` Andrew F. Davis
2018-09-04 15:56 ` Mark Brown
2018-09-04 16:02 ` Andrew F. Davis
2018-09-04 16:21 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904162101.GK12993@sirena.org.uk \
--to=broonie@kernel.org \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).