From: Andi Kleen <ak@linux.intel.com>
To: Eduardo Valentin <eduval@amazon.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Kan Liang <kan.liang@linux.intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Jia Zhang <qianyue.zj@alibaba-inc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/1] perf/x86/intel: make error messages less confusing
Date: Tue, 4 Sep 2018 16:02:40 -0700 [thread overview]
Message-ID: <20180904230240.GK27886@tassilo.jf.intel.com> (raw)
In-Reply-To: <20180904182312.GA11911@u40b0340c692b58f6553c.ant.amazon.com>
On Tue, Sep 04, 2018 at 11:23:12AM -0700, Eduardo Valentin wrote:
> Hello,
>
> On Thu, Aug 23, 2018 at 08:07:32AM -0700, Eduardo Valentin wrote:
> > On a system with X86_FEATURE_ARCH_PERFMON disabled
> > and with a model not known by family PMU drivers,
> > user gets a kernel message log like the following:
> > [ 0.100114] Performance Events: unsupported p6 CPU model 85 no PMU driver, software events only.
> >
> > The "unsupported .. CPU" part may be confusing for some
> > users leading to wrong understanding that the kernel
> > does not support the CPU model.
> >
> > This patch rewords the messages on the failure path to:
> > [ 0.667154] Performance Events: CPU does not support PMU: no PMU driver, software events only.
> >
>
>
> Gentle ping on this patch, any further comments?
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
next prev parent reply other threads:[~2018-09-04 23:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 15:07 [PATCHv2 1/1] perf/x86/intel: make error messages less confusing Eduardo Valentin
2018-09-04 18:23 ` Eduardo Valentin
2018-09-04 23:02 ` Andi Kleen [this message]
2018-09-05 8:52 ` Peter Zijlstra
2018-09-05 15:53 ` Eduardo Valentin
2018-09-05 21:47 ` Andi Kleen
2018-09-06 7:21 ` Peter Zijlstra
2018-09-14 0:00 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904230240.GK27886@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=eduval@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qianyue.zj@alibaba-inc.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).