From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3152C43334 for ; Wed, 5 Sep 2018 13:35:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9647E20659 for ; Wed, 5 Sep 2018 13:35:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=thunk.org header.i=@thunk.org header.b="E9YlQTO7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9647E20659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727664AbeIESFc (ORCPT ); Wed, 5 Sep 2018 14:05:32 -0400 Received: from imap.thunk.org ([74.207.234.97]:53278 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbeIESFc (ORCPT ); Wed, 5 Sep 2018 14:05:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=L82TUGwx2aGNJNUD9o05Akx2Xn48SaAYMTxNLgjEO0E=; b=E9YlQTO7s440gBBdg3YUp7+Gpk okzllADs9zQXMobbu/FDSqlEnJ52jpfz0pllH8BOYUe0nliFicpxWuf8sUXhD9JHCt+21Ds8y8I7+ FHrLPTUJ9l6lGz74zYLceZHTqO4rgsC9Bm3aPkrL9oK32gdaaHMvl3xvisZ88D2TjfI0=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1fxXxU-0003qP-Cr; Wed, 05 Sep 2018 13:35:00 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 44F787A4B95; Wed, 5 Sep 2018 09:34:59 -0400 (EDT) Date: Wed, 5 Sep 2018 09:34:59 -0400 From: "Theodore Y. Ts'o" To: Souptick Joarder Cc: Jan Kara , syzbot+87a05ae4accd500f5242@syzkaller.appspotmail.com, ak@linux.intel.com, Andrew Morton , linux-kernel@vger.kernel.org, Linux-MM , mawilcox@microsoft.com, mgorman@techsingularity.net, syzkaller-bugs@googlegroups.com, tim.c.chen@linux.intel.com, zwisler@kernel.org, willy@infradead.org Subject: Re: linux-next test error Message-ID: <20180905133459.GF23909@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , Souptick Joarder , Jan Kara , syzbot+87a05ae4accd500f5242@syzkaller.appspotmail.com, ak@linux.intel.com, Andrew Morton , linux-kernel@vger.kernel.org, Linux-MM , mawilcox@microsoft.com, mgorman@techsingularity.net, syzkaller-bugs@googlegroups.com, tim.c.chen@linux.intel.com, zwisler@kernel.org, willy@infradead.org References: <0000000000004f6b5805751a8189@google.com> <20180905085545.GD24902@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 05, 2018 at 03:20:16PM +0530, Souptick Joarder wrote: > > "fs: convert return type int to vm_fault_t" is still under > review/discusson and not yet merge > into linux-next. I am not seeing it into linux-next tree.Can you > please share the commit id ? It's at: 83c0adddcc6ed128168e7b87eaed0c21eac908e4 in the Linux Next branch. Dmitry, can you try reverting this commit and see if it makes the problem go away? Souptick, can we just NACK this patch and completely drop it from all trees? I think we need to be a *lot* more careful about this vm_fault_t patch thing. If you can't be bothered to run xfstests, we need to introduce a new function which replaces block_page_mkwrite() --- and then let each file system try to convert over to it at their own pace, after they've done regression testing. - Ted