* [PATCH] perf tools: Initialize perf_data_file fd field
@ 2018-08-29 20:16 Jérémie Galarneau
2018-09-05 16:09 ` Jiri Olsa
2018-09-25 9:33 ` [tip:perf/core] " tip-bot for Jérémie Galarneau
0 siblings, 2 replies; 5+ messages in thread
From: Jérémie Galarneau @ 2018-08-29 20:16 UTC (permalink / raw)
To: linux-kernel
Cc: Jérémie Galarneau, Jiri Olsa, Arnaldo Carvalho de Melo,
Peter Zijlstra, Ingo Molnar, Alexander Shishkin
Building the perf CTF converter fails with gcc 4.8.4
on Ubuntu 14.04 with the following error:
error: missing initializer for field ‘fd’ of ‘struct perf_data_file’
[-Werror=missing-field-initializers]
Per 4b838b0d and the ensuing discussion on the mailing
list, it appears that this affects other distributions
and gcc versions.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
tools/perf/util/data-convert-bt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index abd38abf1d91..f75d4aa612c5 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -1578,7 +1578,7 @@ int bt_convert__perf2ctf(const char *input, const char *path,
{
struct perf_session *session;
struct perf_data data = {
- .file.path = input,
+ .file = { .path = input, .fd = -1 },
.mode = PERF_DATA_MODE_READ,
.force = opts->force,
};
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] perf tools: Initialize perf_data_file fd field
2018-08-29 20:16 [PATCH] perf tools: Initialize perf_data_file fd field Jérémie Galarneau
@ 2018-09-05 16:09 ` Jiri Olsa
2018-09-18 18:07 ` Jérémie Galarneau
2018-09-25 9:33 ` [tip:perf/core] " tip-bot for Jérémie Galarneau
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Olsa @ 2018-09-05 16:09 UTC (permalink / raw)
To: Jérémie Galarneau
Cc: linux-kernel, Jiri Olsa, Arnaldo Carvalho de Melo,
Peter Zijlstra, Ingo Molnar, Alexander Shishkin
On Wed, Aug 29, 2018 at 04:16:48PM -0400, Jérémie Galarneau wrote:
> Building the perf CTF converter fails with gcc 4.8.4
> on Ubuntu 14.04 with the following error:
>
> error: missing initializer for field ‘fd’ of ‘struct perf_data_file’
> [-Werror=missing-field-initializers]
>
> Per 4b838b0d and the ensuing discussion on the mailing
> list, it appears that this affects other distributions
> and gcc versions.
>
> Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> ---
> tools/perf/util/data-convert-bt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> index abd38abf1d91..f75d4aa612c5 100644
> --- a/tools/perf/util/data-convert-bt.c
> +++ b/tools/perf/util/data-convert-bt.c
> @@ -1578,7 +1578,7 @@ int bt_convert__perf2ctf(const char *input, const char *path,
> {
> struct perf_session *session;
> struct perf_data data = {
> - .file.path = input,
> + .file = { .path = input, .fd = -1 },
> .mode = PERF_DATA_MODE_READ,
> .force = opts->force,
> };
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf tools: Initialize perf_data_file fd field
2018-09-05 16:09 ` Jiri Olsa
@ 2018-09-18 18:07 ` Jérémie Galarneau
2018-09-18 18:59 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 5+ messages in thread
From: Jérémie Galarneau @ 2018-09-18 18:07 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Jiri Olsa
Cc: lkml, Jiri Olsa, Peter Zijlstra, Ingo Molnar, Alexander Shishkin
Hi Arnaldo,
Anything I can do to help you with this patch?
Thanks,
Jérémie
On 5 September 2018 at 12:09, Jiri Olsa <jolsa@redhat.com> wrote:
> On Wed, Aug 29, 2018 at 04:16:48PM -0400, Jérémie Galarneau wrote:
>> Building the perf CTF converter fails with gcc 4.8.4
>> on Ubuntu 14.04 with the following error:
>>
>> error: missing initializer for field ‘fd’ of ‘struct perf_data_file’
>> [-Werror=missing-field-initializers]
>>
>> Per 4b838b0d and the ensuing discussion on the mailing
>> list, it appears that this affects other distributions
>> and gcc versions.
>>
>> Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> thanks,
> jirka
>
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
>> ---
>> tools/perf/util/data-convert-bt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
>> index abd38abf1d91..f75d4aa612c5 100644
>> --- a/tools/perf/util/data-convert-bt.c
>> +++ b/tools/perf/util/data-convert-bt.c
>> @@ -1578,7 +1578,7 @@ int bt_convert__perf2ctf(const char *input, const char *path,
>> {
>> struct perf_session *session;
>> struct perf_data data = {
>> - .file.path = input,
>> + .file = { .path = input, .fd = -1 },
>> .mode = PERF_DATA_MODE_READ,
>> .force = opts->force,
>> };
>> --
>> 2.18.0
>>
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf tools: Initialize perf_data_file fd field
2018-09-18 18:07 ` Jérémie Galarneau
@ 2018-09-18 18:59 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-18 18:59 UTC (permalink / raw)
To: Jérémie Galarneau
Cc: Jiri Olsa, lkml, Jiri Olsa, Peter Zijlstra, Ingo Molnar,
Alexander Shishkin
Em Tue, Sep 18, 2018 at 02:07:41PM -0400, Jérémie Galarneau escreveu:
> Hi Arnaldo,
>
> Anything I can do to help you with this patch?
Thanks for the reminder, will apply.
- Arnaldo
> Thanks,
> Jérémie
>
> On 5 September 2018 at 12:09, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Wed, Aug 29, 2018 at 04:16:48PM -0400, Jérémie Galarneau wrote:
> >> Building the perf CTF converter fails with gcc 4.8.4
> >> on Ubuntu 14.04 with the following error:
> >>
> >> error: missing initializer for field ‘fd’ of ‘struct perf_data_file’
> >> [-Werror=missing-field-initializers]
> >>
> >> Per 4b838b0d and the ensuing discussion on the mailing
> >> list, it appears that this affects other distributions
> >> and gcc versions.
> >>
> >> Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
> >
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
> >
> > thanks,
> > jirka
> >
> >> Cc: Jiri Olsa <jolsa@kernel.org>
> >> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> >> Cc: Peter Zijlstra <peterz@infradead.org>
> >> Cc: Ingo Molnar <mingo@redhat.com>
> >> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> >> ---
> >> tools/perf/util/data-convert-bt.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> >> index abd38abf1d91..f75d4aa612c5 100644
> >> --- a/tools/perf/util/data-convert-bt.c
> >> +++ b/tools/perf/util/data-convert-bt.c
> >> @@ -1578,7 +1578,7 @@ int bt_convert__perf2ctf(const char *input, const char *path,
> >> {
> >> struct perf_session *session;
> >> struct perf_data data = {
> >> - .file.path = input,
> >> + .file = { .path = input, .fd = -1 },
> >> .mode = PERF_DATA_MODE_READ,
> >> .force = opts->force,
> >> };
> >> --
> >> 2.18.0
> >>
>
>
>
> --
> Jérémie Galarneau
> EfficiOS Inc.
> http://www.efficios.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:perf/core] perf tools: Initialize perf_data_file fd field
2018-08-29 20:16 [PATCH] perf tools: Initialize perf_data_file fd field Jérémie Galarneau
2018-09-05 16:09 ` Jiri Olsa
@ 2018-09-25 9:33 ` tip-bot for Jérémie Galarneau
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Jérémie Galarneau @ 2018-09-25 9:33 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, jolsa, tglx, peterz, alexander.shishkin, linux-kernel,
jeremie.galarneau, mingo, hpa
Commit-ID: c04c859f439fb4de9039246370d60a07b9b5bcb5
Gitweb: https://git.kernel.org/tip/c04c859f439fb4de9039246370d60a07b9b5bcb5
Author: Jérémie Galarneau <jeremie.galarneau@efficios.com>
AuthorDate: Wed, 29 Aug 2018 16:16:48 -0400
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 19 Sep 2018 10:25:13 -0300
perf tools: Initialize perf_data_file fd field
Building the perf CTF converter fails with gcc 4.8.4 on Ubuntu 14.04
with the following error:
error: missing initializer for field ‘fd’ of ‘struct perf_data_file’
[-Werror=missing-field-initializers]
Per 4b838b0db4e9 ("perf tools: Add compression id into 'struct
kmod_path'") and the ensuing discussion on the mailing list, it appears
that this affects other distributions and gcc versions.
Signed-off-by: Jeremie Galarneau <jeremie.galarneau@efficios.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180829201648.19588-1-jeremie.galarneau@efficios.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/data-convert-bt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index abd38abf1d91..f75d4aa612c5 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -1578,7 +1578,7 @@ int bt_convert__perf2ctf(const char *input, const char *path,
{
struct perf_session *session;
struct perf_data data = {
- .file.path = input,
+ .file = { .path = input, .fd = -1 },
.mode = PERF_DATA_MODE_READ,
.force = opts->force,
};
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-25 9:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29 20:16 [PATCH] perf tools: Initialize perf_data_file fd field Jérémie Galarneau
2018-09-05 16:09 ` Jiri Olsa
2018-09-18 18:07 ` Jérémie Galarneau
2018-09-18 18:59 ` Arnaldo Carvalho de Melo
2018-09-25 9:33 ` [tip:perf/core] " tip-bot for Jérémie Galarneau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).