From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C5FC43334 for ; Wed, 5 Sep 2018 21:20:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D007C2077C for ; Wed, 5 Sep 2018 21:20:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="FcI8v8Bm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D007C2077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727693AbeIFBwb (ORCPT ); Wed, 5 Sep 2018 21:52:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:33736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727518AbeIFBwa (ORCPT ); Wed, 5 Sep 2018 21:52:30 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8B7A20652; Wed, 5 Sep 2018 21:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536182429; bh=LLoRrrlrxz4t426yWDgmUPWY5bO5ZTmBILbCqoP6m8I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FcI8v8BmMaPnWnBMgxj7cHOXUAIr+VdG1S2mMAxMsV+VegjBlMDom4L/e3nd08E65 JazVgMU0UNEz93R0e0iRPXqUulK9emZYUDCa3HHNwfOaiDGaUCaEWM3mYvyo6KBU+c jiV8nzg88GGP6RR1141UY/Sik6tKOrHnMk+0x86U= Date: Wed, 5 Sep 2018 16:20:28 -0500 From: Bjorn Helgaas To: Sinan Kaya Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , "open list:ACPI" , open list Subject: Re: [PATCH v2 1/2] PCI/ACPI: correct error message for ASPM disabling Message-ID: <20180905212028.GS107892@bhelgaas-glaptop.roam.corp.google.com> References: <1533875532-24954-1-git-send-email-okaya@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533875532-24954-1-git-send-email-okaya@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 10, 2018 at 04:32:11AM +0000, Sinan Kaya wrote: > If _OSC execution fails today for platforms without an _OSC > entry, code is printing a misleading message saying disabling > ASPM as follows: > > acpi PNP0A03:00: _OSC failed (AE_NOT_FOUND); disabling ASPM > > We need to ensure that platform supports ASPM to begin with. > > Signed-off-by: Sinan Kaya > Reported-by: Michael Kelley Tentatively applied both to pci/aspm for v4.20, thanks! Rafael, let me know if you object or would rather put these through your tree. > --- > drivers/acpi/pci_root.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c > index 7433035..e465e72 100644 > --- a/drivers/acpi/pci_root.c > +++ b/drivers/acpi/pci_root.c > @@ -455,8 +455,9 @@ static void negotiate_os_control(struct acpi_pci_root *root, int *no_aspm) > decode_osc_support(root, "OS supports", support); > status = acpi_pci_osc_support(root, support); > if (ACPI_FAILURE(status)) { > - dev_info(&device->dev, "_OSC failed (%s); disabling ASPM\n", > - acpi_format_exception(status)); > + dev_info(&device->dev, "_OSC failed (%s)%s\n", > + acpi_format_exception(status), > + pcie_aspm_support_enabled() ? "; disabling ASPM" : ""); > *no_aspm = 1; > return; > } > -- > 2.7.4 >