From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Mauricio Vasquez B <mauricio.vasquez@polito.it>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf] selftests/bpf/test_progs: do not check errno == 0
Date: Thu, 6 Sep 2018 11:00:20 -0700 [thread overview]
Message-ID: <20180906180019.a3u4tw322qhfkj3v@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <1535994119-4853-1-git-send-email-mauricio.vasquez@polito.it>
On Mon, Sep 03, 2018 at 07:01:59PM +0200, Mauricio Vasquez B wrote:
> The errno man page states: "The value in errno is significant only when
> the return value of the call indicated an error..." then it is not correct
> to check it, it could be different than zero even if the function
> succeeded.
>
> It causes some false positives if errno is set by a previous function.
>
> Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it>
Applied, Thanks
prev parent reply other threads:[~2018-09-06 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 17:01 [PATCH bpf] selftests/bpf/test_progs: do not check errno == 0 Mauricio Vasquez B
2018-09-06 18:00 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906180019.a3u4tw322qhfkj3v@ast-mbp.dhcp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mauricio.vasquez@polito.it \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).