From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DA1C433F5 for ; Fri, 7 Sep 2018 01:43:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 720C120857 for ; Fri, 7 Sep 2018 01:43:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 720C120857 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-sky.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728601AbeIGGWS (ORCPT ); Fri, 7 Sep 2018 02:22:18 -0400 Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:58709 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727810AbeIGGWS (ORCPT ); Fri, 7 Sep 2018 02:22:18 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.08512366|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03311;MF=ren_guo@c-sky.com;NM=1;PH=DS;RN=11;RT=11;SR=0;TI=SMTPD_---.CnUHLNu_1536284602; Received: from localhost(mailfrom:ren_guo@c-sky.com fp:SMTPD_---.CnUHLNu_1536284602) by smtp.aliyun-inc.com(10.147.41.187); Fri, 07 Sep 2018 09:43:22 +0800 Date: Fri, 7 Sep 2018 09:43:22 +0800 From: Guo Ren To: Arnd Bergmann Cc: linux-arch , Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Thomas Petazzoni , wbx@uclibc-ng.org, Greentime Hu Subject: Re: [PATCH V3 02/26] csky: defconfig Message-ID: <20180907014321.GA8288@guoren-Inspiron-7460> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 06, 2018 at 03:58:51PM +0200, Arnd Bergmann wrote: > On Wed, Sep 5, 2018 at 2:08 PM Guo Ren wrote: > > > > Signed-off-by: Guo Ren > > --- > > arch/csky/configs/defconfig | 76 +++++++++++++++++++++++++++++++++++++++++++++ > > +CONFIG_USELIB=y > > CONFIG_USELIB seems misplaced here, very few architectures can even > call that, and it's not in the asm-generic/unistd.h file. Ok, remove it. > > +CONFIG_RELAY=y > > relay is selected by drivers that need it, you should not need to turn > it on here. Ok, remove it. > > +CONFIG_SYSCTL_SYSCALL=y > > Also not in the asm-generic syscall table. We should probably hide the > CONFIG_USELIB and CONFIG_SYSCTL_SYSCALL options so they > only appear on architectures that can use them (patches welcome). Ok, remove it. > > > +CONFIG_KALLSYMS_ALL=y > > While useful for debugging, this is also something I would not expect > in the defconfig file Ok, remove it. > > +CONFIG_USERFAULTFD=y > > Probably not needed either, unless you have a specific use > case. Ok, remove it. > > +CONFIG_EMBEDDED=y > > This (and CONFIG_EXPERT) is mostly there to expose options > that are otherwise hidden for good reasons. Is there any option > you tweak that depends on this? If not, then remove this as well. Ok, remove it. > > +CONFIG_PROFILING=y > > This is only for oprofile, which new architectures should generally > no longer implement. Better implement PERF only. Ok, remove it and we will only implement perf in future. > > +CONFIG_BLK_DEV_INTEGRITY=y > > This is also fairly unusual. Ok, remove it. > > +CONFIG_EXT2_FS=y > > +CONFIG_EXT2_FS_XATTR=y > > +CONFIG_EXT2_FS_POSIX_ACL=y > > +CONFIG_EXT2_FS_SECURITY=y > > +CONFIG_EXT3_FS=y > > +CONFIG_EXT3_FS_POSIX_ACL=y > > +CONFIG_EXT3_FS_SECURITY=y > > Better enable only EXT4 and drop EXT2/EXT3. Ok. > > +CONFIG_UNUSED_SYMBOLS=y > > You should only need this to work around bugs, so > I'd turn it off. Ok, remove it. Guo Ren