From: Johannes Weiner <hannes@cmpxchg.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Suren Baghdasaryan <surenb@google.com>,
Daniel Drake <drake@endlessm.com>,
Vinayak Menon <vinmenon@codeaurora.org>,
Christopher Lameter <cl@linux.com>,
Peter Enderborg <peter.enderborg@sony.com>,
Shakeel Butt <shakeelb@google.com>,
Mike Galbraith <efault@gmx.de>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 8/9] psi: pressure stall information for CPU, memory, and IO
Date: Fri, 7 Sep 2018 10:54:04 -0400 [thread overview]
Message-ID: <20180907145404.GB11088@cmpxchg.org> (raw)
In-Reply-To: <20180907102458.GP24106@hirez.programming.kicks-ass.net>
On Fri, Sep 07, 2018 at 12:24:58PM +0200, Peter Zijlstra wrote:
> On Tue, Aug 28, 2018 at 01:22:57PM -0400, Johannes Weiner wrote:
> > +static void psi_clock(struct work_struct *work)
> > +{
> > + struct delayed_work *dwork;
> > + struct psi_group *group;
> > + bool nonidle;
> > +
> > + dwork = to_delayed_work(work);
> > + group = container_of(dwork, struct psi_group, clock_work);
> > +
> > + /*
> > + * If there is task activity, periodically fold the per-cpu
> > + * times and feed samples into the running averages. If things
> > + * are idle and there is no data to process, stop the clock.
> > + * Once restarted, we'll catch up the running averages in one
> > + * go - see calc_avgs() and missed_periods.
> > + */
> > +
> > + nonidle = update_stats(group);
> > +
> > + if (nonidle) {
> > + unsigned long delay = 0;
> > + u64 now;
> > +
> > + now = sched_clock();
> > + if (group->next_update > now)
> > + delay = nsecs_to_jiffies(group->next_update - now) + 1;
> > + schedule_delayed_work(dwork, delay);
> > + }
> > +}
>
> Just a little nit; I would expect a function called *clock() to return a
> time.
Fair enough, let's rename this. How about this on top?
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 92489e66840b..0f07749b60a4 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -154,7 +154,7 @@ static struct psi_group psi_system = {
.pcpu = &system_group_pcpu,
};
-static void psi_clock(struct work_struct *work);
+static void psi_update_work(struct work_struct *work);
static void group_init(struct psi_group *group)
{
@@ -163,7 +163,7 @@ static void group_init(struct psi_group *group)
for_each_possible_cpu(cpu)
seqcount_init(&per_cpu_ptr(group->pcpu, cpu)->seq);
group->next_update = sched_clock() + psi_period;
- INIT_DELAYED_WORK(&group->clock_work, psi_clock);
+ INIT_DELAYED_WORK(&group->clock_work, psi_update_work);
mutex_init(&group->stat_lock);
}
@@ -347,7 +347,7 @@ static bool update_stats(struct psi_group *group)
return nonidle_total;
}
-static void psi_clock(struct work_struct *work)
+static void psi_update_work(struct work_struct *work)
{
struct delayed_work *dwork;
struct psi_group *group;
next prev parent reply other threads:[~2018-09-07 14:54 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 17:22 [PATCH 0/9] psi: pressure stall information for CPU, memory, and IO v4 Johannes Weiner
2018-08-28 17:22 ` [PATCH 1/9] mm: workingset: don't drop refault information prematurely Johannes Weiner
2018-08-28 17:22 ` [PATCH 2/9] mm: workingset: tell cache transitions from workingset thrashing Johannes Weiner
2018-08-28 17:22 ` [PATCH 3/9] delayacct: track delays from thrashing cache pages Johannes Weiner
2018-08-28 17:22 ` [PATCH 4/9] sched: loadavg: consolidate LOAD_INT, LOAD_FRAC, CALC_LOAD Johannes Weiner
2018-09-12 23:28 ` Andrew Morton
2018-09-13 1:49 ` Johannes Weiner
2018-08-28 17:22 ` [PATCH 5/9] sched: loadavg: make calc_load_n() public Johannes Weiner
2018-08-28 17:22 ` [PATCH 6/9] sched: sched.h: make rq locking and clock functions available in stats.h Johannes Weiner
2018-08-28 17:22 ` [PATCH 7/9] sched: introduce this_rq_lock_irq() Johannes Weiner
2018-08-28 17:22 ` [PATCH 8/9] psi: pressure stall information for CPU, memory, and IO Johannes Weiner
2018-08-28 20:11 ` Randy Dunlap
2018-08-28 20:56 ` Johannes Weiner
2018-08-28 21:30 ` Randy Dunlap
2018-09-07 10:16 ` Peter Zijlstra
2018-09-07 10:21 ` Peter Zijlstra
2018-09-07 14:44 ` Johannes Weiner
2018-09-07 14:58 ` Peter Zijlstra
2018-09-07 17:50 ` Johannes Weiner
2018-09-07 10:24 ` Peter Zijlstra
2018-09-07 14:54 ` Johannes Weiner [this message]
2018-08-28 17:22 ` [PATCH 9/9] psi: cgroup support Johannes Weiner
2018-09-05 21:43 ` [PATCH 0/9] psi: pressure stall information for CPU, memory, and IO v4 Johannes Weiner
2018-09-07 7:36 ` Daniel Drake
2018-09-07 7:46 ` Peter Zijlstra
2018-09-07 11:04 ` Peter Zijlstra
2018-09-07 15:09 ` Johannes Weiner
2018-09-07 15:58 ` Suren Baghdasaryan
2018-09-17 5:22 ` Daniel Drake
2018-09-18 15:53 ` Suren Baghdasaryan
2018-09-25 22:05 ` Suren Baghdasaryan
2018-09-17 13:29 ` peter enderborg
2018-09-17 13:40 ` Peter Zijlstra
2018-09-18 16:03 ` Suren Baghdasaryan
2018-10-19 2:07 ` Andrew Morton
2018-10-23 17:29 ` Johannes Weiner
2018-10-23 17:41 ` Peter Zijlstra
[not found] <20180801151958.32590-1-hannes@cmpxchg.org>
2018-08-01 15:19 ` [PATCH 8/9] psi: pressure stall information for CPU, memory, and IO Johannes Weiner
2018-08-03 16:56 ` Peter Zijlstra
2018-08-06 15:05 ` Johannes Weiner
2018-08-06 15:25 ` Peter Zijlstra
2018-08-06 15:40 ` Johannes Weiner
2018-08-06 15:19 ` Johannes Weiner
2018-08-06 16:03 ` Peter Zijlstra
2018-08-21 19:44 ` Johannes Weiner
2018-08-22 9:16 ` Peter Zijlstra
2018-08-03 17:07 ` Peter Zijlstra
2018-08-06 15:23 ` Johannes Weiner
2018-08-03 17:15 ` Peter Zijlstra
2018-08-03 17:21 ` Peter Zijlstra
2018-08-21 20:11 ` Johannes Weiner
2018-08-22 9:10 ` Peter Zijlstra
2018-08-22 17:28 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907145404.GB11088@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=drake@endlessm.com \
--cc=efault@gmx.de \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peter.enderborg@sony.com \
--cc=peterz@infradead.org \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).