From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B6B8C43143 for ; Fri, 7 Sep 2018 21:42:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C86CB20844 for ; Fri, 7 Sep 2018 21:42:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.de header.i=@amazon.de header.b="HUDPlpa6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C86CB20844 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730564AbeIHCZR (ORCPT ); Fri, 7 Sep 2018 22:25:17 -0400 Received: from smtp-fw-4101.amazon.com ([72.21.198.25]:23443 "EHLO smtp-fw-4101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729963AbeIHCZR (ORCPT ); Fri, 7 Sep 2018 22:25:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1536356542; x=1567892542; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tO2d9SjIy2VaoxzjLta8KOcSohM7RwiCmkPZvPu4ekE=; b=HUDPlpa6N3iNyh97kiArcgfrzJ1LdVCV7htJ7BTh3bNMfF3YOvQN7Uty mEJDo0eB/6GVRMi4nUneHgS1LXxFeRjr0KaCcYVEegPif+uRovYasMSgl dzUao4/JnWix6b90P+mKEnUtoGf9OOEpBVS4tlQSGN/onvfe95aGpehjd 4=; X-IronPort-AV: E=Sophos;i="5.53,343,1531785600"; d="scan'208";a="737530466" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1d-2c665b5d.us-east-1.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Sep 2018 21:42:21 +0000 Received: from u7588a65da6b65f.ant.amazon.com (iad7-ws-svc-lb50-vlan3.amazon.com [10.0.93.214]) by email-inbound-relay-1d-2c665b5d.us-east-1.amazon.com (8.14.7/8.14.7) with ESMTP id w87LgF3f060417 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 7 Sep 2018 21:42:17 GMT Received: from u7588a65da6b65f.ant.amazon.com (localhost [127.0.0.1]) by u7588a65da6b65f.ant.amazon.com (8.15.2/8.15.2/Debian-3) with ESMTPS id w87LgD14027481 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 7 Sep 2018 23:42:13 +0200 Received: (from jschoenh@localhost) by u7588a65da6b65f.ant.amazon.com (8.15.2/8.15.2/Submit) id w87LgC3h027480; Fri, 7 Sep 2018 23:42:12 +0200 From: =?UTF-8?q?Jan=20H=2E=20Sch=C3=B6nherr?= To: Ingo Molnar , Peter Zijlstra Cc: =?UTF-8?q?Jan=20H=2E=20Sch=C3=B6nherr?= , linux-kernel@vger.kernel.org Subject: [RFC 30/60] cosched: Disallow share modification on task groups for now Date: Fri, 7 Sep 2018 23:40:17 +0200 Message-Id: <20180907214047.26914-31-jschoenh@amazon.de> X-Mailer: git-send-email 2.9.3.1.gcba166c.dirty In-Reply-To: <20180907214047.26914-1-jschoenh@amazon.de> References: <20180907214047.26914-1-jschoenh@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code path is not yet adjusted for coscheduling. Disable it for now. Signed-off-by: Jan H. Schönherr --- kernel/sched/fair.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 30e5ff30f442..8504790944bf 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9942,6 +9942,15 @@ int sched_group_set_shares(struct task_group *tg, unsigned long shares) { int i; +#ifdef CONFIG_COSCHEDULING + /* + * FIXME: This function has not been adjusted for coscheduling. + * Disable it completely for now. + */ + WARN_ON_ONCE(1); + return -EINVAL; +#endif + /* * We can't change the weight of the root cgroup. */ @@ -9955,6 +9964,7 @@ int sched_group_set_shares(struct task_group *tg, unsigned long shares) goto done; tg->shares = shares; + for_each_possible_cpu(i) { struct rq *rq = cpu_rq(i); struct sched_entity *se = tg->cfs_rq[i]->my_se; -- 2.9.3.1.gcba166c.dirty