linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Eli Friedman <efriedma@codeaurora.org>,
	Christopher Li <sparse@chrisli.org>,
	Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Joe Perches <joe@perches.com>,
	Dominique Martinet <asmadeus@codewreck.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-sparse@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 00/13] Compiler Attributes
Date: Sun, 9 Sep 2018 10:02:01 +0200	[thread overview]
Message-ID: <20180909080200.xn7z4gctf2vrqzst@ltop.local> (raw)
In-Reply-To: <20180908212459.19736-1-miguel.ojeda.sandonis@gmail.com>

On Sat, Sep 08, 2018 at 11:24:46PM +0200, Miguel Ojeda wrote:
> The Compiler Attributes series is an effort to disentangle
> the include/linux/compiler*.h headers and bring them up to date.
> 
> The main idea behind the series is to use feature checking macros
> (i.e. __has_attribute) instead of compiler version checks (e.g. GCC_VERSION),
> which are compiler-agnostic (so they can be shared, reducing the size
> of compiler-specific headers) and version-agnostic.
> 
> Other related improvements have been performed in the headers as well,
> which on top of the use of __has_attribute it has amounted to a significant
> simplification of these headers (e.g. GCC_VERSION is now only guarding 4
> non-attribute macros).
> 
> This series should also help the efforts to support compiling the kernel
> with clang and icc. A fair amount of documentation and comments have also
> been added, clarified or removed; and the headers are now more readable,
> which should help kernel developers in general.
> 
> The series was triggered due to the move to gcc >= 4.6. In turn, this series
> has also triggered Sparse to gain the ability to recognize __has_attribute
> on its own.
> 
> You can also fetch it from:
> 
>   https://github.com/ojeda/linux/tree/compiler-attributes-v4
> 
> Enjoy!

It's a nice and welcomed cleanup!
Everything look good to me, so feel free to add my
    Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>


Cheers,
-- Luc

  parent reply	other threads:[~2018-09-09  8:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-08 21:24 [PATCH v4 00/13] Compiler Attributes Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 01/13] Compiler Attributes: remove unused attributes Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 02/13] Compiler Attributes: always use the extra-underscores syntax Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 03/13] Compiler Attributes: remove unneeded tests Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 04/13] Compiler Attributes: homogenize __must_be_array Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 05/13] Compiler Attributes: naked was fixed in gcc 4.6 Miguel Ojeda
2018-09-10 17:45   ` Stefan Agner
2018-09-08 21:24 ` [PATCH v4 06/13] Compiler Attributes: naked can be shared Miguel Ojeda
2018-09-10 17:50   ` Stefan Agner
2018-09-08 21:24 ` [PATCH v4 07/13] Compiler Attributes: remove unneeded sparse (__CHECKER__) tests Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 08/13] Compiler Attributes: add missing SPDX ID in compiler_types.h Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 09/13] Compiler Attributes: use feature checks instead of version checks Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 10/13] Compiler Attributes: KENTRY used twice the "used" attribute Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 11/13] Compiler Attributes: remove uses of __attribute__ from compiler.h Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 12/13] Compiler Attributes: add Doc/process/programming-language.rst Miguel Ojeda
2018-09-09 18:19   ` Jonathan Corbet
2018-09-09 19:15     ` Miguel Ojeda
2018-09-08 21:24 ` [PATCH v4 13/13] Compiler Attributes: Add MAINTAINERS entry Miguel Ojeda
2018-09-09  8:02 ` Luc Van Oostenryck [this message]
2018-09-09 15:21   ` [PATCH v4 00/13] Compiler Attributes Miguel Ojeda
2018-09-09 16:52 ` Miguel Ojeda
2018-09-10 17:17 ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180909080200.xn7z4gctf2vrqzst@ltop.local \
    --to=luc.vanoostenryck@gmail.com \
    --cc=arnd@arndb.de \
    --cc=asmadeus@codewreck.org \
    --cc=corbet@lwn.net \
    --cc=efriedma@codeaurora.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mingo@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=sparse@chrisli.org \
    --cc=torvalds@linux-foundation.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).