From: Greg KH <gregkh@linuxfoundation.org>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: Simon Que <sque@chromium.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
John Joseph <jnjoseph@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Rob Springer <rspringer@google.com>,
devel@linuxdriverproject.org,
Andrew Morton <akpm@linux-foundation.org>,
Todd Poynor <toddpoynor@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [GIT PULL] Staging/IIO driver patches for 4.19-rc1
Date: Mon, 10 Sep 2018 10:16:26 +0200 [thread overview]
Message-ID: <20180910081626.GA31344@kroah.com> (raw)
In-Reply-To: <20180828143049.GA7388@darwi-kernel>
On Tue, Aug 28, 2018 at 02:30:49PM +0000, Ahmed S. Darwish wrote:
> Hi!
>
> On Tue, Aug 28, 2018 at 02:36:07PM +0200, Greg KH wrote:
> > On Tue, Aug 28, 2018 at 10:38:17AM +0000, Ahmed S. Darwish wrote:
> > > [ re-send; forgotten lkml CC added; sorry ]
> > >
> > > Hi,
> > >
> > > On Sat, 18 Aug 2018 17:57:24 +0200, Greg KH wrote:
> > > [...]
> > > > addition of some new IIO drivers. Also added was a "gasket" driver from
> > > > Google that needs loads of work and the erofs filesystem.
> > > >
> > >
> > > Why are we adding __a whole new in-kernel framework__ for
> > > developing basic user-space drivers?
> > >
> > > We already have a frameowrk for that, and it's UIO. [1] The UIO
> > > code is a very stable and simple subsystem; it's also heavily used
> > > in the embedded industry..
> >
> > As Todd said, the code will end up being a simple UIO driver, if even
> > that big, in th end. It is just going to take him a while to constantly
> > refactor things until he achieves that goal...
> >
> > > I've looked at the gasket documentation [2], and the first user
> > > of this new in-kernel API [3], and this is almost replicating UIO
> > > it's not funny. [4] True, the gasket APIs adds some extra new
> > > conveniences (PCI BAR re-mapping, MSI, ..), but there's no
> > > technical reason this cannot be added to the UIO code instead.
> >
> > {shh} That's my plan :)
> >
>
> Cool, thanks a lot.
>
> Can we then merge something like below patch?
>
> [ I've searched the gasket included TODO file before posting,
> but did not find any mention of UIO. Below patch will make
> sure this will not be forgotten over time.. ]
Looks good, can you resend it in a format I can apply it in (i.e. one
that does not require me to hand-edit a patch?)
thanks,
greg k-h
next prev parent reply other threads:[~2018-09-10 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 15:57 [GIT PULL] Staging/IIO driver patches for 4.19-rc1 Greg KH
2018-08-18 18:00 ` Linus Torvalds
2018-08-19 6:07 ` Greg Kroah-Hartman
2018-08-28 10:38 ` Ahmed S. Darwish
2018-08-28 11:20 ` Todd Poynor
2018-08-28 12:36 ` Greg KH
2018-08-28 14:30 ` Ahmed S. Darwish
2018-09-10 8:16 ` Greg KH [this message]
2018-09-10 15:28 ` [PATCH] staging: gasket: TODO: re-implement using UIO Ahmed S. Darwish
2018-11-07 0:20 ` RFC: staging: gasket: " Todd Poynor
2018-11-07 9:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910081626.GA31344@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=darwish.07@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=sfr@canb.auug.org.au \
--cc=sque@chromium.org \
--cc=toddpoynor@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).