linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: peterz@infradead.org, mingo@redhat.com,
	valentin.schneider@arm.com, dietmar.eggemann@arm.com,
	vincent.guittot@linaro.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] sched/topology: SD_ASYM_CPUCAPACITY flag detection
Date: Mon, 10 Sep 2018 10:21:11 +0200	[thread overview]
Message-ID: <20180910082111.GA48257@gmail.com> (raw)
In-Reply-To: <1532093554-30504-2-git-send-email-morten.rasmussen@arm.com>


* Morten Rasmussen <morten.rasmussen@arm.com> wrote:

> The SD_ASYM_CPUCAPACITY sched_domain flag is supposed to mark the
> sched_domain in the hierarchy where all cpu capacities are visible for
> any cpu's point of view on asymmetric cpu capacity systems. The

>  /*
> + * Find the sched_domain_topology_level where all cpu capacities are visible
> + * for all cpus.
> + */

> +	/*
> +	 * Examine topology from all cpu's point of views to detect the lowest
> +	 * sched_domain_topology_level where a highest capacity cpu is visible
> +	 * to everyone.
> +	 */

>  #define SD_WAKE_AFFINE               0x0020  /* Wake task to waking CPU */
> -#define SD_ASYM_CPUCAPACITY  0x0040  /* Groups have different max cpu capacities */
> +#define SD_ASYM_CPUCAPACITY  0x0040  /* Domain members have different cpu capacities */

For future reference: *please* capitalize 'CPU' and 'CPUs' in future patches like the rest of 
the scheduler does.

You can see it spelled right above the new definition: 'waking CPU' ;-)

(I fixed this up in this patch.)

Thanks!

	Ingo

  parent reply	other threads:[~2018-09-10  8:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 13:32 [PATCH 0/4] sched/topology: Set SD_ASYM_CPUCAPACITY flag automatically Morten Rasmussen
2018-07-20 13:32 ` [PATCH 1/4] sched/topology: SD_ASYM_CPUCAPACITY flag detection Morten Rasmussen
2018-07-23 13:25   ` Qais Yousef
2018-07-23 15:27     ` Morten Rasmussen
2018-07-23 16:07       ` Qais Yousef
2018-07-24  8:37         ` Morten Rasmussen
2018-07-24  8:59           ` Qais Yousef
2018-09-10  8:21   ` Ingo Molnar [this message]
2018-09-11 11:04     ` Morten Rasmussen
2018-09-10 10:11   ` [tip:sched/core] sched/topology: Add " tip-bot for Morten Rasmussen
2018-07-20 13:32 ` [PATCH 2/4] drivers/base/arch_topology: Rebuild sched_domain hierarchy when capacities change Morten Rasmussen
2018-09-10 10:11   ` [tip:sched/core] sched/topology, drivers/base/arch_topology: Rebuild the " tip-bot for Morten Rasmussen
2018-07-20 13:32 ` [PATCH 3/4] arch/arm64: Rebuild sched_domain hierarchy when cpu capacity changes Morten Rasmussen
2018-09-10 10:12   ` [tip:sched/core] sched/topology, arch/arm64: Rebuild the sched_domain hierarchy when the CPU " tip-bot for Morten Rasmussen
2018-07-20 13:32 ` [PATCH 4/4] arch/arm: Rebuild sched_domain hierarchy when cpu " Morten Rasmussen
2018-09-10 10:12   ` [tip:sched/core] sched/topology, arch/arm: Rebuild sched_domain hierarchy when CPU " tip-bot for Morten Rasmussen
2018-07-31 10:53 ` [PATCH 0/4] sched/topology: Set SD_ASYM_CPUCAPACITY flag automatically Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910082111.GA48257@gmail.com \
    --to=mingo@kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).