From: "Pasi Kärkkäinen" <pasik@iki.fi>
To: Sinan Kaya <okaya@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Bjorn Helgaas <helgaas@kernel.org>,
jgross@suse.com, Sinan Kaya <okaya@codeaurora.org>,
Govinda Tatti <Govinda.Tatti@Oracle.COM>,
Herbert Xu <herbert@gondor.apana.org.au>,
Satanand Burla <satananda.burla@caviumnetworks.com>,
linux-pci@vger.kernel.org,
Felix Manlunas <felix.manlunas@caviumnetworks.com>,
linux-kernel@vger.kernel.org,
Derek Chickles <derek.chickles@caviumnetworks.com>,
Srikanth Jampala <Jampala.Srikanth@cavium.com>,
JBeulich@suse.com, Russell Currey <ruscur@russell.cc>,
bhelgaas@google.com, xen-devel@lists.xenproject.org,
boris.ostrovsky@Oracle.COM,
Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>,
roger.pau@citrix.com
Subject: Re: [Xen-devel] [PATCH V3 1/2] Drivers/PCI: Export pcie_has_flr() interface
Date: Mon, 10 Sep 2018 12:52:31 +0300 [thread overview]
Message-ID: <20180910095231.GD18222@reaktio.net> (raw)
In-Reply-To: <9ffe43d2-a44b-974c-85c9-9923d71c5dba@kernel.org>
Hi,
On Sun, Sep 09, 2018 at 10:33:02PM -0400, Sinan Kaya wrote:
> On 9/9/2018 2:59 PM, Pasi Kärkkäinen wrote:
> >I noticed pcie_has_flr() has been recently exported in upstream Linux:
> >https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2d2917f7747805a1f4188672f308d82a8ba01700
> >
> >Are there more changes / cleanups planned to these interfaces, as mentioned last year?
> >
> >(context: xen-pciback reset/do_flr features upstreaming, which kind of stalled last year when pcie_has_flr() wasn't exported at the time)
>
> Exporting pcie_has_flr() is a very simple change which could have been done
> by the XEN porting effort.
>
> Maybe, the right question is what is so special about XEN reset?
>
> What feature PCI core is missing to support XEN FLR reset that caused
> the effort to stall?
>
Well one of the reasons probably was because Christoph was planning to deprecate the pcie_has_flr() functionality..
https://lists.xen.org/archives/html/xen-devel/2017-12/msg01057.html
https://lists.xen.org/archives/html/xen-devel/2017-12/msg01252.html
But now that pcie_has_flr() is exported and available I guess it's fine to continue using it also for xen-pciback :)
Thanks,
-- Pasi
next prev parent reply other threads:[~2018-09-10 9:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 22:21 [PATCH V3 0/2] Xen/PCIback: PCI reset using 'reset' SysFS attribute Govinda Tatti
2017-12-07 22:21 ` [PATCH V3 1/2] Drivers/PCI: Export pcie_has_flr() interface Govinda Tatti
2017-12-08 20:24 ` Bjorn Helgaas
2017-12-12 0:29 ` Govinda Tatti
2017-12-12 0:59 ` Bjorn Helgaas
2017-12-13 20:46 ` [Xen-devel] " Govinda Tatti
2017-12-13 21:24 ` Bjorn Helgaas
2017-12-14 12:52 ` Christoph Hellwig
2017-12-15 0:24 ` Bjorn Helgaas
2017-12-15 15:48 ` Govinda Tatti
2017-12-15 18:18 ` Bjorn Helgaas
2017-12-15 20:01 ` Govinda Tatti
2017-12-18 3:09 ` Alexey Kardashevskiy
2017-12-18 12:26 ` Christoph Hellwig
2017-12-18 17:22 ` Govinda Tatti
2018-09-09 18:59 ` Pasi Kärkkäinen
2018-09-10 2:33 ` Sinan Kaya
2018-09-10 9:52 ` Pasi Kärkkäinen [this message]
2018-09-10 17:04 ` Sinan Kaya
2017-12-12 15:07 ` Christoph Hellwig
2017-12-07 22:21 ` [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute Govinda Tatti
2017-12-08 9:34 ` Jan Beulich
2017-12-12 15:01 ` Govinda Tatti
[not found] ` <8a3bc517-1255-4547-d244-5c400e44cc77@Oracle.COM>
2017-12-12 15:01 ` Jan Beulich
2017-12-12 15:14 ` [Xen-devel] " Govinda Tatti
2017-12-15 19:52 ` Govinda Tatti
2017-12-18 7:36 ` Jan Beulich
2017-12-18 17:32 ` Boris Ostrovsky
2018-09-16 11:43 ` [Xen-devel] " Pasi Kärkkäinen
2018-09-17 18:06 ` Boris Ostrovsky
2018-09-18 7:15 ` Pasi Kärkkäinen
2018-09-18 9:32 ` George Dunlap
2018-09-18 18:09 ` Boris Ostrovsky
2018-09-19 9:05 ` Roger Pau Monné
2018-10-03 15:51 ` Pasi Kärkkäinen
2018-10-08 14:32 ` Boris Ostrovsky
2019-08-26 21:05 ` Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910095231.GD18222@reaktio.net \
--to=pasik@iki.fi \
--cc=Govinda.Tatti@Oracle.COM \
--cc=JBeulich@suse.com \
--cc=Jampala.Srikanth@cavium.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@Oracle.COM \
--cc=derek.chickles@caviumnetworks.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=okaya@kernel.org \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=roger.pau@citrix.com \
--cc=ruscur@russell.cc \
--cc=satananda.burla@caviumnetworks.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).