From: Lubomir Rintel <lkundrak@v3.sk>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Daniel Mack <daniel@zonque.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Bjorn Helgaas <bhelgaas@google.com>,
Lubomir Rintel <lkundrak@v3.sk>
Subject: [PATCH 3/5] spi: pxa2xx: use an enum for type
Date: Mon, 10 Sep 2018 13:59:33 +0200 [thread overview]
Message-ID: <20180910115935.163121-4-lkundrak@v3.sk> (raw)
In-Reply-To: <20180910115935.163121-1-lkundrak@v3.sk>
That seems to be the correct type.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
drivers/spi/spi-pxa2xx.c | 6 +++---
include/linux/pxa2xx_ssp.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 14f4ea59caff..f674541675bb 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1429,7 +1429,7 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev)
struct resource *res;
const struct acpi_device_id *adev_id = NULL;
const struct pci_device_id *pcidev_id = NULL;
- int type;
+ enum pxa_ssp_type type;
adev = ACPI_COMPANION(&pdev->dev);
@@ -1443,9 +1443,9 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev)
return NULL;
if (adev_id)
- type = (int)adev_id->driver_data;
+ type = (enum pxa_ssp_type)adev_id->driver_data;
else if (pcidev_id)
- type = (int)pcidev_id->driver_data;
+ type = (enum pxa_ssp_type)pcidev_id->driver_data;
else
return NULL;
diff --git a/include/linux/pxa2xx_ssp.h b/include/linux/pxa2xx_ssp.h
index 13b4244d44c1..262e1f318836 100644
--- a/include/linux/pxa2xx_ssp.h
+++ b/include/linux/pxa2xx_ssp.h
@@ -217,7 +217,7 @@ struct ssp_device {
const char *label;
int port_id;
- int type;
+ enum pxa_ssp_type type;
int use_count;
int irq;
--
2.17.1
next prev parent reply other threads:[~2018-09-10 12:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 11:59 [PATCH 0/5] Make SPI work on DT MMP2 Lubomir Rintel
2018-09-10 11:59 ` [PATCH 1/5] dt-bindings: spi/spi-pxa2xx: add PXA2xx SSP SPI Controller Lubomir Rintel
2018-09-10 11:59 ` [PATCH 2/5] PCI: provide pci_match_id() with CONFIG_PCI=n Lubomir Rintel
2018-09-12 17:17 ` Bjorn Helgaas
2018-09-10 11:59 ` Lubomir Rintel [this message]
2018-09-21 20:34 ` [PATCH 3/5] spi: pxa2xx: use an enum for type Robert Jarzmik
2018-10-09 16:43 ` Lubomir Rintel
2018-10-10 17:26 ` Lubomir Rintel
2018-09-10 11:59 ` [PATCH 4/5] spi: pxa2xx: add devicetree support Lubomir Rintel
2018-09-10 11:59 ` [PATCH 5/5] DT: marvell,mmp2: add SSP1 and SSP3 Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910115935.163121-4-lkundrak@v3.sk \
--to=lkundrak@v3.sk \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).