From: Mark Brown <broonie@kernel.org>
To: zhong jiang <zhongjiang@huawei.com>
Cc: tiwai@suse.com, perex@perex.cz, lgirdwood@gmail.com,
bgoswami@codeaurora.org, plai@codeaurora.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] sound: q6core: Use kmemdup to replace kzalloc + memcpy
Date: Mon, 10 Sep 2018 15:19:28 +0100 [thread overview]
Message-ID: <20180910141928.GI5856@sirena.org.uk> (raw)
In-Reply-To: <1536395780-18725-2-git-send-email-zhongjiang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On Sat, Sep 08, 2018 at 04:36:19PM +0800, zhong jiang wrote:
> kmemdup has implemented the function that kzalloc() + memcpy() will
> do. and we prefer to use the kmemdup rather than the open coded implementation.
Please submit patches using subject lines reflecting the style for the
subsystem. This makes it easier for people to identify relevant
patches. Look at what existing commits in the area you're changing are
doing and make sure your subject lines visually resemble what they're
doing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-09-10 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 8:36 [PATCH 0/2] sound: Use kmemdup to replace kzalloc + memcpy zhong jiang
2018-09-08 8:36 ` [PATCH 1/2] sound: q6core: " zhong jiang
2018-09-10 14:19 ` Mark Brown [this message]
2018-09-11 1:13 ` zhong jiang
2018-09-08 8:36 ` [PATCH 2/2] sound: skl-topology: " zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910141928.GI5856@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=tiwai@suse.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).