Re: [PATCH v3 12/13] ASoC: apq8096: add slim support

From: kbuild test robot <lkp@intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: kbuild-all@01.org, lee.jones@linaro.org, robh+dt@kernel.org,
	broonie@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com,
	bgoswami@codeaurora.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, vkoul@kernel.org,
	alsa-devel@alsa-project.org,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH v3 12/13] ASoC: apq8096: add slim support
Date: Mon, 10 Sep 2018 16:24:53 +0800	[thread overview]
Message-ID: <201809101628.CQsRYjh5%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180904102500.30318-13-srinivas.kandagatla@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

Hi Srinivas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on asoc/for-next]
[also build test WARNING on v4.19-rc2 next-20180906]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/ASoC-Add-support-to-WCD9335-Audio-Codec/20180907-143558
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   sound/soc//qcom/apq8096.c: In function 'apq8096_be_hw_params_fixup':
>> sound/soc//qcom/apq8096.c:26:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^

vim +26 sound/soc//qcom/apq8096.c

    15	
    16	static int apq8096_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
    17					      struct snd_pcm_hw_params *params)
    18	{
    19		struct snd_interval *rate = hw_param_interval(params,
    20						SNDRV_PCM_HW_PARAM_RATE);
    21		struct snd_interval *channels = hw_param_interval(params,
    22						SNDRV_PCM_HW_PARAM_CHANNELS);
    23	
    24		rate->min = rate->max = 48000;
    25		channels->min = channels->max = 2;
  > 26	}
    27	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67166 bytes --]