From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E66C46469 for ; Wed, 12 Sep 2018 06:54:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCBCF20833 for ; Wed, 12 Sep 2018 06:54:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCBCF20833 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727441AbeILL5Y (ORCPT ); Wed, 12 Sep 2018 07:57:24 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57538 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726555AbeILL5Y (ORCPT ); Wed, 12 Sep 2018 07:57:24 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 417FC12DE57F3; Tue, 11 Sep 2018 23:54:18 -0700 (PDT) Date: Tue, 11 Sep 2018 23:54:17 -0700 (PDT) Message-Id: <20180911.235417.1481257495387934935.davem@davemloft.net> To: zhongjiang@huawei.com Cc: edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ipv4: Use BUG_ON directly instead of a if condition followed by BUG From: David Miller In-Reply-To: <1536590282-23899-1-git-send-email-zhongjiang@huawei.com> References: <1536590282-23899-1-git-send-email-zhongjiang@huawei.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 11 Sep 2018 23:54:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhong jiang Date: Mon, 10 Sep 2018 22:38:02 +0800 > The if condition can be removed if we use BUG_ON directly. > The issule is detected with the help of Coccinelle. > > Signed-off-by: zhong jiang You keep asking if this is worthy to do. I think the most worthy thing to do is actually build test your patches.