linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: gregkh <gregkh@linuxfoundation.org>
To: Ajay Singh <ajay.kathat@microchip.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	driverdevel <devel@driverdev.osuosl.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	ganesh.krishna@microchip.com, aditya.shankar@microchip.com
Subject: Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"
Date: Tue, 11 Sep 2018 10:21:10 +0200	[thread overview]
Message-ID: <20180911082110.GB17267@kroah.com> (raw)
In-Reply-To: <20180910160836.24efb0b9@ajaysk-VirtualBox>

On Mon, Sep 10, 2018 at 04:08:36PM +0530, Ajay Singh wrote:
> Hi Greg,
> 
> On Tue, 14 Aug 2018 10:43:35 +0200
> gregkh <gregkh@linuxfoundation.org> wrote:
> 
> > On Tue, Aug 14, 2018 at 10:34:27AM +0200, Arnd Bergmann wrote:
> > > On Tue, Aug 14, 2018 at 7:22 AM Ajay Singh
> > > <ajay.kathat@microchip.com> wrote:
> > > >
> > > > Hi Arnd,
> > > >
> > > > On Mon, 13 Aug 2018 23:20:33 +0200
> > > > Arnd Bergmann <arnd@arndb.de> wrote:
> > > >
> > > > > The TODO item named "make spi and sdio components coexist in one
> > > > > build" was apparently addressed a long time ago, but never
> > > > > removed from the TODO file. However, the new patch that tries
> > > > > to address it actually makes it worse again by duplicating the
> > > > > common parts of the driver into two separate modules rather
> > > > > than sharing them. This also introduces a build regression when
> > > > > one of the two is built-in while the other is a loadable module:
> > > >
> > > > Thanks for sharing your inputs and submitting patch.
> > > > I have also submitted a patch to address the compilation error[1].
> > > > We can ignore my patch and proceed with your changes.
> > > >
> > > > [1].https://patchwork.kernel.org/patch/10563873/
> > > 
> > > That patch seems useful regardless, as it removes dead code,
> > > but I'd still prefer to revert staging-linusthe 9abc44ba4e2f ("staging: wilc1000:
> > > fix TODO to compile spi and sdio components in single module")
> > > commit for the other reasons I explained.
> > 
> > I agree, I'll queue it up soon, I have other patches to get to Linus
> > first.
> > 
> 
> This patch is applied only to 'staging-linus' in commit f45b893 and
> it's not applied to 'staging-testing/next' tree. 
> Please apply this patch to 'staging-next' tree also. Because I have one
> patch to submit on top of these changes to delete the 'wilc_debug.c'
> unused file.

I will merge the staging-linus branch into staging-testing once Linus
pulls them in.  Should happen next Monday or so.  You can send me
patches that build on top of this now, I'll just wait until then to
apply them to my tree.

thanks,

greg k-h

  reply	other threads:[~2018-09-11  8:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13 21:20 [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module" Arnd Bergmann
2018-08-14  5:22 ` Ajay Singh
2018-08-14  8:34   ` Arnd Bergmann
2018-08-14  8:43     ` gregkh
2018-09-10 10:38       ` Ajay Singh
2018-09-11  8:21         ` gregkh [this message]
2018-09-10 12:42           ` Ajay Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180911082110.GB17267@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aditya.shankar@microchip.com \
    --cc=ajay.kathat@microchip.com \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=ganesh.krishna@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).