linux-next: build warning after merge of the usb tree

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/usb/core/hcd.c: In function '__usb_hcd_giveback_urb':
drivers/usb/core/hcd.c:1741:16: warning: unused variable 'flags' [-Wunused-variable]
  unsigned long flags;
                ^~~~~

Introduced by commit

  ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH] usb: core: remove flags variable in __usb_hcd_giveback_urb()

[Sebastian Andrzej Siewior]

In commit ed194d1367698 ("usb: core: remove local_irq_save() around
->complete() handler") I removed the only user of the flags variable and
forgot to remove the variable, leading to warning because it is unused
now.
Remove the unused variable.

Fixes: ed194d1367698 ("usb: core: remove local_irq_save() around
       ->complete() handler")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/usb/core/hcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index f985d2303095c..487025d31d44c 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1738,7 +1738,6 @@ static void __usb_hcd_giveback_urb(struct urb *urb)
 	struct usb_hcd *hcd = bus_to_hcd(urb->dev->bus);
 	struct usb_anchor *anchor = urb->anchor;
 	int status = urb->unlinked;
-	unsigned long flags;
 
 	urb->hcpriv = NULL;
 	if (unlikely((urb->transfer_flags & URB_SHORT_NOT_OK) &&
-- 
2.19.0.rc2

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Tue, Sep 11, 2018 at 12:47:43PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the usb tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/usb/core/hcd.c: In function '__usb_hcd_giveback_urb':
> drivers/usb/core/hcd.c:1741:16: warning: unused variable 'flags' [-Wunused-variable]
>   unsigned long flags;
>                 ^~~~~
> 
> Introduced by commit
> 
>   ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")

Ugh, sorry I missed this :(

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/usb/gadget-testing.rst:459: ERROR: Malformed table.
Text in column margin in table line 9.

===============   ==================================================
ifname            network device interface name associated with this
                  function instance
qmult             queue length multiplier for high and super speed
host_addr         MAC address of host's end of this
                  Ethernet over USB link
dev_addr          MAC address of device's end of this
                  Ethernet over USB link
max_segment_size  Segment size required for P2P connections. This
                  will set MTU to (max_segment_size - 14 bytes)
===============   ==================================================

Introduced by commit

  1900daeefd3e ("usb: gadget: ncm: Add support to update wMaxSegmentSize via configfs")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Mon, Jan 08, 2024 at 04:02:21PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/usb/gadget-testing.rst:459: ERROR: Malformed table.
> Text in column margin in table line 9.
> 
> ===============   ==================================================
> ifname            network device interface name associated with this
>                   function instance
> qmult             queue length multiplier for high and super speed
> host_addr         MAC address of host's end of this
>                   Ethernet over USB link
> dev_addr          MAC address of device's end of this
>                   Ethernet over USB link
> max_segment_size  Segment size required for P2P connections. This
>                   will set MTU to (max_segment_size - 14 bytes)
> ===============   ==================================================
> 
> Introduced by commit
> 
>   1900daeefd3e ("usb: gadget: ncm: Add support to update wMaxSegmentSize via configfs")

Krishna, can you send a fixup patch for this?

thanks,

greg k-h

Re: linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

Hi all,

On Mon, 8 Jan 2024 08:54:39 +0100 Greg KH <greg@kroah.com> wrote:
>
> On Mon, Jan 08, 2024 at 04:02:21PM +1100, Stephen Rothwell wrote:
> > 
> > After merging the usb tree, today's linux-next build (htmldocs) produced
> > this warning:
> > 
> > Documentation/usb/gadget-testing.rst:459: ERROR: Malformed table.
> > Text in column margin in table line 9.
> > 
> > ===============   ==================================================
> > ifname            network device interface name associated with this
> >                   function instance
> > qmult             queue length multiplier for high and super speed
> > host_addr         MAC address of host's end of this
> >                   Ethernet over USB link
> > dev_addr          MAC address of device's end of this
> >                   Ethernet over USB link
> > max_segment_size  Segment size required for P2P connections. This
> >                   will set MTU to (max_segment_size - 14 bytes)
> > ===============   ==================================================
> > 
> > Introduced by commit
> > 
> >   1900daeefd3e ("usb: gadget: ncm: Add support to update wMaxSegmentSize via configfs")  
> 
> Krishna, can you send a fixup patch for this?

I am still seeing this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Krishna Kurapati PSSNV]

On 1/25/2024 6:05 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 8 Jan 2024 08:54:39 +0100 Greg KH <greg@kroah.com> wrote:
>>
>> On Mon, Jan 08, 2024 at 04:02:21PM +1100, Stephen Rothwell wrote:
>>>
>>> After merging the usb tree, today's linux-next build (htmldocs) produced
>>> this warning:
>>>
>>> Documentation/usb/gadget-testing.rst:459: ERROR: Malformed table.
>>> Text in column margin in table line 9.
>>>
>>> ===============   ==================================================
>>> ifname            network device interface name associated with this
>>>                    function instance
>>> qmult             queue length multiplier for high and super speed
>>> host_addr         MAC address of host's end of this
>>>                    Ethernet over USB link
>>> dev_addr          MAC address of device's end of this
>>>                    Ethernet over USB link
>>> max_segment_size  Segment size required for P2P connections. This
>>>                    will set MTU to (max_segment_size - 14 bytes)
>>> ===============   ==================================================
>>>
>>> Introduced by commit
>>>
>>>    1900daeefd3e ("usb: gadget: ncm: Add support to update wMaxSegmentSize via configfs")
>>
>> Krishna, can you send a fixup patch for this?
> 
> I am still seeing this warning.
> 
HI Stephen,

  Udipto and Randy sent patches for fixing this:

https://lore.kernel.org/all/20240108132720.7786-1-quic_ugoswami@quicinc.com/

https://lore.kernel.org/all/20240110203558.2638-1-rdunlap@infradead.org/

Greg, can you help pick one of them up.

Regards,
Krishna,

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Thu, Jan 25, 2024 at 11:23:56AM +0530, Krishna Kurapati PSSNV wrote:
> 
> 
> On 1/25/2024 6:05 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > On Mon, 8 Jan 2024 08:54:39 +0100 Greg KH <greg@kroah.com> wrote:
> > > 
> > > On Mon, Jan 08, 2024 at 04:02:21PM +1100, Stephen Rothwell wrote:
> > > > 
> > > > After merging the usb tree, today's linux-next build (htmldocs) produced
> > > > this warning:
> > > > 
> > > > Documentation/usb/gadget-testing.rst:459: ERROR: Malformed table.
> > > > Text in column margin in table line 9.
> > > > 
> > > > ===============   ==================================================
> > > > ifname            network device interface name associated with this
> > > >                    function instance
> > > > qmult             queue length multiplier for high and super speed
> > > > host_addr         MAC address of host's end of this
> > > >                    Ethernet over USB link
> > > > dev_addr          MAC address of device's end of this
> > > >                    Ethernet over USB link
> > > > max_segment_size  Segment size required for P2P connections. This
> > > >                    will set MTU to (max_segment_size - 14 bytes)
> > > > ===============   ==================================================
> > > > 
> > > > Introduced by commit
> > > > 
> > > >    1900daeefd3e ("usb: gadget: ncm: Add support to update wMaxSegmentSize via configfs")
> > > 
> > > Krishna, can you send a fixup patch for this?
> > 
> > I am still seeing this warning.
> > 
> HI Stephen,
> 
>  Udipto and Randy sent patches for fixing this:
> 
> https://lore.kernel.org/all/20240108132720.7786-1-quic_ugoswami@quicinc.com/
> 
> https://lore.kernel.org/all/20240110203558.2638-1-rdunlap@infradead.org/
> 
> Greg, can you help pick one of them up.

I will, sorry, at a conference this week, will catch up this weekend...

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/ABI/testing/configfs-usb-gadget-uvc:14: ERROR: Malformed table.
Text in column margin in table line 4.

================        =============================
bInterfaceNumber        USB interface number for this
                        streaming interface
enable_interrupt_ep     flag to enable the interrupt
                        endpoint for the VC interface
================        =============================

Introduced by commit

  a36afe780461 ("usb: gadget: uvc: Add new enable_interrupt_ep attribute")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Mon, Feb 06, 2023 at 02:50:04PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/ABI/testing/configfs-usb-gadget-uvc:14: ERROR: Malformed table.
> Text in column margin in table line 4.
> 
> ================        =============================
> bInterfaceNumber        USB interface number for this
>                         streaming interface
> enable_interrupt_ep     flag to enable the interrupt
>                         endpoint for the VC interface
> ================        =============================
> 
> Introduced by commit
> 
>   a36afe780461 ("usb: gadget: uvc: Add new enable_interrupt_ep attribute")

Sorry about this, it's been reported for a while and I think we have a
working patch for this in my review queue.  I'll push it out soon.

thanks,

greg k-h

Re: linux-next: build warning after merge of the usb tree

[Dan Scally]

Thanks Stephen, and sorry Greg - I should have noticed that, I'll figure 
out why I didn't. Does this just need a patch on top or some other 
process to be fixed?

On 06/02/2023 03:50, Stephen Rothwell wrote:
> Hi all,
>
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
>
> Documentation/ABI/testing/configfs-usb-gadget-uvc:14: ERROR: Malformed table.
> Text in column margin in table line 4.
>
> ================        =============================
> bInterfaceNumber        USB interface number for this
>                          streaming interface
> enable_interrupt_ep     flag to enable the interrupt
>                          endpoint for the VC interface
> ================        =============================
>
> Introduced by commit
>
>    a36afe780461 ("usb: gadget: uvc: Add new enable_interrupt_ep attribute")
>

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Mon, Feb 06, 2023 at 07:45:54AM +0000, Dan Scally wrote:
> Thanks Stephen, and sorry Greg - I should have noticed that, I'll figure out
> why I didn't. Does this just need a patch on top or some other process to be
> fixed?
> 
> On 06/02/2023 03:50, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the usb tree, today's linux-next build (htmldocs) produced
> > this warning:
> > 
> > Documentation/ABI/testing/configfs-usb-gadget-uvc:14: ERROR: Malformed table.
> > Text in column margin in table line 4.
> > 
> > ================        =============================
> > bInterfaceNumber        USB interface number for this
> >                          streaming interface
> > enable_interrupt_ep     flag to enable the interrupt
> >                          endpoint for the VC interface
> > ================        =============================
> > 
> > Introduced by commit
> > 
> >    a36afe780461 ("usb: gadget: uvc: Add new enable_interrupt_ep attribute")
> > 

Oops, this is a different error than my original response, I don't have
a patch for this :(

Dan, just send a follow-on patch for this and I'll queue it up.

thanks,

greg k-h

Re: linux-next: build warning after merge of the usb tree

[Bagas Sanjaya]

On 2/6/23 14:45, Dan Scally wrote:
> Thanks Stephen, and sorry Greg - I should have noticed that, I'll figure out why I didn't. Does this just need a patch on top or some other process to be fixed?
> 

Please send the fixup on top of recent usb tree.

-- 
An old man doll... just what I always wanted! - Clara

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 743 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/usb/composite.h:510: warning: Function parameter or member 'bcd_webusb_version' not described in 'usb_composite_dev'
include/linux/usb/composite.h:510: warning: Function parameter or member 'b_webusb_vendor_code' not described in 'usb_composite_dev'
include/linux/usb/composite.h:510: warning: Function parameter or member 'landing_page' not described in 'usb_composite_dev'
include/linux/usb/composite.h:510: warning: Function parameter or member 'use_webusb' not described in 'usb_composite_dev'

Introduced by commit

  93c473948c58 ("usb: gadget: add WebUSB landing page support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Mon, Jan 23, 2023 at 03:24:30PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> include/linux/usb/composite.h:510: warning: Function parameter or member 'bcd_webusb_version' not described in 'usb_composite_dev'
> include/linux/usb/composite.h:510: warning: Function parameter or member 'b_webusb_vendor_code' not described in 'usb_composite_dev'
> include/linux/usb/composite.h:510: warning: Function parameter or member 'landing_page' not described in 'usb_composite_dev'
> include/linux/usb/composite.h:510: warning: Function parameter or member 'use_webusb' not described in 'usb_composite_dev'
> 
> Introduced by commit
> 
>   93c473948c58 ("usb: gadget: add WebUSB landing page support")

Jó, can you send a follow-on patch to fix this issue please?

thanks,

greg k-h

Re: linux-next: build warning after merge of the usb tree

[Jó Ágila Bitsch]

On Mon, Jan 23, 2023 at 3:42 PM Greg KH <greg@kroah.com> wrote:
>
> On Mon, Jan 23, 2023 at 03:24:30PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the usb tree, today's linux-next build (htmldocs) produced
> > this warning:
> >
> > include/linux/usb/composite.h:510: warning: Function parameter or member 'bcd_webusb_version' not described in 'usb_composite_dev'
> > include/linux/usb/composite.h:510: warning: Function parameter or member 'b_webusb_vendor_code' not described in 'usb_composite_dev'
> > include/linux/usb/composite.h:510: warning: Function parameter or member 'landing_page' not described in 'usb_composite_dev'
> > include/linux/usb/composite.h:510: warning: Function parameter or member 'use_webusb' not described in 'usb_composite_dev'
> >
> > Introduced by commit
> >
> >   93c473948c58 ("usb: gadget: add WebUSB landing page support")
>
> Jó, can you send a follow-on patch to fix this issue please?
>
> thanks,
>
> greg k-h

I just posted a new version where I also merged in Andy Shevchenko's
patches against by patch.

Best regards,
Jó

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/ABI/testing/configfs-usb-gadget-mass-storage:17: WARNING: Malformed table.
Text in column margin in table line 14.

===========     ==============================================
file            The path to the backing file for the LUN.
                Required if LUN is not marked as removable.
ro              Flag specifying access to the LUN shall be
                read-only. This is implied if CD-ROM emulation
                is enabled as well as when it was impossible
                to open "filename" in R/W mode.
removable       Flag specifying that LUN shall be indicated as
                being removable.
cdrom           Flag specifying that LUN shall be reported as
                being a CD-ROM.
nofua           Flag specifying that FUA flag
                in SCSI WRITE(10,12)
forced_eject    This write-only file is useful only when
                the function is active. It causes the backing
                file to be forcibly detached from the LUN,
                regardless of whether the host has allowed it.
                Any non-zero number of bytes written will
                result in ejection.
===========     ==============================================

Introduced by commit

  421c8d9a20da ("usb: gadget: f_mass_storage: forced_eject attribute")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Maxim Devaev]

В Tue, 19 Jul 2022 19:43:37 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/ABI/testing/configfs-usb-gadget-mass-storage:17: WARNING: Malformed table.
> Text in column margin in table line 14.
> 
> ===========     ==============================================
> file            The path to the backing file for the LUN.
>                 Required if LUN is not marked as removable.
> ro              Flag specifying access to the LUN shall be
>                 read-only. This is implied if CD-ROM emulation
>                 is enabled as well as when it was impossible
>                 to open "filename" in R/W mode.
> removable       Flag specifying that LUN shall be indicated as
>                 being removable.
> cdrom           Flag specifying that LUN shall be reported as
>                 being a CD-ROM.
> nofua           Flag specifying that FUA flag
>                 in SCSI WRITE(10,12)
> forced_eject    This write-only file is useful only when
>                 the function is active. It causes the backing
>                 file to be forcibly detached from the LUN,
>                 regardless of whether the host has allowed it.
>                 Any non-zero number of bytes written will
>                 result in ejection.
> ===========     ==============================================
> 
> Introduced by commit
> 
>   421c8d9a20da ("usb: gadget: f_mass_storage: forced_eject attribute")
> 

Sorry. Should I send a patch?

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Tue, Jul 19, 2022 at 01:25:59PM +0300, Maxim Devaev wrote:
> В Tue, 19 Jul 2022 19:43:37 +1000
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi all,
> > 
> > After merging the usb tree, today's linux-next build (htmldocs) produced
> > this warning:
> > 
> > Documentation/ABI/testing/configfs-usb-gadget-mass-storage:17: WARNING: Malformed table.
> > Text in column margin in table line 14.
> > 
> > ===========     ==============================================
> > file            The path to the backing file for the LUN.
> >                 Required if LUN is not marked as removable.
> > ro              Flag specifying access to the LUN shall be
> >                 read-only. This is implied if CD-ROM emulation
> >                 is enabled as well as when it was impossible
> >                 to open "filename" in R/W mode.
> > removable       Flag specifying that LUN shall be indicated as
> >                 being removable.
> > cdrom           Flag specifying that LUN shall be reported as
> >                 being a CD-ROM.
> > nofua           Flag specifying that FUA flag
> >                 in SCSI WRITE(10,12)
> > forced_eject    This write-only file is useful only when
> >                 the function is active. It causes the backing
> >                 file to be forcibly detached from the LUN,
> >                 regardless of whether the host has allowed it.
> >                 Any non-zero number of bytes written will
> >                 result in ejection.
> > ===========     ==============================================
> > 
> > Introduced by commit
> > 
> >   421c8d9a20da ("usb: gadget: f_mass_storage: forced_eject attribute")
> > 
> 
> Sorry. Should I send a patch?

Yes please.

Re: linux-next: build warning after merge of the usb tree

[Maxim Devaev]

On Tue, 19 Jul 2022 13:24:18 +0200
Greg KH <greg@kroah.com> wrote:

> On Tue, Jul 19, 2022 at 01:25:59PM +0300, Maxim Devaev wrote:
> > В Tue, 19 Jul 2022 19:43:37 +1000
> > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >   
> > > Hi all,
> > > 
> > > After merging the usb tree, today's linux-next build (htmldocs) produced
> > > this warning:
> > > 
> > > Documentation/ABI/testing/configfs-usb-gadget-mass-storage:17: WARNING: Malformed table.
> > > Text in column margin in table line 14.
> > > 
> > > ===========     ==============================================
> > > file            The path to the backing file for the LUN.
> > >                 Required if LUN is not marked as removable.
> > > ro              Flag specifying access to the LUN shall be
> > >                 read-only. This is implied if CD-ROM emulation
> > >                 is enabled as well as when it was impossible
> > >                 to open "filename" in R/W mode.
> > > removable       Flag specifying that LUN shall be indicated as
> > >                 being removable.
> > > cdrom           Flag specifying that LUN shall be reported as
> > >                 being a CD-ROM.
> > > nofua           Flag specifying that FUA flag
> > >                 in SCSI WRITE(10,12)
> > > forced_eject    This write-only file is useful only when
> > >                 the function is active. It causes the backing
> > >                 file to be forcibly detached from the LUN,
> > >                 regardless of whether the host has allowed it.
> > >                 Any non-zero number of bytes written will
> > >                 result in ejection.
> > > ===========     ==============================================
> > > 
> > > Introduced by commit
> > > 
> > >   421c8d9a20da ("usb: gadget: f_mass_storage: forced_eject attribute")
> > >   
> > 
> > Sorry. Should I send a patch?  
> 
> Yes please.

JFYI the patch has been sent to linux-docs@, etc. I forgot to add you to CC.

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Sat, Jul 23, 2022 at 10:14:28AM +0300, Maxim Devaev wrote:
> On Tue, 19 Jul 2022 13:24:18 +0200
> Greg KH <greg@kroah.com> wrote:
> 
> > On Tue, Jul 19, 2022 at 01:25:59PM +0300, Maxim Devaev wrote:
> > > В Tue, 19 Jul 2022 19:43:37 +1000
> > > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >   
> > > > Hi all,
> > > > 
> > > > After merging the usb tree, today's linux-next build (htmldocs) produced
> > > > this warning:
> > > > 
> > > > Documentation/ABI/testing/configfs-usb-gadget-mass-storage:17: WARNING: Malformed table.
> > > > Text in column margin in table line 14.
> > > > 
> > > > ===========     ==============================================
> > > > file            The path to the backing file for the LUN.
> > > >                 Required if LUN is not marked as removable.
> > > > ro              Flag specifying access to the LUN shall be
> > > >                 read-only. This is implied if CD-ROM emulation
> > > >                 is enabled as well as when it was impossible
> > > >                 to open "filename" in R/W mode.
> > > > removable       Flag specifying that LUN shall be indicated as
> > > >                 being removable.
> > > > cdrom           Flag specifying that LUN shall be reported as
> > > >                 being a CD-ROM.
> > > > nofua           Flag specifying that FUA flag
> > > >                 in SCSI WRITE(10,12)
> > > > forced_eject    This write-only file is useful only when
> > > >                 the function is active. It causes the backing
> > > >                 file to be forcibly detached from the LUN,
> > > >                 regardless of whether the host has allowed it.
> > > >                 Any non-zero number of bytes written will
> > > >                 result in ejection.
> > > > ===========     ==============================================
> > > > 
> > > > Introduced by commit
> > > > 
> > > >   421c8d9a20da ("usb: gadget: f_mass_storage: forced_eject attribute")
> > > >   
> > > 
> > > Sorry. Should I send a patch?  
> > 
> > Yes please.
> 
> JFYI the patch has been sent to linux-docs@, etc. I forgot to add you to CC.

Then I'll not be able to take it into my tree to fix this up :(

Re: linux-next: build warning after merge of the usb tree

[Maxim Devaev]

В Sat, 23 Jul 2022 09:26:31 +0200
Greg KH <greg@kroah.com> wrote:

> On Sat, Jul 23, 2022 at 10:14:28AM +0300, Maxim Devaev wrote:
> > On Tue, 19 Jul 2022 13:24:18 +0200
> > Greg KH <greg@kroah.com> wrote:
> >   
> > > On Tue, Jul 19, 2022 at 01:25:59PM +0300, Maxim Devaev wrote:  
> > > > В Tue, 19 Jul 2022 19:43:37 +1000
> > > > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >     
> > > > > Hi all,
> > > > > 
> > > > > After merging the usb tree, today's linux-next build (htmldocs) produced
> > > > > this warning:
> > > > > 
> > > > > Documentation/ABI/testing/configfs-usb-gadget-mass-storage:17: WARNING: Malformed table.
> > > > > Text in column margin in table line 14.
> > > > > 
> > > > > ===========     ==============================================
> > > > > file            The path to the backing file for the LUN.
> > > > >                 Required if LUN is not marked as removable.
> > > > > ro              Flag specifying access to the LUN shall be
> > > > >                 read-only. This is implied if CD-ROM emulation
> > > > >                 is enabled as well as when it was impossible
> > > > >                 to open "filename" in R/W mode.
> > > > > removable       Flag specifying that LUN shall be indicated as
> > > > >                 being removable.
> > > > > cdrom           Flag specifying that LUN shall be reported as
> > > > >                 being a CD-ROM.
> > > > > nofua           Flag specifying that FUA flag
> > > > >                 in SCSI WRITE(10,12)
> > > > > forced_eject    This write-only file is useful only when
> > > > >                 the function is active. It causes the backing
> > > > >                 file to be forcibly detached from the LUN,
> > > > >                 regardless of whether the host has allowed it.
> > > > >                 Any non-zero number of bytes written will
> > > > >                 result in ejection.
> > > > > ===========     ==============================================
> > > > > 
> > > > > Introduced by commit
> > > > > 
> > > > >   421c8d9a20da ("usb: gadget: f_mass_storage: forced_eject attribute")
> > > > >     
> > > > 
> > > > Sorry. Should I send a patch?    
> > > 
> > > Yes please.  
> > 
> > JFYI the patch has been sent to linux-docs@, etc. I forgot to add you to CC.  
> 
> Then I'll not be able to take it into my tree to fix this up :(

Ooops. Okay, I've sent it as with v2 tag and added your linuxfoundation addr to CC.

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/ABI/testing/configfs-usb-gadget-uac2:2: WARNIN
G: Malformed table.
Text in column margin in table line 27.

=====================   =======================================
c_chmask                capture channel mask
c_srate                 capture sampling rate
c_ssize                 capture sample size (bytes)
c_sync                  capture synchronization type
                        (async/adaptive)
c_mute_present          capture mute control enable
c_volume_present        capture volume control enable
c_volume_min            capture volume control min value
                        (in 1/256 dB)
c_volume_max            capture volume control max value
                        (in 1/256 dB)
c_volume_res            capture volume control resolution
                        (in 1/256 dB)
fb_max                  maximum extra bandwidth in async mode
p_chmask                playback channel mask
p_srate                 playback sampling rate
p_ssize                 playback sample size (bytes)
p_mute_present          playback mute control enable
p_volume_present        playback volume control enable
_volume_present        playback volume control enable
p_volume_min            playback volume control min value
                        (in 1/256 dB)
p_volume_max            playback volume control max value
                        (in 1/256 dB)
p_volume_res            playback volume control resolution
                        (in 1/256 dB)
req_number      the number of pre-allocated requests for both capture
                        and playback
=====================   =======================================

Introduced by commit

  e3088ebc1b97 ("docs: ABI: added missing num_requests param to UAC2")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Fri, Jan 07, 2022 at 02:48:15AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/ABI/testing/configfs-usb-gadget-uac2:2: WARNIN
> G: Malformed table.
> Text in column margin in table line 27.
> 
> =====================   =======================================
> c_chmask                capture channel mask
> c_srate                 capture sampling rate
> c_ssize                 capture sample size (bytes)
> c_sync                  capture synchronization type
>                         (async/adaptive)
> c_mute_present          capture mute control enable
> c_volume_present        capture volume control enable
> c_volume_min            capture volume control min value
>                         (in 1/256 dB)
> c_volume_max            capture volume control max value
>                         (in 1/256 dB)
> c_volume_res            capture volume control resolution
>                         (in 1/256 dB)
> fb_max                  maximum extra bandwidth in async mode
> p_chmask                playback channel mask
> p_srate                 playback sampling rate
> p_ssize                 playback sample size (bytes)
> p_mute_present          playback mute control enable
> p_volume_present        playback volume control enable
> _volume_present        playback volume control enable
> p_volume_min            playback volume control min value
>                         (in 1/256 dB)
> p_volume_max            playback volume control max value
>                         (in 1/256 dB)
> p_volume_res            playback volume control resolution
>                         (in 1/256 dB)
> req_number      the number of pre-allocated requests for both capture
>                         and playback
> =====================   =======================================
> 
> Introduced by commit
> 
>   e3088ebc1b97 ("docs: ABI: added missing num_requests param to UAC2")
> 

Pavel, can you send a follow-on patch to fix this up?

thanks,

greg k-h

Re: linux-next: build warning after merge of the usb tree

[Pavel Hofman]

Dne 06. 01. 22 v 17:10 Greg KH napsal(a):
> On Fri, Jan 07, 2022 at 02:48:15AM +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the usb tree, today's linux-next build (htmldocs) produced
>> this warning:
>>
>> Documentation/ABI/testing/configfs-usb-gadget-uac2:2: WARNIN
>> G: Malformed table.
>> Text in column margin in table line 27.
>>
>> =====================   =======================================
>> c_chmask                capture channel mask
>> c_srate                 capture sampling rate
>> c_ssize                 capture sample size (bytes)
>> c_sync                  capture synchronization type
>>                          (async/adaptive)
>> c_mute_present          capture mute control enable
>> c_volume_present        capture volume control enable
>> c_volume_min            capture volume control min value
>>                          (in 1/256 dB)
>> c_volume_max            capture volume control max value
>>                          (in 1/256 dB)
>> c_volume_res            capture volume control resolution
>>                          (in 1/256 dB)
>> fb_max                  maximum extra bandwidth in async mode
>> p_chmask                playback channel mask
>> p_srate                 playback sampling rate
>> p_ssize                 playback sample size (bytes)
>> p_mute_present          playback mute control enable
>> p_volume_present        playback volume control enable
>> _volume_present        playback volume control enable
>> p_volume_min            playback volume control min value
>>                          (in 1/256 dB)
>> p_volume_max            playback volume control max value
>>                          (in 1/256 dB)
>> p_volume_res            playback volume control resolution
>>                          (in 1/256 dB)
>> req_number      the number of pre-allocated requests for both capture
>>                          and playback
>> =====================   =======================================
>>
>> Introduced by commit
>>
>>    e3088ebc1b97 ("docs: ABI: added missing num_requests param to UAC2")
>>
> 
> Pavel, can you send a follow-on patch to fix this up?
> 

Greg, sorry for the inconvenience, of course I will do so. Please can 
you point me to some doc describing the correct ABI format? There are 
varying numbers of tabs in those files.

Thanks a lot,

Pavel.

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Fri, Jan 07, 2022 at 11:02:34AM +0100, Pavel Hofman wrote:
> 
> Dne 06. 01. 22 v 17:10 Greg KH napsal(a):
> > On Fri, Jan 07, 2022 at 02:48:15AM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the usb tree, today's linux-next build (htmldocs) produced
> > > this warning:
> > > 
> > > Documentation/ABI/testing/configfs-usb-gadget-uac2:2: WARNIN
> > > G: Malformed table.
> > > Text in column margin in table line 27.
> > > 
> > > =====================   =======================================
> > > c_chmask                capture channel mask
> > > c_srate                 capture sampling rate
> > > c_ssize                 capture sample size (bytes)
> > > c_sync                  capture synchronization type
> > >                          (async/adaptive)
> > > c_mute_present          capture mute control enable
> > > c_volume_present        capture volume control enable
> > > c_volume_min            capture volume control min value
> > >                          (in 1/256 dB)
> > > c_volume_max            capture volume control max value
> > >                          (in 1/256 dB)
> > > c_volume_res            capture volume control resolution
> > >                          (in 1/256 dB)
> > > fb_max                  maximum extra bandwidth in async mode
> > > p_chmask                playback channel mask
> > > p_srate                 playback sampling rate
> > > p_ssize                 playback sample size (bytes)
> > > p_mute_present          playback mute control enable
> > > p_volume_present        playback volume control enable
> > > _volume_present        playback volume control enable
> > > p_volume_min            playback volume control min value
> > >                          (in 1/256 dB)
> > > p_volume_max            playback volume control max value
> > >                          (in 1/256 dB)
> > > p_volume_res            playback volume control resolution
> > >                          (in 1/256 dB)
> > > req_number      the number of pre-allocated requests for both capture
> > >                          and playback
> > > =====================   =======================================
> > > 
> > > Introduced by commit
> > > 
> > >    e3088ebc1b97 ("docs: ABI: added missing num_requests param to UAC2")
> > > 
> > 
> > Pavel, can you send a follow-on patch to fix this up?
> > 
> 
> Greg, sorry for the inconvenience, of course I will do so. Please can you
> point me to some doc describing the correct ABI format? There are varying
> numbers of tabs in those files.

I don't know, try the build yourself and see what works!

greg k-h

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Unexpected indentation.
Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

  70f400d4d957 ("driver core: Move the "removable" attribute from USB to core")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Rajat Jain]

Hello,


On Tue, Jun 1, 2021 at 1:30 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
>
> Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Unexpected indentation.
> Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Block quote ends without a blank line; unexpected unindent.

I'd be happy to send a patch to fix this, but I didn't really
understand what needs to be done.

Here is the relevant documentation update in the patch:

+What:          /sys/devices/.../removable
+Date:          May 2021
+Contact:       Rajat Jain <rajatxjain@gmail.com>
+Description:
+               Information about whether a given device can be removed from the
+               platform by the user. This is determined by its subsystem in a
+               bus / platform-specific way. This attribute is only present for
+               devices that can support determining such information:
+
+               "removable": device can be removed from the platform by the user
+               "fixed":     device is fixed to the platform / cannot be removed
+                            by the user.
+               "unknown":   The information is unavailable / cannot be deduced.
+
+               Currently this is only supported by USB (which infers the
+               information from a combination of hub descriptor bits and
+               platform-specific data such as ACPI).

I'd be happy to send a patch if you can point me what needs to be done
(or let Stephen / Greg / some one else do it if it is easier to just
do it instead of guiding me).

Thanks,

Rajat

>
> Introduced by commit
>
>   70f400d4d957 ("driver core: Move the "removable" attribute from USB to core")
>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Tue, Jun 01, 2021 at 10:39:42AM -0700, Rajat Jain wrote:
> Hello,
> 
> 
> On Tue, Jun 1, 2021 at 1:30 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the usb tree, today's linux-next build (htmldocs) produced
> > this warning:
> >
> > Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Unexpected indentation.
> > Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> I'd be happy to send a patch to fix this, but I didn't really
> understand what needs to be done.
> 
> Here is the relevant documentation update in the patch:
> 
> +What:          /sys/devices/.../removable
> +Date:          May 2021
> +Contact:       Rajat Jain <rajatxjain@gmail.com>
> +Description:
> +               Information about whether a given device can be removed from the
> +               platform by the user. This is determined by its subsystem in a
> +               bus / platform-specific way. This attribute is only present for
> +               devices that can support determining such information:
> +
> +               "removable": device can be removed from the platform by the user
> +               "fixed":     device is fixed to the platform / cannot be removed
> +                            by the user.
> +               "unknown":   The information is unavailable / cannot be deduced.
> +
> +               Currently this is only supported by USB (which infers the
> +               information from a combination of hub descriptor bits and
> +               platform-specific data such as ACPI).
> 
> I'd be happy to send a patch if you can point me what needs to be done
> (or let Stephen / Greg / some one else do it if it is easier to just
> do it instead of guiding me).

I do not know what the "right" thing to do here is, sorry.  Maybe one of
the kerneldoc people know?

greg k-h

Re: linux-next: build warning after merge of the usb tree

[Rajat Jain]

+linux-doc@vger.kernel.org
+Jonathan Corbet

Hi Jonathan / kernel-docs people,

On Fri, Jun 4, 2021 at 6:37 AM Greg KH <greg@kroah.com> wrote:
>
> On Tue, Jun 01, 2021 at 10:39:42AM -0700, Rajat Jain wrote:
> > Hello,
> >
> >
> > On Tue, Jun 1, 2021 at 1:30 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the usb tree, today's linux-next build (htmldocs) produced
> > > this warning:
> > >
> > > Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Unexpected indentation.
> > > Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Block quote ends without a blank line; unexpected unindent.
> >
> > I'd be happy to send a patch to fix this, but I didn't really
> > understand what needs to be done.
> >
> > Here is the relevant documentation update in the patch:
> >
> > +What:          /sys/devices/.../removable
> > +Date:          May 2021
> > +Contact:       Rajat Jain <rajatxjain@gmail.com>
> > +Description:
> > +               Information about whether a given device can be removed from the
> > +               platform by the user. This is determined by its subsystem in a
> > +               bus / platform-specific way. This attribute is only present for
> > +               devices that can support determining such information:
> > +
> > +               "removable": device can be removed from the platform by the user
> > +               "fixed":     device is fixed to the platform / cannot be removed
> > +                            by the user.
> > +               "unknown":   The information is unavailable / cannot be deduced.
> > +
> > +               Currently this is only supported by USB (which infers the
> > +               information from a combination of hub descriptor bits and
> > +               platform-specific data such as ACPI).
> >
> > I'd be happy to send a patch if you can point me what needs to be done
> > (or let Stephen / Greg / some one else do it if it is easier to just
> > do it instead of guiding me).
>
> I do not know what the "right" thing to do here is, sorry.  Maybe one of
> the kerneldoc people know?

Can someone familiar with the documentation and html docs let me know
what is wrong with Documentation/ABI/testing/sysfs-devices-removable
that is resulting in this warning when doing "make htmldocs":

> > > Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Unexpected indentation.
> > > Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Block quote ends without a blank line; unexpected unindent.

I looked at the file line number 2 and it just seems inline with other
similar files in that documentation folder.

Thanks,

Rajat

> >
>
> greg k-h

Re: linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

Hi all,

On Tue, 1 Jun 2021 18:30:02 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Unexpected indentation.
> Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Introduced by commit
> 
>   70f400d4d957 ("driver core: Move the "removable" attribute from USB to core")

I am still getting these warnings.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Thu, Jul 08, 2021 at 12:22:06PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 1 Jun 2021 18:30:02 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the usb tree, today's linux-next build (htmldocs) produced
> > this warning:
> > 
> > Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Unexpected indentation.
> > Documentation/ABI/testing/sysfs-devices-removable:2: WARNING: Block quote ends without a blank line; unexpected unindent.
> > 
> > Introduced by commit
> > 
> >   70f400d4d957 ("driver core: Move the "removable" attribute from USB to core")
> 
> I am still getting these warnings.

Rajat, can you send me a patch to fix this up?

thanks,

greg k-h

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htlmdocs) produced
this warning:

Documentation/driver-api/usb/writing_usb_driver.rst:129: WARNING: undefined label: usb_header

Presumably introduced by commit

  caa93d9bd2d7 ("usb: Fix up movement of USB core kerneldoc location")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Mon, Apr 26, 2021 at 10:44:13PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the usb tree, today's linux-next build (htlmdocs) produced
> this warning:
> 
> Documentation/driver-api/usb/writing_usb_driver.rst:129: WARNING: undefined label: usb_header
> 
> Presumably introduced by commit
> 
>   caa93d9bd2d7 ("usb: Fix up movement of USB core kerneldoc location")

Ugh, we'll get this right yet, there's been updates posted, I'll pick
them up after 5.13-rc1 is out.

thanks!

greg k-h

Re: linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

Hi all,

On Mon, 26 Apr 2021 14:53:15 +0200 Greg KH <greg@kroah.com> wrote:
>
> On Mon, Apr 26, 2021 at 10:44:13PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the usb tree, today's linux-next build (htlmdocs) produced
> > this warning:
> > 
> > Documentation/driver-api/usb/writing_usb_driver.rst:129: WARNING: undefined label: usb_header
> > 
> > Presumably introduced by commit
> > 
> >   caa93d9bd2d7 ("usb: Fix up movement of USB core kerneldoc location")  
> 
> Ugh, we'll get this right yet, there's been updates posted, I'll pick
> them up after 5.13-rc1 is out.

I am still seeing this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Fabio Estevam]

Hi Stephen,

On Thu, May 20, 2021 at 9:40 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> I am still seeing this warning.

I will submit a fix for this warning.

Thanks

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

drivers/usb/dwc3/core.h:865: warning: Function parameter or member 'hwparams9' not described in 'dwc3_hwparams'

Introduced by commit

  16710380d3aa ("usb: dwc3: Capture new capability register GHWPARAMS9")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Mon, Apr 26, 2021 at 10:37:33PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> drivers/usb/dwc3/core.h:865: warning: Function parameter or member 'hwparams9' not described in 'dwc3_hwparams'
> 
> Introduced by commit
> 
>   16710380d3aa ("usb: dwc3: Capture new capability register GHWPARAMS9")

Thinh, can you submit a fix for this?

thanks,

greg k-h

Re: linux-next: build warning after merge of the usb tree

[Thinh Nguyen]

Greg KH wrote:
> On Mon, Apr 26, 2021 at 10:37:33PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the usb tree, today's linux-next build (htmldocs) produced
>> this warning:
>>
>> drivers/usb/dwc3/core.h:865: warning: Function parameter or member 'hwparams9' not described in 'dwc3_hwparams'
>>
>> Introduced by commit
>>
>>   16710380d3aa ("usb: dwc3: Capture new capability register GHWPARAMS9")
> 
> Thinh, can you submit a fix for this?
> 

My mistake. Just submitted it.

Thanks,
Thinh

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/usb/ch9.h:1: warning: no structured comments found

Introduced by commit

  855b35ea96c4 ("usb: common: move function's kerneldoc next to its definition")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi all,

On Wed, 10 Mar 2021 13:49:16 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> include/linux/usb/ch9.h:1: warning: no structured comments found
> 
> Introduced by commit
> 
>   855b35ea96c4 ("usb: common: move function's kerneldoc next to its definition")

I am still seeing thus warning (as of next-20210420).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Wed, Apr 21, 2021 at 04:07:25PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 10 Mar 2021 13:49:16 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > After merging the usb tree, today's linux-next build (htmldocs) produced
> > this warning:
> > 
> > include/linux/usb/ch9.h:1: warning: no structured comments found
> > 
> > Introduced by commit
> > 
> >   855b35ea96c4 ("usb: common: move function's kerneldoc next to its definition")
> 
> I am still seeing thus warning (as of next-20210420).

Ick, sorry, will go dig...

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

drivers/usb/dwc3/core.h:1273: warning: Function parameter or member 'usb_psy' not described in 'dwc3'

Introduced by commit

  59fa3def35de ("usb: dwc3: add a power supply for current control")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/usb/typec/class.c: In function 'typec_partner_set_pd_revision':
drivers/usb/typec/class.c:763:6: warning: unused variable 'ret' [-Wunused-variable]
  763 |  int ret;
      |      ^~~

Introduced by commit

  29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Benson Leung]

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

Hi,

On Wed, Feb 03, 2021 at 04:13:00PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the usb tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/usb/typec/class.c: In function 'typec_partner_set_pd_revision':
> drivers/usb/typec/class.c:763:6: warning: unused variable 'ret' [-Wunused-variable]
>   763 |  int ret;
>       |      ^~~
> 
> Introduced by commit
> 
>   29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")
> 

Will be fixed by https://lore.kernel.org/r/20210202095512.761214-1-kyletso@google.com,
already in Greg's usb-testing.

Thanks Kyle for the quick fix yesterday.

Benson

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

drivers/usb/dwc3/core.h:1259: warning: Function parameter or member 'gadget_max_speed' not described in 'dwc3'

Introduced by commit

  7c9a2598463a ("usb: dwc3: gadget: Preserve UDC max speed setting")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi all,

On Wed, 6 Jan 2021 13:12:25 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> drivers/usb/dwc3/core.h:1259: warning: Function parameter or member 'gadget_max_speed' not described in 'dwc3'
> 
> Introduced by commit
> 
>   7c9a2598463a ("usb: dwc3: gadget: Preserve UDC max speed setting")

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Thu, Jan 14, 2021 at 09:48:56AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 6 Jan 2021 13:12:25 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the usb tree, today's linux-next build (htmldocs) produced
> > this warning:
> > 
> > drivers/usb/dwc3/core.h:1259: warning: Function parameter or member 'gadget_max_speed' not described in 'dwc3'
> > 
> > Introduced by commit
> > 
> >   7c9a2598463a ("usb: dwc3: gadget: Preserve UDC max speed setting")
> 
> I am still getting this warning.

Looks like Mauro just sent me a patch for this, will queue it up now,
thanks.

greg k-h

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (htmldocs) produced
this warning:

drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'

Introduced by commit

  a0ccdc4a77a1 ("usb: typec: Add number of altmodes partner attr")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Prashant Malani]

Hi Stephen,

On Fri, Nov 20, 2020 at 04:15:06PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the usb tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> drivers/usb/typec/class.c:632: warning: Excess function parameter 'num_alt_modes' description in 'typec_partner_set_num_altmodes'
> 
> Introduced by commit
> 
>   a0ccdc4a77a1 ("usb: typec: Add number of altmodes partner attr")


Thank you for the email, and my apologies about the warning. I've sent a
patch the mailing lists which should hopefully fix this [1].

Please let me know if there is further action required from my side.

Best regards,

[1]:
https://lore.kernel.org/linux-usb/20201120063523.4159877-1-pmalani@chromium.org/
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
  Depends on [n]: ARCH_DAVINCI_DA8XX
  Selected by [m]:
  - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]

WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
  Depends on [n]: ARCH_DAVINCI_DA8XX
  Selected by [m]:
  - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]

WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
  Depends on [n]: ARCH_DAVINCI_DA8XX
  Selected by [m]:
  - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]

Introduced by commit

  88eaaecc4446 ("usb: host: Enable compile testing for some of drivers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Krzysztof Kozlowski]

On Mon, Jan 06, 2020 at 02:41:22PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
>   Depends on [n]: ARCH_DAVINCI_DA8XX
>   Selected by [m]:
>   - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]
> 
> WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
>   Depends on [n]: ARCH_DAVINCI_DA8XX
>   Selected by [m]:
>   - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]
> 
> WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
>   Depends on [n]: ARCH_DAVINCI_DA8XX
>   Selected by [m]:
>   - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]
> 
> Introduced by commit
> 
>   88eaaecc4446 ("usb: host: Enable compile testing for some of drivers")

+Cc,

Hi Stephen,

Thanks for the report.  I already sent a patch for it for the phy:
https://lore.kernel.org/lkml/20200103164710.4829-2-krzk@kernel.org/

Best regards,
Krzysztof

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Mon, Jan 06, 2020 at 08:58:58AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Jan 06, 2020 at 02:41:22PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
> >   Depends on [n]: ARCH_DAVINCI_DA8XX
> >   Selected by [m]:
> >   - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]
> > 
> > WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
> >   Depends on [n]: ARCH_DAVINCI_DA8XX
> >   Selected by [m]:
> >   - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]
> > 
> > WARNING: unmet direct dependencies detected for PHY_DA8XX_USB
> >   Depends on [n]: ARCH_DAVINCI_DA8XX
> >   Selected by [m]:
> >   - USB_OHCI_HCD_DAVINCI [=m] && USB_SUPPORT [=y] && USB [=m] && (ARCH_DAVINCI_DA8XX || COMPILE_TEST [=y]) && USB_OHCI_HCD [=m]
> > 
> > Introduced by commit
> > 
> >   88eaaecc4446 ("usb: host: Enable compile testing for some of drivers")
> 
> +Cc,
> 
> Hi Stephen,
> 
> Thanks for the report.  I already sent a patch for it for the phy:
> https://lore.kernel.org/lkml/20200103164710.4829-2-krzk@kernel.org/

I'll go queue this up through my usb tree as it is annoying for my
builds as well :(

thanks,

greg k-h

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

Hi Greg,

After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

arch/arm/boot/dts/stih410-b2120.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000
arch/arm/boot/dts/stih407-b2120.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000
arch/arm/boot/dts/stih410-b2260.dtb: Warning (gpios_property): hdmi,hpd-gpio property size (8) too small for cell size 2 in /soc/sti-display-subsystem/sti-hdmi@8d04000
arch/arm/boot/dts/mt2701-evb.dtb: Warning (resets_property): Missing property '#reset-cells' in node /syscon@1b000000 or bad phandle (referred from /ethernet@1b100000:resets[0])
arch/arm/boot/dts/mt7623n-rfb-nand.dtb: Warning (resets_property): Missing property '#reset-cells' in node /syscon@1b000000 or bad phandle (referred from /ethernet@1b100000:resets[0])
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb: Warning (resets_property): Missing property '#reset-cells' in node /syscon@1b000000 or bad phandle (referred from /ethernet@1b100000:resets[0])

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (sparc64 defconfig)
produced this warning:

drivers/usb/storage/protocol.c: In function 'usb_stor_access_xfer_buf':
drivers/usb/storage/protocol.c:155:22: warning: comparison of distinct pointer types lacks a cast [enabled by default]

Introduced by commit e5fc70d5ccc3 ("USB: storage: use sg_miter_* APIs to
access scsi buffer").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko

Introduced by commit 3e0232039967 ("USB: EHCI: prepare to make ehci-hcd a
library module").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Hi,

On Fri, Nov 02, 2012 at 03:08:28PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> 
> Introduced by commit 3e0232039967 ("USB: EHCI: prepare to make ehci-hcd a
> library module").

Alex, why on earth is chipidea exporting symbols it doesn't own ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Alan Stern]

On Fri, 2 Nov 2012, Felipe Balbi wrote:

> Hi,
> 
> On Fri, Nov 02, 2012 at 03:08:28PM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > 
> > Introduced by commit 3e0232039967 ("USB: EHCI: prepare to make ehci-hcd a
> > library module").
> 
> Alex, why on earth is chipidea exporting symbols it doesn't own ?

That's at least partly my fault.  ehci-hcd.c now exports four symbols 
that it didn't before.  Since the ChipIdea driver does

	#include "../host/ehci-hcd.c"

it now exports them too, unintentionally.  A quick band-aid fix would 
be to protect those functions with

	#ifndef CHIPIDEA_EHCI

but the real fix is the patch I posted yesterday -- assuming it works 
right.  If we don't hear back from Alex soon, I will post the band-aid 
fix as a temporary stop-gap.

Alan Stern

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

In file included from drivers/usb/gadget/g_ffs.c:64:
drivers/usb/gadget/f_fs.c:30:1: warning: "pr_fmt" redefined
In file included from include/linux/kernel.h:20,
                 from arch/x86/include/asm/percpu.h:44,
                 from arch/x86/include/asm/current.h:5,
                 from arch/x86/include/asm/processor.h:15,
                 from include/linux/prefetch.h:14,
                 from include/linux/list.h:7,
                 from include/linux/module.h:9,
                 from drivers/usb/gadget/g_ffs.c:22:
include/linux/printk.h:161:1: warning: this is the location of the previous definition

Introduced by commit d8df0b611c66db3b7afd0678213979209616681a ("usb:
gadget: f_fs: remove custom printk() wrappers").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Wed, Nov 17, 2010 at 01:14:27PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> In file included from drivers/usb/gadget/g_ffs.c:64:
> drivers/usb/gadget/f_fs.c:30:1: warning: "pr_fmt" redefined
> In file included from include/linux/kernel.h:20,
>                  from arch/x86/include/asm/percpu.h:44,
>                  from arch/x86/include/asm/current.h:5,
>                  from arch/x86/include/asm/processor.h:15,
>                  from include/linux/prefetch.h:14,
>                  from include/linux/list.h:7,
>                  from include/linux/module.h:9,
>                  from drivers/usb/gadget/g_ffs.c:22:
> include/linux/printk.h:161:1: warning: this is the location of the previous definition
> 
> Introduced by commit d8df0b611c66db3b7afd0678213979209616681a ("usb:
> gadget: f_fs: remove custom printk() wrappers").

Thanks, I told Michal about this, he should be sending me a patch for it
soon.

greg k-h

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (powerpc allyesconfig)
produced this warning:

drivers/usb/host/xhci-ring.c: In function 'prepare_ring':
drivers/usb/host/xhci-ring.c:1729: warning: unused variable 'addr'

Introduced by commit a2fbb0e4784f6d1b3be0779918e84dd3c0c73f04 ("USB:
xhci: Transfer ring link TRB activation change").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Mon, May 17, 2010 at 04:16:03PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the usb tree, today's linux-next build (powerpc allyesconfig)
> produced this warning:
> 
> drivers/usb/host/xhci-ring.c: In function 'prepare_ring':
> drivers/usb/host/xhci-ring.c:1729: warning: unused variable 'addr'
> 
> Introduced by commit a2fbb0e4784f6d1b3be0779918e84dd3c0c73f04 ("USB:
> xhci: Transfer ring link TRB activation change").

Thanks, I'll go fix this up.

greg k-h

linux-next: build warning after merge of the usb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (powerpc
ppc44x_defconfig) produced this warning:

drivers/usb/core/usb.c:596: warning: 'match_device' defined but not used

Introduced by commit c8a3789b05e2ed43d8fd98934edbf66587cd3f96 ("USB:
remove usb_find_device") which removed the last user of this function.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warning after merge of the usb tree

[Greg KH]

On Mon, May 17, 2010 at 04:09:58PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the usb tree, today's linux-next build (powerpc
> ppc44x_defconfig) produced this warning:
> 
> drivers/usb/core/usb.c:596: warning: 'match_device' defined but not used
> 
> Introduced by commit c8a3789b05e2ed43d8fd98934edbf66587cd3f96 ("USB:
> remove usb_find_device") which removed the last user of this function.

Thanks, Ming just sent me a patch to resolve this, I'll go apply it now.

greg k-h