linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com,
	broonie@kernel.org, mazziesaccount@gmail.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	heikki.haikola@fi.rohmeurope.com,
	mikko.mutanen@fi.rohmeurope.com
Subject: Re: [PATCH 4/8] mfd: dt bindings: add BD71847 device-tree binding documentation
Date: Tue, 11 Sep 2018 14:49:47 +0100	[thread overview]
Message-ID: <20180911134947.GQ4185@dell> (raw)
In-Reply-To: <09eceb20f4f05ac48c6767d5f3359743e5b98985.1535545377.git.matti.vaittinen@fi.rohmeurope.com>

On Wed, 29 Aug 2018, Matti Vaittinen wrote:

> Add ROHM BD71847 Power Management IC MFD binding information to
> device-tree binding documents.
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
>  .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt       | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
> index 3ca56fdb5ffe..d78172878faa 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
> @@ -1,16 +1,17 @@
> -* ROHM BD71837 Power Management Integrated Circuit bindings
> +* ROHM BD71837 and BD71847 Power Management Integrated Circuit bindings
>  
> -BD71837MWV is a programmable Power Management IC for powering single-core,
> -dual-core, and quad-core SoCs such as NXP-i.MX 8M. It is optimized for
> -low BOM cost and compact solution footprint. It integrates 8 Buck
> -egulators and 7 LDOs to provide all the power rails required by the SoC and
> -the commonly used peripherals.
> +BD71837MWV and BD71847MWV are programmable Power Management ICs for powering
> +single-core, dual-core, and quad-core SoCs such as NXP-i.MX 8M. They are
> +optimized for low BOM cost and compact solution footprint. BD71837MWV
> +integrates 8 Buck regulators and 7 LDOs. BD71847MWV contains 6 Buck regulators
> +and 6 LDOs.
>  
> -Datasheet for PMIC is available at:
> +Datasheet for BD71837 is available at:
>  https://www.rohm.com/datasheet/BD71837MWV/bd71837mwv-e
>  
>  Required properties:
> - - compatible		: Should be "rohm,bd71837".
> + - compatible		: Should be "rohm,bd71837" for bd71837 and
> +			  "rohm,bd71847" for bd71847.

Nit: Probably sightly clearer as:

> + - compatible		: Should be "rohm,bd71837" for bd71837
> +			                    "rohm,bd71847" for bd71847.

Apart from that:

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2018-09-11 13:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 12:35 [PATCH 0/8] regulator/mfd/dt_bindings: bd718x7: Support ROHM bd71847 Matti Vaittinen
2018-08-29 12:36 ` [PATCH 1/8] regulator: bd71837: Disable voltage monitoring for LDO3/4 Matti Vaittinen
2018-09-11 12:40   ` Lee Jones
2018-09-12  7:47     ` Matti Vaittinen
2018-09-12  8:42       ` Lee Jones
2018-09-12  8:53         ` Matti Vaittinen
2018-09-12 10:23           ` Mark Brown
2018-09-12 10:44             ` Lee Jones
2018-08-29 12:36 ` [PATCH 2/8] regulator: Support ROHM BD71847 power management IC Matti Vaittinen
2018-09-11 13:48   ` Lee Jones
2018-09-12  6:37     ` Matti Vaittinen
2018-08-29 12:37 ` [PATCH 3/8] regulator: dt bindings: add BD71847 device-tree binding documentation Matti Vaittinen
2018-08-29 12:37 ` [PATCH 4/8] mfd: " Matti Vaittinen
2018-09-11 13:49   ` Lee Jones [this message]
2018-09-12  7:43     ` Matti Vaittinen
2018-08-29 12:38 ` [PATCH 5/8] regulator: Support regulators where voltage ranges are selectable Matti Vaittinen
2018-08-29 12:38 ` [PATCH 6/8] regulator/mfd: bd718xx: rename bd71837/bd71847 common instances Matti Vaittinen
2018-09-11 13:51   ` Lee Jones
2018-08-29 12:39 ` [PATCH 7/8] regulator: bd718XX use pickable ranges Matti Vaittinen
2018-09-11 13:55   ` Lee Jones
2018-09-12  7:41     ` Matti Vaittinen
2018-08-29 12:39 ` [PATCH 8/8] regulator: bd718xx: renme bd71837 to 718xx Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180911134947.GQ4185@dell \
    --to=lee.jones@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heikki.haikola@fi.rohmeurope.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mikko.mutanen@fi.rohmeurope.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).