linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Eugene Korenevsky <ekorenevsky@gmail.com>,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2] efi: take size of partition entry from GPT header
Date: Tue, 11 Sep 2018 09:27:41 -0700	[thread overview]
Message-ID: <20180911162741.GC3902@linux-r8p5> (raw)
In-Reply-To: <20180911161527.GA30689@vnote>

On Tue, 11 Sep 2018, Eugene Korenevsky wrote:

>Use gpt_header.sizeof_partition_entry instead of sizeof(gpt_entry)
>for GPT entry size.
>According to UEFI 2.7 spec 5.3.1 "GPT overview":, the size of a GUID Partition
>Entry element is defined in the Size Of Partition Entry field of GPT header.
>The GPT with entries sized more than sizeof(gpt_entry) is not illegal.
>OVMF firmware from EDK2 perfectly works with it, see edk2-tianocore source
>code.

But _why_ is this needed? Does this firmware need larger sized entries (ie: does
not work without it)?

Thanks,
Davidlohr

  reply	other threads:[~2018-09-11 16:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 16:15 [PATCH v2] efi: take size of partition entry from GPT header Eugene Korenevsky
2018-09-11 16:27 ` Davidlohr Bueso [this message]
2018-09-11 16:42   ` Eugene Korenevsky
2018-09-11 22:56 ` kbuild test robot
2018-09-11 22:59 ` Ard Biesheuvel
2018-09-11 23:20 ` kbuild test robot
2018-09-12  8:38 ` Karel Zak
2018-09-13 13:06   ` David Laight
2018-09-13 19:48     ` Eugene Korenevsky
2018-09-14  9:01       ` David Laight
2018-09-14 11:07         ` kzak
2018-10-06 18:41           ` Eugene Korenevsky
2018-10-08 11:15             ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180911162741.GC3902@linux-r8p5 \
    --to=dave@stgolabs.net \
    --cc=ard.biesheuvel@linaro.org \
    --cc=ekorenevsky@gmail.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).