From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C689AC04ABB for ; Wed, 12 Sep 2018 00:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63B9620882 for ; Wed, 12 Sep 2018 00:06:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="i5aJKBnF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63B9620882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727983AbeILFHq (ORCPT ); Wed, 12 Sep 2018 01:07:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:44802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725740AbeILFHq (ORCPT ); Wed, 12 Sep 2018 01:07:46 -0400 Received: from localhost (unknown [104.132.1.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3156720880; Wed, 12 Sep 2018 00:06:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536710764; bh=4SzkYwXr+ipJSeX8e8W7eV3i6YmmBBz/FJ1hMxCPESw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i5aJKBnF0M3ULG7QUlaF0BTGYh+cGYpMgew3NPDP/iTJCWbhwVqo25SDz4vPYS25S rQ2JHNz1xTTjU/KIf6x6sohXp5MHQOTcPpxGOiHuZvNgfEp8nkeyhP41ZSKaZ5d7iK cHOvJIqQBLYGtQbpo+QPj9XKi0upN0ZIxliGVvIA= Date: Tue, 11 Sep 2018 17:06:03 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data Message-ID: <20180912000603.GA67662@jaegeuk-macbookpro.roam.corp.google.com> References: <20180911201546.56566-1-jaegeuk@kernel.org> <7aa2e6f3-a4b2-dfdd-6205-f19c4bc952e6@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7aa2e6f3-a4b2-dfdd-6205-f19c4bc952e6@kernel.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12, Chao Yu wrote: > On 2018/9/12 4:15, Jaegeuk Kim wrote: > > fsck.f2fs is able to recover the quota structure, since roll-forward recovery > > can recover it based on previous user information. > > I didn't get it, both fsck and kernel recover quota file based all inodes' > uid/gid/prjid, if {x}id didn't change, wouldn't those two recovery result be the > same? I thought that, but had to add this, since I was encountering quota errors right after getting some files recovered. And, I thought it'd make it more safe to do fsck after roll-forward recovery. Anyway, let me test again without this patch for a while. Thanks, > > Thanks, > > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/recovery.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > > index 95511ed11a22..1fde86a2107e 100644 > > --- a/fs/f2fs/recovery.c > > +++ b/fs/f2fs/recovery.c > > @@ -675,6 +675,9 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only) > > > > need_writecp = true; > > > > + /* quota is not fully updated due to the lack of user information. */ > > + set_sbi_flag(sbi, SBI_NEED_FSCK); > > + > > /* step #2: recover data */ > > err = recover_data(sbi, &inode_list, &dir_list); > > if (!err) > >