From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7720C4646A for ; Wed, 12 Sep 2018 02:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60C3420882 for ; Wed, 12 Sep 2018 02:46:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EjNu+clM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60C3420882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728071AbeILHsR (ORCPT ); Wed, 12 Sep 2018 03:48:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:55190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726810AbeILHsR (ORCPT ); Wed, 12 Sep 2018 03:48:17 -0400 Received: from localhost (unknown [104.132.1.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF3BC20880; Wed, 12 Sep 2018 02:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536720362; bh=V9rwWDveeWyOExapw2x4eo0lFRO8lct22asBRyAtBWk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EjNu+clMNH3MQhkEtvBA+BbAG12N63CetN9CvmJHgVhLnpTannquqldYeYOYQ4Izi 9Y2anoFHeLlg6/oT6M6Q3l71L00l4PPTnwPr5pZrTmy+vJYlfk5f1v79fqz9BQXhdI ojvtDnX3RtfBTJW1fJFdvDMg2vU+KmL9xJZXzyVk= Date: Tue, 11 Sep 2018 19:46:01 -0700 From: Jaegeuk Kim To: Chao Yu Cc: Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data Message-ID: <20180912024601.GA75537@jaegeuk-macbookpro.roam.corp.google.com> References: <20180911201546.56566-1-jaegeuk@kernel.org> <7aa2e6f3-a4b2-dfdd-6205-f19c4bc952e6@kernel.org> <20180912000603.GA67662@jaegeuk-macbookpro.roam.corp.google.com> <20180912002700.GA69323@jaegeuk-macbookpro.roam.corp.google.com> <650f06f4-7ca3-a3ed-d149-88d1e9f93b7a@huawei.com> <20180912012550.GA71953@jaegeuk-macbookpro.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12, Chao Yu wrote: > On 2018/9/12 9:25, Jaegeuk Kim wrote: > > On 09/12, Chao Yu wrote: > >> On 2018/9/12 8:27, Jaegeuk Kim wrote: > >>> On 09/11, Jaegeuk Kim wrote: > >>>> On 09/12, Chao Yu wrote: > >>>>> On 2018/9/12 4:15, Jaegeuk Kim wrote: > >>>>>> fsck.f2fs is able to recover the quota structure, since roll-forward recovery > >>>>>> can recover it based on previous user information. > >>>>> > >>>>> I didn't get it, both fsck and kernel recover quota file based all inodes' > >>>>> uid/gid/prjid, if {x}id didn't change, wouldn't those two recovery result be the > >>>>> same? > >>>> > >>>> I thought that, but had to add this, since I was encountering quota errors right > >>>> after getting some files recovered. And, I thought it'd make it more safe to do > >>>> fsck after roll-forward recovery. > >>>> > >>>> Anyway, let me test again without this patch for a while. > >>> > >>> Hmm, I just got a fsck failure right after some files recovered. > >> > >> To make sure, do you test with "f2fs: guarantee journalled quota data by > >> checkpoint"? if not, I think there is no guarantee that f2fs can recover > >> quote info into correct quote file, because, in last checkpoint, quota file > >> may was corrupted/inconsistent. Right? > > Oh, I forget to mention that, I add a patch to fsck to let it noticing > CP_QUOTA_NEED_FSCK_FLAG flag, and by default, fsck will fix corrupted quote > file if the flag is set, but w/o this flag, quota file is still corrupted > detected by fsck, I guess there is bug in v8. > > Can you add that in fsck too? so we can separate real kernel bug and quota > file corruption due to dquot subsystem error caused like below case: I'm testing to trigger fsck when it sees the below flag. But, when considering old f2fs-tools, we may need a way to detect mkfs version in superblock in order to determine whether we can rely on this new flag or not. > > +static int f2fs_dquot_acquire(struct dquot *dquot) > +{ > + int ret; > + > + ret = dquot_acquire(dquot); > + if (ret == -ENOSPC || ret == -EIO) > + set_sbi_flag(F2FS_SB(dquot->dq_sb), SBI_QUOTA_NEED_REPAIR); > + return ret; > +} > > > > > I hit the failure with v8. And, the test scenario is 1) enable fault injection > > 2) run fsstress, 3) call shutdowon, 4) kill fsstress, 5) unmount, 6) fsck, 7) > > mount, 8) fsck, 9) go 1). > > > > So, I'm hitting failure in 8) fsck. I expect 6) fsck should fix any corruption > > and 7) recovered some files on clean checkpoint. > > I see, I can add this case too, does this exist in your xfstest tree in github? I think so. > > Thanks, > > > > > Thanks, > > > >> > >> Thanks, > >> > >>> > >>>> > >>>> Thanks, > >>>> > >>>> > >>>>> > >>>>> Thanks, > >>>>> > >>>>>> > >>>>>> Signed-off-by: Jaegeuk Kim > >>>>>> --- > >>>>>> fs/f2fs/recovery.c | 3 +++ > >>>>>> 1 file changed, 3 insertions(+) > >>>>>> > >>>>>> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > >>>>>> index 95511ed11a22..1fde86a2107e 100644 > >>>>>> --- a/fs/f2fs/recovery.c > >>>>>> +++ b/fs/f2fs/recovery.c > >>>>>> @@ -675,6 +675,9 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only) > >>>>>> > >>>>>> need_writecp = true; > >>>>>> > >>>>>> + /* quota is not fully updated due to the lack of user information. */ > >>>>>> + set_sbi_flag(sbi, SBI_NEED_FSCK); > >>>>>> + > >>>>>> /* step #2: recover data */ > >>>>>> err = recover_data(sbi, &inode_list, &dir_list); > >>>>>> if (!err) > >>>>>> > >>>> > >>>> > >>>> _______________________________________________ > >>>> Linux-f2fs-devel mailing list > >>>> Linux-f2fs-devel@lists.sourceforge.net > >>>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > >>> > >>> . > >>> > > > > . > >