From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D620C46469 for ; Wed, 12 Sep 2018 15:19:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B0A22088E for ; Wed, 12 Sep 2018 15:19:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B0A22088E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727277AbeILUYY (ORCPT ); Wed, 12 Sep 2018 16:24:24 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55588 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726640AbeILUYY (ORCPT ); Wed, 12 Sep 2018 16:24:24 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8CFGpaX013639 for ; Wed, 12 Sep 2018 11:19:24 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0b-001b2d01.pphosted.com with ESMTP id 2mf47vbfxm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 12 Sep 2018 11:19:24 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Sep 2018 16:19:23 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 12 Sep 2018 16:19:19 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8CFJIsR56492094 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Sep 2018 15:19:18 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E0F9B4C04E; Wed, 12 Sep 2018 18:19:09 +0100 (BST) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7131A4C050; Wed, 12 Sep 2018 18:19:08 +0100 (BST) Received: from linux.vnet.ibm.com (unknown [9.199.45.134]) by d06av22.portsmouth.uk.ibm.com (Postfix) with SMTP; Wed, 12 Sep 2018 18:19:08 +0100 (BST) Date: Wed, 12 Sep 2018 20:49:16 +0530 From: Srikar Dronamraju To: Ingo Molnar Cc: Peter Zijlstra , LKML , Mel Gorman , Rik van Riel , Thomas Gleixner Subject: Re: [PATCH 5/6] sched/numa: Reset scan rate whenever task moves across nodes Reply-To: Srikar Dronamraju References: <1533276841-16341-1-git-send-email-srikar@linux.vnet.ibm.com> <1533276841-16341-6-git-send-email-srikar@linux.vnet.ibm.com> <20180910084808.GE48257@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180910084808.GE48257@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18091215-0028-0000-0000-000002F84E2B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18091215-0029-0000-0000-000023B1EE2B Message-Id: <20180912151916.GA15221@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-12_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=894 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809120156 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +#ifdef CONFIG_NUMA_BALANCING > > + if (!p->mm || (p->flags & PF_EXITING)) > > + return; > > + > > + if (p->numa_faults) { > > + int src_nid = cpu_to_node(task_cpu(p)); > > + int dst_nid = cpu_to_node(new_cpu); > > + > > + if (src_nid != dst_nid) > > + p->numa_scan_period = task_scan_start(p); > > + } > > +#endif > > Please don't add #ifdeffery inside functions, especially not if they do weird flow control like > a 'return' from the middle of a block. > > A properly named inline helper would work I suppose. > Okay, will take care.