From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E211C070C3 for ; Wed, 12 Sep 2018 19:54:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CD0C213A2 for ; Wed, 12 Sep 2018 19:54:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="k0KEWPqo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CD0C213A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726853AbeIMBAN (ORCPT ); Wed, 12 Sep 2018 21:00:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:47240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbeIMBAN (ORCPT ); Wed, 12 Sep 2018 21:00:13 -0400 Received: from localhost (unknown [104.132.1.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2883420833; Wed, 12 Sep 2018 19:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536782047; bh=XxdmW3q7//iD/61NXwDVz+NBPE3MWXql0Jd8gVO8eM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k0KEWPqoMUthtiHftq8tZLt3jtgYZsSU1n5ijXOOs4fHaX5VNm/b263HB2XKeurvI mwbKvCPVeecJTooWffFIT5nIQTzqcc5j2dUcYbwFoe3mL1N5tNeE5S2mdCw/LdoT9C HGN8BpO7CkO60NdQi3RpAhN9Akl5AeLOramhApWE= Date: Wed, 12 Sep 2018 12:54:06 -0700 From: Jaegeuk Kim To: Chao Yu Cc: Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data Message-ID: <20180912195406.GB8356@jaegeuk-macbookpro.roam.corp.google.com> References: <20180911201546.56566-1-jaegeuk@kernel.org> <7aa2e6f3-a4b2-dfdd-6205-f19c4bc952e6@kernel.org> <20180912000603.GA67662@jaegeuk-macbookpro.roam.corp.google.com> <20180912002700.GA69323@jaegeuk-macbookpro.roam.corp.google.com> <650f06f4-7ca3-a3ed-d149-88d1e9f93b7a@huawei.com> <20180912012550.GA71953@jaegeuk-macbookpro.roam.corp.google.com> <24ee1c19-ccc1-31db-12d0-30ac76fd645e@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24ee1c19-ccc1-31db-12d0-30ac76fd645e@huawei.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12, Chao Yu wrote: > On 2018/9/12 9:40, Chao Yu wrote: > > On 2018/9/12 9:25, Jaegeuk Kim wrote: > >> On 09/12, Chao Yu wrote: > >>> On 2018/9/12 8:27, Jaegeuk Kim wrote: > >>>> On 09/11, Jaegeuk Kim wrote: > >>>>> On 09/12, Chao Yu wrote: > >>>>>> On 2018/9/12 4:15, Jaegeuk Kim wrote: > >>>>>>> fsck.f2fs is able to recover the quota structure, since roll-forward recovery > >>>>>>> can recover it based on previous user information. > >>>>>> > >>>>>> I didn't get it, both fsck and kernel recover quota file based all inodes' > >>>>>> uid/gid/prjid, if {x}id didn't change, wouldn't those two recovery result be the > >>>>>> same? > >>>>> > >>>>> I thought that, but had to add this, since I was encountering quota errors right > >>>>> after getting some files recovered. And, I thought it'd make it more safe to do > >>>>> fsck after roll-forward recovery. > >>>>> > >>>>> Anyway, let me test again without this patch for a while. > >>>> > >>>> Hmm, I just got a fsck failure right after some files recovered. > >>> > >>> To make sure, do you test with "f2fs: guarantee journalled quota data by > >>> checkpoint"? if not, I think there is no guarantee that f2fs can recover > >>> quote info into correct quote file, because, in last checkpoint, quota file > >>> may was corrupted/inconsistent. Right? > > > > Oh, I forget to mention that, I add a patch to fsck to let it noticing > > CP_QUOTA_NEED_FSCK_FLAG flag, and by default, fsck will fix corrupted quote > > file if the flag is set, but w/o this flag, quota file is still corrupted > > detected by fsck, I guess there is bug in v8. > > In v8, there are two cases we didn't guarantee quota file's consistence: > 1. flush time in block_operation exceed a threshold. > 2. dquot subsystem error occurs. > > For above case, fsck should repair the quota file by default. Okay, I got another failure and it seems CP_QUOTA_NEED_FSCK_FLAG was not set during the recovery. So, we have something missing in the recovery in terms of quota updates. > > > > > Can you add that in fsck too? so we can separate real kernel bug and quota > > file corruption due to dquot subsystem error caused like below case: > > > > +static int f2fs_dquot_acquire(struct dquot *dquot) > > +{ > > + int ret; > > + > > + ret = dquot_acquire(dquot); > > + if (ret == -ENOSPC || ret == -EIO) > > + set_sbi_flag(F2FS_SB(dquot->dq_sb), SBI_QUOTA_NEED_REPAIR); > > + return ret; > > +} > > > >> > >> I hit the failure with v8. And, the test scenario is 1) enable fault injection > >> 2) run fsstress, 3) call shutdowon, 4) kill fsstress, 5) unmount, 6) fsck, 7) > >> mount, 8) fsck, 9) go 1). > > 8) fsck is do fscking in a mounted image? Missing unmount before 8). :P > > Thanks, > > >> > >> So, I'm hitting failure in 8) fsck. I expect 6) fsck should fix any corruption > >> and 7) recovered some files on clean checkpoint. > > > > I see, I can add this case too, does this exist in your xfstest tree in github? > > > > Thanks, > > > >> > >> Thanks, > >> > >>> > >>> Thanks, > >>> > >>>> > >>>>> > >>>>> Thanks, > >>>>> > >>>>> > >>>>>> > >>>>>> Thanks, > >>>>>> > >>>>>>> > >>>>>>> Signed-off-by: Jaegeuk Kim > >>>>>>> --- > >>>>>>> fs/f2fs/recovery.c | 3 +++ > >>>>>>> 1 file changed, 3 insertions(+) > >>>>>>> > >>>>>>> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > >>>>>>> index 95511ed11a22..1fde86a2107e 100644 > >>>>>>> --- a/fs/f2fs/recovery.c > >>>>>>> +++ b/fs/f2fs/recovery.c > >>>>>>> @@ -675,6 +675,9 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only) > >>>>>>> > >>>>>>> need_writecp = true; > >>>>>>> > >>>>>>> + /* quota is not fully updated due to the lack of user information. */ > >>>>>>> + set_sbi_flag(sbi, SBI_NEED_FSCK); > >>>>>>> + > >>>>>>> /* step #2: recover data */ > >>>>>>> err = recover_data(sbi, &inode_list, &dir_list); > >>>>>>> if (!err) > >>>>>>> > >>>>> > >>>>> > >>>>> _______________________________________________ > >>>>> Linux-f2fs-devel mailing list > >>>>> Linux-f2fs-devel@lists.sourceforge.net > >>>>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > >>>> > >>>> . > >>>> > >> > >> . > >> > > > > > > . > >