From: Ingo Molnar <mingo@kernel.org>
To: Richard Henderson <rth@twiddle.net>
Cc: Matthew Wilcox <willy@infradead.org>,
Waiman Long <longman@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 0/2] Use named address spaces for percpu data
Date: Wed, 12 Sep 2018 23:06:30 +0200 [thread overview]
Message-ID: <20180912210630.GA2958@gmail.com> (raw)
In-Reply-To: <988cf77c-e0cc-25fb-dcd6-945e6f2ba65e@twiddle.net>
* Richard Henderson <rth@twiddle.net> wrote:
> On 09/12/2018 07:44 AM, Matthew Wilcox wrote:
> > rth wrote a patch back in 2016 that uses gcc's address space machinery
> > to improve code generation for percpu accesses. Ingo asked for some
> > minor changes to be made, but Richard didn't respond. While looking at
> > something related, I came across them, and asked Richard's permission
> > to resurrect and resend the patch, with the changes Ingo asked for at
> > the time.
> >
> > The important information about why we want these patch is in 1/2.
> >
> > Richard Henderson (2):
> > x86: Use named address spaces in asm/percpu.h
> > x86: Enable named address spaces for percpu data
> >
> > arch/x86/include/asm/percpu.h | 147 ++++++++++++++++++++--------------
> > 1 file changed, 88 insertions(+), 59 deletions(-)
>
> Thanks for resurrecting this, Willy. I'd totally forgotten about it.
> The adjustments you made look fine.
Not all GCC versions seem to like this series:
In file included from arch/x86/mm/tlb.c:12:0:
arch/x86/mm/tlb.c: In function ‘switch_mm_irqs_off’:
./arch/x86/include/asm/mmu_context.h:210:28: internal compiler error: Segmentation fault
#define switch_mm_irqs_off switch_mm_irqs_off
arch/x86/mm/tlb.c:183:6: note: in expansion of macro ‘switch_mm_irqs_off’
void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next,
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions.
gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)
Thanks,
Ingo
next prev parent reply other threads:[~2018-09-12 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 14:44 [PATCH 0/2] Use named address spaces for percpu data Matthew Wilcox
2018-09-12 14:44 ` [PATCH 1/2] x86: Use named address spaces in asm/percpu.h Matthew Wilcox
2018-09-12 14:44 ` [PATCH 2/2] x86: Enable named address spaces for percpu data Matthew Wilcox
2018-09-12 15:08 ` [PATCH 0/2] Use " Richard Henderson
2018-09-12 21:06 ` Ingo Molnar [this message]
2018-09-12 21:08 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912210630.GA2958@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).