From: David Miller <davem@davemloft.net>
To: vasilykh@arista.com
Cc: roopa@cumulusnetworks.com, adobriyan@gmail.com,
edumazet@google.com, stephen@networkplumber.org,
jwestfall@surrealistic.net, w.bumiller@proxmox.com,
anarsoul@gmail.com, keescook@chromium.org, ihrachys@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] neighbour: confirm neigh entries when ARP packet is received
Date: Thu, 13 Sep 2018 09:04:10 -0700 (PDT) [thread overview]
Message-ID: <20180913.090410.1329696288697398656.davem@davemloft.net> (raw)
In-Reply-To: <20180911180406.31283-1-vasilykh@arista.com>
From: Vasily Khoruzhick <vasilykh@arista.com>
Date: Tue, 11 Sep 2018 11:04:06 -0700
> Update 'confirmed' timestamp when ARP packet is received. It shouldn't
> affect locktime logic and anyway entry can be confirmed by any higher-layer
> protocol. Thus it makes to sense not to confirm it when ARP packet is
> received.
>
> Fixes: 77d7123342 ("neighbour: update neigh timestamps iff update is
> effective")
>
> Signed-off-by: Vasily Khoruzhick <vasilykh@arista.com>
> ---
> v2: - update comment to match new code.
Please fix the wording in this commit message, as per Sergei's
feedback.
Also, the Fixes: tag should be all one line (people grep for these
strings in the repository) and with no empty lines between it and the
rest of the tags such as Signed-off-by:
Thanks.
prev parent reply other threads:[~2018-09-13 17:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 18:04 [PATCH v2] neighbour: confirm neigh entries when ARP packet is received Vasily Khoruzhick
2018-09-11 18:12 ` Stephen Hemminger
2018-09-11 18:23 ` Vasiliy Khoruzhick
2018-09-12 9:05 ` Sergei Shtylyov
2018-09-13 16:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913.090410.1329696288697398656.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=anarsoul@gmail.com \
--cc=edumazet@google.com \
--cc=ihrachys@redhat.com \
--cc=jwestfall@surrealistic.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=vasilykh@arista.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).