From: Khem Raj <raj.khem@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Khem Raj <raj.khem@gmail.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH] include linux/stddef.h in swab.h uapi header
Date: Wed, 12 Sep 2018 17:56:54 -0700 [thread overview]
Message-ID: <20180913005654.39976-1-raj.khem@gmail.com> (raw)
swab.h uses __always_inline without including the header where it is
defined, this is exposed by musl based distributions where this macro is
not defined by system C library headers unlike glibc where it is defined
in sys/cdefs.h and that header gets pulled in indirectly via
features.h -> sys/cdefs.h
and features.h gets pulled in a lot of headers. Therefore it may work in
cases where features.h is includes but not otherwise.
Adding linux/stddef.h here ensures that __always_inline is always
defined independent of which C library is used in userspace
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
include/uapi/linux/swab.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/swab.h b/include/uapi/linux/swab.h
index 23cd84868cc3..acddbe50a20d 100644
--- a/include/uapi/linux/swab.h
+++ b/include/uapi/linux/swab.h
@@ -3,6 +3,7 @@
#define _UAPI_LINUX_SWAB_H
#include <linux/types.h>
+#include <linux/stddef.h>
#include <linux/compiler.h>
#include <asm/swab.h>
--
2.19.0
next reply other threads:[~2018-09-13 0:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 0:56 Khem Raj [this message]
2018-12-13 18:01 [PATCH] include linux/stddef.h in swab.h uapi header Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913005654.39976-1-raj.khem@gmail.com \
--to=raj.khem@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).