From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3618C07520 for ; Thu, 13 Sep 2018 09:00:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7893220866 for ; Thu, 13 Sep 2018 09:00:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7893220866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727865AbeIMOJ1 (ORCPT ); Thu, 13 Sep 2018 10:09:27 -0400 Received: from mga03.intel.com ([134.134.136.65]:37586 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727566AbeIMOJ1 (ORCPT ); Thu, 13 Sep 2018 10:09:27 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2018 02:00:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,368,1531810800"; d="scan'208";a="72863944" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by orsmga008.jf.intel.com with SMTP; 13 Sep 2018 01:58:27 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 13 Sep 2018 11:58:26 +0300 Date: Thu, 13 Sep 2018 11:58:26 +0300 From: Mika Westerberg To: Lukas Wunner , Greg Kroah-Hartman Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , Stephen Hemminger , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] MAINTAINERS: Add Lukas Wunner as co-maintainer of thunderbolt Message-ID: <20180913085826.GC14465@lahna.fi.intel.com> References: <76fccab34a66023c08b71a864a9fea77daac9742.1536517047.git.lukas@wunner.de> <20180910093333.GI14465@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180910093333.GI14465@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2018 at 12:33:33PM +0300, Mika Westerberg wrote: > Hi Lukas, > > I'm including Greg here in case I've done something wrong as a maintainer. > Since I've only maintained Thunderbolt quite short time, it may be that > I've done mistakes but certainly I did not deliberately try to make life of > people developing this for older Apple systems harder. Greg did not yell at me (yet) so I guess I'm doing OK :) > On Sun, Sep 09, 2018 at 11:42:01PM +0200, Lukas Wunner wrote: > > Andreas Noever has let it be known off-list already a while ago that he > > currently cannot spare as much time for Thunderbolt development as he'd > > like. As a result the driver's development has become dominated by > > Intel. > > I was not aware of this. Althought Andreas has not commented much > lately, I thought he is still looking after our changes. I hope he still > is :) > > > I would like to step up as co-maintainer to provide additional checks > > and balances and prevent the driver from degenerating into an Intel-only > > show. A number of things really irk me: > > I don't have anything against this but at the same time I'm afraid it > might lead to a situation where the Thunderbolt driver evolution gets > stopped into its tracks because of unnecessary fighting over each patch > and change which does not benefit Linux kernel in general. I think we have enough maintainers in this subsystem: Andreas - Apple hardware Michael and me - Intel Yehezkel - Microsoft But I think we can make you a dedicated reviewer. This should make sure you get to review all the patches touching this subsystem. However, first I would like to get confirmation from Andreas that he approves this. I also would like that anyone submitting patches to this subsystem do not get bad feelings during the review but instead possible issues and improvement suggestions are written in such way that the submitter feels his work is valued (even if not always correct). This is especially important when a random Intel (well, or Apple) engineer submits a patch, say fixing a typo in a comment of some data structure. There is no point starting to demand that the specific register meaning needs to be disclosed. I've said this before but I or any other Intel engineer do not have any power over when the spec is released or any other related matter (like disclosing registers) and I really don't want that every single patch review starts with demanding people to disclose something extra. After all they are just trying to improve the driver which is good for Linux. If Andreas approves this, please send a patch adding you as a reviewer and I'll apply it. Just please write the changelog in good will without any personal frustration as those will be recorded forever in the kernel history and you never know in future who you are working for. >From my point of view, I welcome you on board as good reviewer :)