From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] PCI: dwc: fix scheduling while atomic issues
Date: Thu, 13 Sep 2018 10:15:34 +0100 [thread overview]
Message-ID: <20180913091534.GB32721@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <20180910165722.38218779@xhacker.debian>
On Mon, Sep 10, 2018 at 04:57:22PM +0800, Jisheng Zhang wrote:
> Hi all,
>
> On Wed, 29 Aug 2018 11:04:08 +0800 Jisheng Zhang wrote:
>
> > When programming inbound/outbound atu, we call usleep_range() after
> > each checking PCIE_ATU_ENABLE bit. Unfortunately, the atu programming
> > can be called in atomic context:
> >
> > inbound atu programming could be called through
> > pci_epc_write_header()
> > =>dw_pcie_ep_write_header()
> > =>dw_pcie_prog_inbound_atu()
> >
> > outbound atu programming could be called through
> > pci_bus_read_config_dword()
> > =>dw_pcie_rd_conf()
> > =>dw_pcie_prog_outbound_atu()
> >
> > Fix this issue by calling mdelay() instead.
>
> Any comments about this patch?
>
> Thanks,
> Jisheng
>
> >
> > Fixes: f8aed6ec624f ("PCI: dwc: designware: Add EP mode support")
> > Fixes: d8bbeb39fbf3 ("PCI: designware: Wait for iATU enable")
Can you split it into two patches and repost it please ? It will make
everyone's life easier to backport it if there is need, I will apply
then.
Thanks,
Lorenzo
> > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> > Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> > ---
> >
> > since v2:
> > - Add Fixes tag
> > - Add Gustavo's Ack
> >
> > since v1:
> > - use mdelay() instead of udelay() to avoid __bad_udelay()
> >
> > drivers/pci/controller/dwc/pcie-designware.c | 8 ++++----
> > drivers/pci/controller/dwc/pcie-designware.h | 3 +--
> > 2 files changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> > index 778c4f76a884..2153956a0b20 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > @@ -135,7 +135,7 @@ static void dw_pcie_prog_outbound_atu_unroll(struct dw_pcie *pci, int index,
> > if (val & PCIE_ATU_ENABLE)
> > return;
> >
> > - usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX);
> > + mdelay(LINK_WAIT_IATU);
> > }
> > dev_err(pci->dev, "Outbound iATU is not being enabled\n");
> > }
> > @@ -178,7 +178,7 @@ void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, int type,
> > if (val & PCIE_ATU_ENABLE)
> > return;
> >
> > - usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX);
> > + mdelay(LINK_WAIT_IATU);
> > }
> > dev_err(pci->dev, "Outbound iATU is not being enabled\n");
> > }
> > @@ -236,7 +236,7 @@ static int dw_pcie_prog_inbound_atu_unroll(struct dw_pcie *pci, int index,
> > if (val & PCIE_ATU_ENABLE)
> > return 0;
> >
> > - usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX);
> > + mdelay(LINK_WAIT_IATU);
> > }
> > dev_err(pci->dev, "Inbound iATU is not being enabled\n");
> >
> > @@ -282,7 +282,7 @@ int dw_pcie_prog_inbound_atu(struct dw_pcie *pci, int index, int bar,
> > if (val & PCIE_ATU_ENABLE)
> > return 0;
> >
> > - usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX);
> > + mdelay(LINK_WAIT_IATU);
> > }
> > dev_err(pci->dev, "Inbound iATU is not being enabled\n");
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> > index 96126fd8403c..9f1a5e399b70 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.h
> > +++ b/drivers/pci/controller/dwc/pcie-designware.h
> > @@ -26,8 +26,7 @@
> >
> > /* Parameters for the waiting for iATU enabled routine */
> > #define LINK_WAIT_MAX_IATU_RETRIES 5
> > -#define LINK_WAIT_IATU_MIN 9000
> > -#define LINK_WAIT_IATU_MAX 10000
> > +#define LINK_WAIT_IATU 9
> >
> > /* Synopsys-specific PCIe configuration registers */
> > #define PCIE_PORT_LINK_CONTROL 0x710
>
next prev parent reply other threads:[~2018-09-13 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 3:04 [PATCH v3] PCI: dwc: fix scheduling while atomic issues Jisheng Zhang
2018-09-10 8:57 ` Jisheng Zhang
2018-09-13 9:15 ` Lorenzo Pieralisi [this message]
2018-09-13 10:29 ` Jisheng Zhang
2018-09-13 10:49 ` Lorenzo Pieralisi
2018-09-13 15:05 ` Lorenzo Pieralisi
2018-09-20 21:37 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913091534.GB32721@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).