From: Yu Chen <yu.c.chen@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Rui Zhang <rui.zhang@intel.com>,
Chen Yu <yu.chen.surf@gmail.com>, Zhimin Gu <kookoo.gu@intel.com>,
Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/4][v2] PM / hibernate: Check the success of generating md5 digest before hibernation
Date: Thu, 13 Sep 2018 22:00:57 +0800 [thread overview]
Message-ID: <20180913140057.GB8155@chenyu-desktop> (raw)
In-Reply-To: <alpine.DEB.2.21.1809131024500.1473@nanos.tec.linutronix.de>
Hi Thomas,
On Thu, Sep 13, 2018 at 10:26:39AM +0200, Thomas Gleixner wrote:
> On Wed, 12 Sep 2018, Chen Yu wrote:
> > static bool hibernation_e820_mismatch(void *buf)
> > @@ -306,6 +307,7 @@ static bool hibernation_e820_mismatch(void *buf)
> > int arch_hibernation_header_save(void *addr, unsigned int max_size)
> > {
> > struct restore_data_record *rdr = addr;
> > + int ret = -EINVAL;
>
> What's the point of initializing ret?
>
> > if (max_size < sizeof(struct restore_data_record))
> > return -EOVERFLOW;
> > @@ -333,7 +335,9 @@ int arch_hibernation_header_save(void *addr, unsigned int max_size)
> >
> > rdr->magic = RESTORE_MAGIC;
> >
> > - hibernation_e820_save(rdr->e820_digest);
> > + ret = hibernation_e820_save(rdr->e820_digest);
> > + if (ret)
> > + return ret;
> >
> > return 0;
>
> And what;s the point of ret at all?
>
> return hibernation_e820_save();
>
> is effectivly the same.
>
ret is useless, will change to 'return hibernation_e820_save()' here.
Thanks,
Yu
> Thanks,
>
> tglx
next prev parent reply other threads:[~2018-09-13 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 17:19 [PATCH 0/4][v2] Fixes hibernation bugs on x86-32 system Chen Yu
2018-09-11 17:20 ` [PATCH 1/4][v2] x86, hibernate: Fix nosave_regions setup for hibernation Chen Yu
2018-09-11 17:20 ` [PATCH 2/4][v2] PM / hibernate: Check the success of generating md5 digest before hibernation Chen Yu
2018-09-13 8:26 ` Thomas Gleixner
2018-09-13 14:00 ` Yu Chen [this message]
2018-09-11 17:20 ` [PATCH 3/4][v2] x86, hibernate: Extract the common code of 64/32 bit system Chen Yu
2018-09-14 9:21 ` Rafael J. Wysocki
2018-09-18 13:36 ` Yu Chen
2018-09-11 17:21 ` [PATCH 4/4][v2] x86, hibernate: Backport several fixes from 64bits to 32bits hibernation Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913140057.GB8155@chenyu-desktop \
--to=yu.c.chen@intel.com \
--cc=kookoo.gu@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).