* [PATCH] gpiolib: fix freeing of descriptors on error
@ 2018-09-13 16:35 Jim Paris
2018-09-13 19:56 ` Ricardo Ribalda Delgado
0 siblings, 1 reply; 3+ messages in thread
From: Jim Paris @ 2018-09-13 16:35 UTC (permalink / raw)
To: linux-kernel; +Cc: Linus Walleij, linux-gpio, Jim Paris, stable
When the main loop in linehandle_create() encounters an error, it
fails to free one of the previously-requested GPIO descriptors.
This renders the unfreed GPIO unusable until reboot, and leaves
its label pointing to free'd kernel memory.
Cc: stable@vger.kernel.org
Fixes: ab3dbcf78f60 ("gpioib: do not free unrequested descriptors")
Signed-off-by: Jim Paris <jim@jtan.com>
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index e8f8a1999393..a57300c1d649 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -571,7 +571,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
if (ret)
goto out_free_descs;
lh->descs[i] = desc;
- count = i;
+ count = i + 1;
if (lflags & GPIOHANDLE_REQUEST_ACTIVE_LOW)
set_bit(FLAG_ACTIVE_LOW, &desc->flags);
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpiolib: fix freeing of descriptors on error
2018-09-13 16:35 [PATCH] gpiolib: fix freeing of descriptors on error Jim Paris
@ 2018-09-13 19:56 ` Ricardo Ribalda Delgado
2018-09-14 8:57 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2018-09-13 19:56 UTC (permalink / raw)
To: Jim Paris; +Cc: LKML, Linus Walleij, linux-gpio, stable
Hi Jim
I have sent an identical patch 3 hours before you [1] ;)
Seems that we are working on the same stuff.
Cheers
[1] https://www.spinics.net/lists/linux-gpio/msg32541.html
On Thu, Sep 13, 2018 at 6:42 PM Jim Paris <jim@jtan.com> wrote:
>
> When the main loop in linehandle_create() encounters an error, it
> fails to free one of the previously-requested GPIO descriptors.
> This renders the unfreed GPIO unusable until reboot, and leaves
> its label pointing to free'd kernel memory.
>
> Cc: stable@vger.kernel.org
> Fixes: ab3dbcf78f60 ("gpioib: do not free unrequested descriptors")
> Signed-off-by: Jim Paris <jim@jtan.com>
> ---
> drivers/gpio/gpiolib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index e8f8a1999393..a57300c1d649 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -571,7 +571,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
> if (ret)
> goto out_free_descs;
> lh->descs[i] = desc;
> - count = i;
> + count = i + 1;
>
> if (lflags & GPIOHANDLE_REQUEST_ACTIVE_LOW)
> set_bit(FLAG_ACTIVE_LOW, &desc->flags);
> --
> 2.18.0
>
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpiolib: fix freeing of descriptors on error
2018-09-13 19:56 ` Ricardo Ribalda Delgado
@ 2018-09-14 8:57 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-09-14 8:57 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: jim, linux-kernel, open list:GPIO SUBSYSTEM, stable
On Thu, Sep 13, 2018 at 9:56 PM Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> Hi Jim
>
> I have sent an identical patch 3 hours before you [1] ;)
> Seems that we are working on the same stuff.
Haha w00t but I'm grateful that you fine people are taking the
chardev ABI for a ride!
I recorded Jim's contribution as Reported-by on your patch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-14 8:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-13 16:35 [PATCH] gpiolib: fix freeing of descriptors on error Jim Paris
2018-09-13 19:56 ` Ricardo Ribalda Delgado
2018-09-14 8:57 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).