* [PATCH] misc: sgi-gru: fix fall-through annotations
@ 2018-09-13 18:53 Gustavo A. R. Silva
2018-09-14 12:43 ` Dimitri Sivanich
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-09-13 18:53 UTC (permalink / raw)
To: Dimitri Sivanich, Arnd Bergmann, Greg Kroah-Hartman
Cc: linux-kernel, Gustavo A. R. Silva
Replace "fallthru" with a proper "fall through" annotation.
This fix is part of the ongoing efforts to enabling
-Wimplicit-fallthrough
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/misc/sgi-gru/grukservices.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
index 0307690..4b23d58 100644
--- a/drivers/misc/sgi-gru/grukservices.c
+++ b/drivers/misc/sgi-gru/grukservices.c
@@ -634,7 +634,7 @@ static int send_noop_message(void *cb, struct gru_message_queue_desc *mqd,
break;
case CBSS_PAGE_OVERFLOW:
STAT(mesq_noop_page_overflow);
- /* fallthru */
+ /* fall through */
default:
BUG();
}
@@ -792,7 +792,7 @@ static int send_message_failure(void *cb, struct gru_message_queue_desc *mqd,
break;
case CBSS_PAGE_OVERFLOW:
STAT(mesq_page_overflow);
- /* fallthru */
+ /* fall through */
default:
BUG();
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc: sgi-gru: fix fall-through annotations
2018-09-13 18:53 [PATCH] misc: sgi-gru: fix fall-through annotations Gustavo A. R. Silva
@ 2018-09-14 12:43 ` Dimitri Sivanich
0 siblings, 0 replies; 2+ messages in thread
From: Dimitri Sivanich @ 2018-09-14 12:43 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Dimitri Sivanich, Arnd Bergmann, Greg Kroah-Hartman, linux-kernel
Acked-by: Dimitri Sivanich <sivanich@hpe.com>
On Thu, Sep 13, 2018 at 01:53:18PM -0500, Gustavo A. R. Silva wrote:
> Replace "fallthru" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/misc/sgi-gru/grukservices.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 0307690..4b23d58 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -634,7 +634,7 @@ static int send_noop_message(void *cb, struct gru_message_queue_desc *mqd,
> break;
> case CBSS_PAGE_OVERFLOW:
> STAT(mesq_noop_page_overflow);
> - /* fallthru */
> + /* fall through */
> default:
> BUG();
> }
> @@ -792,7 +792,7 @@ static int send_message_failure(void *cb, struct gru_message_queue_desc *mqd,
> break;
> case CBSS_PAGE_OVERFLOW:
> STAT(mesq_page_overflow);
> - /* fallthru */
> + /* fall through */
> default:
> BUG();
> }
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-14 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-13 18:53 [PATCH] misc: sgi-gru: fix fall-through annotations Gustavo A. R. Silva
2018-09-14 12:43 ` Dimitri Sivanich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).