From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FCCC63685 for ; Thu, 13 Sep 2018 19:05:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 448FB20853 for ; Thu, 13 Sep 2018 19:05:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 448FB20853 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728236AbeINAQQ (ORCPT ); Thu, 13 Sep 2018 20:16:16 -0400 Received: from mail.bootlin.com ([62.4.15.54]:52483 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727600AbeINAQQ (ORCPT ); Thu, 13 Sep 2018 20:16:16 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id DD5AB20877; Thu, 13 Sep 2018 21:05:25 +0200 (CEST) Received: from localhost (unknown [88.191.26.124]) by mail.bootlin.com (Postfix) with ESMTPSA id AD0AA2075C; Thu, 13 Sep 2018 21:05:15 +0200 (CEST) Date: Thu, 13 Sep 2018 21:05:16 +0200 From: Alexandre Belloni To: Sam Ravnborg Cc: Alessandro Zummo , Andrew Jeffery , Fabio Estevam , Joel Stanley , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, =?iso-8859-1?Q?S=F8ren?= Andersen Subject: Re: [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property Message-ID: <20180913190516.GG14988@piout.net> References: <20180822183555.GA24084@ravnborg.org> <20180907193508.24974-2-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180907193508.24974-2-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, You can remove 'rtci-' from the subject. On 07/09/2018 21:35:04+0200, Sam Ravnborg wrote: > From: Søren Andersen > > The NXP pcf8523 supports two different quartz loads. > - 7 pF (default) > - 12.5 pF (minimum power consumption) > > The pcf8523 needs to know the size of the quartz load, > otherwise the the RTC will have a bad precision. > > The default for the rtc (after power-on) is 7 pF. > Add a property that tells if the external capacitor is 12.5 pF. > > Signed-off-by: Søren Andersen > Signed-off-by: Sam Ravnborg > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: Rob Herring > Cc: Mark Rutland > --- > Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt | 19 +++++++++++++++++++ > Documentation/devicetree/bindings/trivial-devices.txt | 1 - > 2 files changed, 19 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > new file mode 100644 > index 000000000000..7c5e93f5077c > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > @@ -0,0 +1,19 @@ > +* NXP PCF8523 Real Time Clock > + > +NXP PCF8523 Real Time Clock > + > +Required properties: > +- compatible: Should contain "nxp,pcf8523". > +- reg: I2C address for chip. > + > +Optional property: > +- nxp,quartz_load_12.5pF: The capacitive load on the quartz is 12.5 pF, > + which differ from the default value of 7 pF > + The boolean properties usually don't work well for RTCs because people usually want to keep any previous configuration that may have been done at the factory or in the bootloader so I would use: nxp,quartz_load_fF and this would be either 7000 or 12500. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com