From: Romain Izard <romain.izard.pro@gmail.com>
To: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Romain Izard <romain.izard.pro@gmail.com>
Subject: [PATCH 0/2] Fixes for the SAMA5D2/SAMA5D4 watchdog
Date: Fri, 14 Sep 2018 12:13:37 +0200 [thread overview]
Message-ID: <20180914101339.7382-1-romain.izard.pro@gmail.com> (raw)
A previous change of the sama5d4_wdt driver broke the device probing
with the device tree configuration described in existing DTS files,
when no value is set for the "timeout-sec" property.
Moreover, specifying any other value than 16 seconds for "timeout-sec"
leads to a watchdog reset immediately when opening the watchdog device.
Fix this by respecting hardware constraints added in recent versions of
the SAMA5D2 and SAMA5D4 datasheet.
Romain Izard (2):
watchdog: sama5d4: fix timeout-sec usage
watchdog: sama5d4: write the mode register in two steps
drivers/watchdog/sama5d4_wdt.c | 33 +++++++++++++++++++++------------
1 file changed, 21 insertions(+), 12 deletions(-)
--
2.17.1
next reply other threads:[~2018-09-14 10:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 10:13 Romain Izard [this message]
2018-09-14 10:13 ` [PATCH 1/2] watchdog: sama5d4: fix timeout-sec usage Romain Izard
2018-09-14 13:37 ` Guenter Roeck
2018-09-15 13:46 ` Marcus Folkesson
2018-09-14 10:13 ` [PATCH 2/2] watchdog: sama5d4: write the mode register in two steps Romain Izard
2018-09-14 10:27 ` Alexandre Belloni
2018-09-17 13:58 ` Romain Izard
2018-10-01 15:52 ` Alexandre Belloni
2018-09-14 21:29 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914101339.7382-1-romain.izard.pro@gmail.com \
--to=romain.izard.pro@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcus.folkesson@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).