From: Dimitri Sivanich <sivanich@hpe.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Dimitri Sivanich <sivanich@hpe.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: sgi-gru: fix fall-through annotations
Date: Fri, 14 Sep 2018 07:43:34 -0500 [thread overview]
Message-ID: <20180914124334.GA2205@hpe.com> (raw)
In-Reply-To: <20180913185317.GA1178@embeddedor.com>
Acked-by: Dimitri Sivanich <sivanich@hpe.com>
On Thu, Sep 13, 2018 at 01:53:18PM -0500, Gustavo A. R. Silva wrote:
> Replace "fallthru" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/misc/sgi-gru/grukservices.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 0307690..4b23d58 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -634,7 +634,7 @@ static int send_noop_message(void *cb, struct gru_message_queue_desc *mqd,
> break;
> case CBSS_PAGE_OVERFLOW:
> STAT(mesq_noop_page_overflow);
> - /* fallthru */
> + /* fall through */
> default:
> BUG();
> }
> @@ -792,7 +792,7 @@ static int send_message_failure(void *cb, struct gru_message_queue_desc *mqd,
> break;
> case CBSS_PAGE_OVERFLOW:
> STAT(mesq_page_overflow);
> - /* fallthru */
> + /* fall through */
> default:
> BUG();
> }
> --
> 2.7.4
>
prev parent reply other threads:[~2018-09-14 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 18:53 [PATCH] misc: sgi-gru: fix fall-through annotations Gustavo A. R. Silva
2018-09-14 12:43 ` Dimitri Sivanich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914124334.GA2205@hpe.com \
--to=sivanich@hpe.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).