From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F786FC6182 for ; Fri, 14 Sep 2018 13:31:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D94CB20671 for ; Fri, 14 Sep 2018 13:31:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u3Fe7sDX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D94CB20671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728264AbeINSpz (ORCPT ); Fri, 14 Sep 2018 14:45:55 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:34999 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727676AbeINSpz (ORCPT ); Fri, 14 Sep 2018 14:45:55 -0400 Received: by mail-lj1-f196.google.com with SMTP id p10-v6so7554298ljg.2 for ; Fri, 14 Sep 2018 06:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=A/BeZrlObnyksOdYfel1SgIEqAsDMoJ93U535v3VYkM=; b=u3Fe7sDX150z8EvpbAFuVNfQrlPcbfc9qtY3DoFEs8lZ3we9WVRpEmd8Sr742cdldy gqyQ5LnIHXmjKJXHRY2M16fWqqxNg9vQzPIXRgfRKfz3bS7gE/CICmBPzdaH22K92sWl E8YdwcnB5waAiPYaw/+nPMJtGZGxsdpObpcqLWyQ8BQgaFY1mnu6xNdaT7/hOnxNlRnW Vj7XEAOf32GFIEbg3hXE2dR8bjudv7+McToCiiplEwcwUgCQtJsu10jXQMNnsMuntF7I cXipVzXVxuhTni4VtU3XGT/lXWc8/NcV3F9bLbYzcbH2KZeAdbJ12Y5owaO7nTYVUC1n vYfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=A/BeZrlObnyksOdYfel1SgIEqAsDMoJ93U535v3VYkM=; b=GCJwKBPubWz+0qt2Vh0XZ07xxPfzVOgJ9yZdz80doCLTYvk0XpBX4TTD+R0WnK/oEH MVeRkV98lheLY3gNK0PkuoHVz+Y4NxcCgLGQ7680vrMW/5B+IUfNkBUVnHAeNxjpKErh I6jx0YxrqNi+6Q54UHMS/CKXMH303sYUXgrhXe4lHOOcb+WvsvmUmWSNiCo5Cwf2maKP j9v6zoJKMbOfxrk8nNeX3NNhaWH/Xw/rVvCLLQUwxnmQrrAfuDGeCHimJqopoSg7Vs5S oyHaHFDDNX8ffSgb3qa1vgLXZfnI9KecQEf5m/+rbEMV3Qxzk8XOAZv5APZAyke2xPSb nh5Q== X-Gm-Message-State: APzg51DW9ANGLSG3PMLI95CIcRdbLWqQNmMUyLX1cgchJkYLgCOdv+IA hi2B/OrFEoTLd6PWol24tYo= X-Google-Smtp-Source: ANB0Vdb/ZQ2yf/bH84T31pcqGo6uAuk+ckRkBBRv1Tca6pdQQddkEUrFMickdauw1HBiiYVS3KYXfA== X-Received: by 2002:a2e:9d0c:: with SMTP id t12-v6mr7802543lji.75.1536931881777; Fri, 14 Sep 2018 06:31:21 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id y16-v6sm1219478lje.30.2018.09.14.06.31.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Sep 2018 06:31:21 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1g0oBv-0002dl-AJ; Fri, 14 Sep 2018 15:31:23 +0200 Date: Fri, 14 Sep 2018 15:31:23 +0200 From: Johan Hovold To: Al Viro Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/50] mos7720: bury dead TIOCM... in ->ioctl() Message-ID: <20180914133123.GD1362@localhost> References: <20180913023119.GQ19965@ZenIV.linux.org.uk> <20180913024049.24567-1-viro@ZenIV.linux.org.uk> <20180913024049.24567-4-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180913024049.24567-4-viro@ZenIV.linux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 13, 2018 at 03:40:03AM +0100, Al Viro wrote: > From: Al Viro > > These ioctls never reach driver's ->ioctl() - tty_ioctl() handles > them on its own. ->tiocm[gs]et() is what actually gets called, > and mos7720 provides those, with results equivalent to what the > unreachable code would be doing when called. > > Signed-off-by: Al Viro Acked-by: Johan Hovold