From: Fenghua Yu <fenghua.yu@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@redhat.com>,
H Peter Anvin <hpa@zytor.com>, Tony Luck <tony.luck@intel.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
Xiaochen Shen <xiaochen.shen@intel.com>,
Chen Yu <yu.c.chen@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH 1/9] x86/intel_rdt: Fix MBA parsing callback
Date: Sat, 15 Sep 2018 15:27:05 -0700 [thread overview]
Message-ID: <20180915222704.GA76410@romley-ivt3.sc.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1809151206340.1650@nanos.tec.linutronix.de>
On Sat, Sep 15, 2018 at 12:13:53PM +0200, Thomas Gleixner wrote:
> On Fri, 14 Sep 2018, Fenghua Yu wrote:
> > +int parse_bw(void *_data, struct rdt_resource *r, struct rdt_domain *d);
>
> Sorry no. This keeps the code equally error prone as it was. Why is that
> argument a void pointer in the first place?
>
> > extern struct mutex rdtgroup_mutex;
>
> This is a copy of rdt_cbm_parse_data. Sigh.
>
> The right thing to do here is
>
> 1) rename struct rdt_cbm_parse_data to struct rdt_parse_data
>
> 2) Move it to a header file
>
> 3) Change the argument of parse_ctrlval from void * to struct
> rdt_parse_data *
>
> Everything else is just proliferating the initial underlying problem of
> having a void pointer in those callbacks for no reason at all.
Sure. I have updated this patch and patch 2, 4, 5 based on your comments.
Thanks.
-Fenghua
next prev parent reply other threads:[~2018-09-15 22:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 20:32 [PATCH 0/9] x86/intel_rdt: MBA integration fixes Fenghua Yu
2018-09-14 20:32 ` [PATCH 1/9] x86/intel_rdt: Fix MBA parsing callback Fenghua Yu
2018-09-15 10:13 ` Thomas Gleixner
2018-09-15 22:27 ` Fenghua Yu [this message]
2018-09-14 20:32 ` [PATCH 2/9] x86/intel_rdt: Fix size reporting of MBA resource Fenghua Yu
2018-09-14 20:32 ` [PATCH 3/9] x86/intel_rdt: Global closid helper to support future fixes Fenghua Yu
2018-09-14 20:32 ` [PATCH 4/9] x86/intel_rdt: Fix invalid mode warning when Fenghua Yu
2018-09-15 4:36 ` Reinette Chatre
2018-09-15 4:47 ` Reinette Chatre
2018-09-15 10:22 ` Thomas Gleixner
2018-09-14 20:32 ` [PATCH 5/9] x86/intel_rdt: Fix unchecked MSR access Fenghua Yu
2018-09-14 20:32 ` [PATCH 6/9] x86/intel_rdt: Do not allow pseudo-locking of MBA resource Fenghua Yu
2018-09-14 20:32 ` [PATCH 7/9] x86/intel_rdt: Fix incorrect loop end condition Fenghua Yu
2018-09-14 20:32 ` [PATCH 8/9] x86/intel_rdt: Fix exclusive mode handling of MBA resource Fenghua Yu
2018-09-14 20:32 ` [PATCH 9/9] x86/intel_rdt: Fix incorrect loop end condition Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180915222704.GA76410@romley-ivt3.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xiaochen.shen@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).