From: kbuild test robot <lkp@intel.com>
To: Vikash Garodia <vgarodia@codeaurora.org>
Cc: kbuild-all@01.org, stanimir.varbanov@linaro.org,
hverkuil@xs4all.nl, mchehab@kernel.org, robh@kernel.org,
mark.rutland@arm.com, andy.gross@linaro.org, arnd@arndb.de,
bjorn.andersson@linaro.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
acourbot@chromium.org, vgarodia@codeaurora.org
Subject: Re: [PATCH v7 3/5] venus: firmware: register separate platform_device for firmware loader
Date: Sun, 16 Sep 2018 09:13:29 +0800 [thread overview]
Message-ID: <201809160905.7uXFZmpw%fengguang.wu@intel.com> (raw)
In-Reply-To: <1536931477-13018-4-git-send-email-vgarodia@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 2647 bytes --]
Hi Stanimir,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.19-rc3 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vikash-Garodia/Venus-updates-PIL/20180915-165454
base: git://linuxtv.org/media_tree.git master
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers/media//platform/qcom/venus/firmware.c: In function 'venus_firmware_init':
>> drivers/media//platform/qcom/venus/firmware.c:175:8: error: too few arguments to function 'of_dma_configure'
ret = of_dma_configure(&pdev->dev, np);
^~~~~~~~~~~~~~~~
In file included from drivers/media//platform/qcom/venus/firmware.c:22:0:
include/linux/of_device.h:58:5: note: declared here
int of_dma_configure(struct device *dev,
^~~~~~~~~~~~~~~~
vim +/of_dma_configure +175 drivers/media//platform/qcom/venus/firmware.c
149
150 int venus_firmware_init(struct venus_core *core)
151 {
152 struct platform_device_info info;
153 struct platform_device *pdev;
154 struct device_node *np;
155 int ret;
156
157 np = of_get_child_by_name(core->dev->of_node, "video-firmware");
158 if (!np)
159 return 0;
160
161 memset(&info, 0, sizeof(info));
162 info.fwnode = &np->fwnode;
163 info.parent = core->dev;
164 info.name = np->name;
165 info.dma_mask = DMA_BIT_MASK(32);
166
167 pdev = platform_device_register_full(&info);
168 if (IS_ERR(pdev)) {
169 of_node_put(np);
170 return PTR_ERR(pdev);
171 }
172
173 pdev->dev.of_node = np;
174
> 175 ret = of_dma_configure(&pdev->dev, np);
176 if (ret) {
177 dev_err(core->dev, "dma configure fail\n");
178 goto err_unregister;
179 }
180
181 core->fw.dev = &pdev->dev;
182 core->no_tz = true;
183
184 of_node_put(np);
185
186 return 0;
187
188 err_unregister:
189 platform_device_unregister(pdev);
190 of_node_put(np);
191 return ret;
192 }
193
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66537 bytes --]
next prev parent reply other threads:[~2018-09-16 1:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 13:24 [PATCH v7 0/5] Venus updates - PIL Vikash Garodia
2018-09-14 13:24 ` [PATCH v7 1/5] venus: firmware: add routine to reset ARM9 Vikash Garodia
2018-09-14 13:24 ` [PATCH v7 2/5] venus: firmware: move load firmware in a separate function Vikash Garodia
2018-09-14 13:24 ` [PATCH v7 3/5] venus: firmware: register separate platform_device for firmware loader Vikash Garodia
2018-09-16 1:13 ` kbuild test robot [this message]
2018-09-14 13:24 ` [PATCH v7 4/5] venus: firmware: add no TZ boot and shutdown routine Vikash Garodia
2018-09-14 13:24 ` [PATCH v7 5/5] dt-bindings: media: Document bindings for venus firmware device Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201809160905.7uXFZmpw%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=acourbot@chromium.org \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=kbuild-all@01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).