From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F69ECE560 for ; Mon, 17 Sep 2018 14:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51BDD2088F for ; Mon, 17 Sep 2018 14:50:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51BDD2088F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728821AbeIQURw (ORCPT ); Mon, 17 Sep 2018 16:17:52 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:45514 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727052AbeIQURw (ORCPT ); Mon, 17 Sep 2018 16:17:52 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 757D61449F963; Mon, 17 Sep 2018 07:50:12 -0700 (PDT) Date: Mon, 17 Sep 2018 07:49:52 -0700 (PDT) Message-Id: <20180917.074952.1048947634651253553.davem@davemloft.net> To: clabbe@baylibre.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: ethernet: ti: add missing GENERIC_ALLOCATOR dependency From: David Miller In-Reply-To: <1536924007-2440-1-git-send-email-clabbe@baylibre.com> References: <1536924007-2440-1-git-send-email-clabbe@baylibre.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Sep 2018 07:50:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Corentin Labbe Date: Fri, 14 Sep 2018 11:20:07 +0000 > This patch mades TI_DAVINCI_CPDMA select GENERIC_ALLOCATOR. > without that, the following sparc64 build failure happen > > drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_check_free_tx_desc': > (.text+0x278): undefined reference to `gen_pool_avail' > drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_chan_submit': > (.text+0x340): undefined reference to `gen_pool_alloc' > (.text+0x5c4): undefined reference to `gen_pool_free' > drivers/net/ethernet/ti/davinci_cpdma.o: In function `__cpdma_chan_free': > davinci_cpdma.c:(.text+0x64c): undefined reference to `gen_pool_free' > drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_desc_pool_destroy.isra.6': > davinci_cpdma.c:(.text+0x17ac): undefined reference to `gen_pool_size' > davinci_cpdma.c:(.text+0x17b8): undefined reference to `gen_pool_avail' > davinci_cpdma.c:(.text+0x1824): undefined reference to `gen_pool_size' > davinci_cpdma.c:(.text+0x1830): undefined reference to `gen_pool_avail' > drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_ctlr_create': > (.text+0x19f8): undefined reference to `devm_gen_pool_create' > (.text+0x1a90): undefined reference to `gen_pool_add_virt' > Makefile:1011: recipe for target 'vmlinux' failed > > Signed-off-by: Corentin Labbe Applied.