From: Rob Herring <robh@kernel.org>
To: Guo Ren <ren_guo@c-sky.com>
Cc: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH V5 2/3] dt-bindings: interrupt-controller: C-SKY APB intc
Date: Mon, 17 Sep 2018 02:23:36 -0400 [thread overview]
Message-ID: <20180917062336.GA20555@bogus> (raw)
In-Reply-To: <162f7f98697cd9d806a1a843c6177bb943ea2b33.1537087118.git.ren_guo@c-sky.com>
On Sun, Sep 16, 2018 at 04:50:03PM +0800, Guo Ren wrote:
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
Needs a commit description.
> ---
> .../interrupt-controller/csky,apb-intc.txt | 70 ++++++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> new file mode 100644
> index 0000000..be7c3d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> @@ -0,0 +1,70 @@
> +==============================
> +C-SKY APB Interrupt Controller
> +==============================
> +
> +C-SKY APB Interrupt Controller is a simple soc interrupt controller
> +on the apb bus and we only use it as root irq controller.
> +
> + - csky,apb-intc is used in a lot of csky fpgas and socs, it support 64 irq nums.
> + - csky,dual-apb-intc consists of 2 apb-intc and 128 irq nums supported.
> + - csky,gx6605s-intc is gx6605s soc internal irq interrupt controller, 64 irq nums.
Is there a relationship between csky,gx6605s-intc and csky,apb-intc?
> +
> +=============================
> +intc node bindings definition
> +=============================
> +
> + Description: Describes APB interrupt controller
> +
> + PROPERTIES
> +
> + - compatible
> + Usage: required
> + Value type: <string>
> + Definition: must be "csky,apb-intc"
> + "csky,dual-apb-intc"
> + "csky,gx6605s-intc"
> + - #interrupt-cells
> + Usage: required
> + Value type: <u32>
> + Definition: must be <1>
> + - reg
> + Usage: required
> + Value type: <u32 u32>
> + Definition: <phyaddr size> in soc from cpu view
> + - interrupt-controller:
> + Usage: required
> + - support-pulse-signal:
> + Usage: select
> + Description: to support pulse signal flag
What is this for?
> +
> +Examples:
> +---------
> +
> + intc: interrupt-controller@500000 {
> + compatible = "csky,apb-intc";
> + #interrupt-cells = <1>;
> + reg = <0x00500000 0x400>;
> + interrupt-controller;
> + };
> +
> + intc: interrupt-controller@500000 {
> + compatible = "csky,apb-intc";
> + #interrupt-cells = <1>;
> + reg = <0x00500000 0x400>;
> + interrupt-controller;
> + support-pulse-signal;
> + };
Not really worth 2 examples for just 1 property difference.
> +
> + intc: interrupt-controller@500000 {
> + compatible = "csky,dual-apb-intc";
> + #interrupt-cells = <1>;
> + reg = <0x00500000 0x400>;
> + interrupt-controller;
> + };
> +
> + intc: interrupt-controller@500000 {
> + compatible = "csky,gx6605s-intc";
> + #interrupt-cells = <1>;
> + reg = <0x00500000 0x400>;
> + interrupt-controller;
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-09-17 6:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-16 8:50 [PATCH V5 1/3] irqchip: add C-SKY irqchip drivers Guo Ren
2018-09-16 8:50 ` [PATCH V5 2/3] dt-bindings: interrupt-controller: C-SKY APB intc Guo Ren
2018-09-16 19:27 ` Marc Zyngier
2018-09-17 2:10 ` Guo Ren
2018-09-17 6:23 ` Rob Herring [this message]
2018-09-17 8:36 ` Guo Ren
2018-09-17 14:23 ` Rob Herring
2018-09-17 15:41 ` Guo Ren
2018-09-19 0:56 ` Rob Herring
2018-09-19 2:52 ` Guo Ren
2018-09-16 8:50 ` [PATCH V5 3/3] dt-bindings: interrupt-controller: C-SKY SMP intc Guo Ren
2018-09-16 19:07 ` [PATCH V5 1/3] irqchip: add C-SKY irqchip drivers Marc Zyngier
2018-09-17 2:09 ` Guo Ren
2018-09-17 13:27 ` Marc Zyngier
2018-09-18 8:43 ` Guo Ren
2018-09-18 15:41 ` Marc Zyngier
2018-09-20 5:47 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917062336.GA20555@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=ren_guo@c-sky.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).