From: Jan Kara <jack@suse.cz>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: jack@suse.cz, dan.j.williams@intel.com, tytso@mit.edu,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ext2, dax: set ext2_dax_aops for dax files
Date: Mon, 17 Sep 2018 18:37:09 +0200 [thread overview]
Message-ID: <20180917163709.GA10257@quack2.suse.cz> (raw)
In-Reply-To: <20180914145114.11122-4-toshi.kani@hpe.com>
On Fri 14-09-18 08:51:14, Toshi Kani wrote:
> Sync syscall to DAX file needs to flush processor cache, but it
> currently does not flush to existing DAX files. This is because
> 'ext2_da_aops' is set to address_space_operations of existing DAX
> files, instead of 'ext2_dax_aops', since S_DAX flag is set after
> ext2_set_aops() in the open path.
>
> Similar to ext4, change ext2_iget() to initialize i_flags before
> ext2_set_aops().
>
> Fixes: fb094c90748f ("ext2, dax: introduce ext2_dax_aops")
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Suggested-by: Jan Kara <jack@suse.cz>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Cc: <stable@vger.kernel.org>
Thanks. I'll take the patch through my tree.
Honza
> ---
> fs/ext2/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 7f7ee18fe179..e4bb9386c045 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -1448,6 +1448,7 @@ struct inode *ext2_iget (struct super_block *sb, unsigned long ino)
> }
> inode->i_blocks = le32_to_cpu(raw_inode->i_blocks);
> ei->i_flags = le32_to_cpu(raw_inode->i_flags);
> + ext2_set_inode_flags(inode);
> ei->i_faddr = le32_to_cpu(raw_inode->i_faddr);
> ei->i_frag_no = raw_inode->i_frag;
> ei->i_frag_size = raw_inode->i_fsize;
> @@ -1517,7 +1518,6 @@ struct inode *ext2_iget (struct super_block *sb, unsigned long ino)
> new_decode_dev(le32_to_cpu(raw_inode->i_block[1])));
> }
> brelse (bh);
> - ext2_set_inode_flags(inode);
> unlock_new_inode(inode);
> return inode;
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2018-09-17 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 14:51 [PATCH v2 0/3] fix sync to flush processor cache for ext2/4 DAX files Toshi Kani
2018-09-14 14:51 ` [PATCH v2 1/3] ext4, dax: add ext4_bmap to ext4_dax_aops Toshi Kani
2018-09-16 1:32 ` Theodore Y. Ts'o
2018-09-14 14:51 ` [PATCH v2 2/3] ext4, dax: set ext4_dax_aops for dax files Toshi Kani
2018-09-16 1:56 ` Theodore Y. Ts'o
2018-09-14 14:51 ` [PATCH v2 3/3] ext2, dax: set ext2_dax_aops " Toshi Kani
2018-09-17 16:37 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917163709.GA10257@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=dan.j.williams@intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=stable@vger.kernel.org \
--cc=toshi.kani@hpe.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).