From: Herbert Xu <herbert@gondor.apana.org.au>
To: Kees Cook <keescook@chromium.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Eric Biggers <ebiggers@google.com>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Alexander Stein <alexander.stein@systec-electronic.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Arnaud Ebalard <arno@natisbad.org>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Christian Lamparter <chunkeey@gmail.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-crypto <linux-crypto@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH][RFC] crypto: skcipher: Remove VLA usage
Date: Tue, 18 Sep 2018 17:22:19 +0800 [thread overview]
Message-ID: <20180918092219.kwqb37g6td2xs54f@gondor.apana.org.au> (raw)
In-Reply-To: <CAGXu5jJdqs4Rf=RvRtzQavT0oAtEEWppmjJRFRhLL4iQfCkVnQ@mail.gmail.com>
On Mon, Sep 17, 2018 at 10:30:36PM -0700, Kees Cook wrote:
> On Thu, Sep 13, 2018 at 11:23 AM, Kees Cook <keescook@chromium.org> wrote:
> > RFC follow-up to https://lkml.kernel.org/r/CAGXu5j+bpLK=EQ9LHkO8V=sdaQwt==6fbGhgn2Vi1E9_WxSGRQ@mail.gmail.com
> >
> > The core API changes:
> >
> > struct crypto_sync_skcipher
> > crypto_alloc_sync_skcipher()
> > crypto_free_sync_skcipher()
> > crypto_sync_skcipher_setkey()
> > skcipher_request_set_sync_tfm()
> > SKCIPHER_REQUEST_ON_STACK type check
> >
> > and a single user's refactoring as an example:
> >
> > drivers/crypto/ccp/ccp-crypto.h
> > drivers/crypto/ccp/ccp-crypto-aes-xts.c
> >
> > Does this look correct? If so, I can continue and do the other 60
> > instances of SKCIPHER_REQUEST_ON_STACK().
>
> Herbert, how does this look? Should I do the other 60 instances? I'd
> really like to get this finished up. :)
Hi Kees:
Yes I like this. This looks a lot simpler than I thought it would
be.
Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2018-09-18 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 18:23 [PATCH][RFC] crypto: skcipher: Remove VLA usage Kees Cook
2018-09-18 5:30 ` Kees Cook
2018-09-18 9:22 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918092219.kwqb37g6td2xs54f@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexander.stein@systec-electronic.com \
--cc=antoine.tenart@bootlin.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arno@natisbad.org \
--cc=boris.brezillon@bootlin.com \
--cc=chunkeey@gmail.com \
--cc=clabbe.montjoie@gmail.com \
--cc=ebiggers@google.com \
--cc=gilad@benyossef.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=pombredanne@nexb.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).