From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4266CECE564 for ; Tue, 18 Sep 2018 10:59:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7B9320C0E for ; Tue, 18 Sep 2018 10:59:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Y/x1eyy7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7B9320C0E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729829AbeIRQb4 (ORCPT ); Tue, 18 Sep 2018 12:31:56 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:54652 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729285AbeIRQb4 (ORCPT ); Tue, 18 Sep 2018 12:31:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XXw5MMSAslYRw1sdTAgtXUe+a2iOZUaK+WDjFgJtZbI=; b=Y/x1eyy7T9I0kzXWwJnniAG5v eaVjL+TDDUscbDjzFQCPFBtXIOzifH9rYfICgRhbY8uy9lfLYZ37U6RlNLadwzJDh8AB4+a3kq8w2 ytgzGRjN4JrJIMWnfzHhGRxBy2igzuZqeLekqt16cFVNUiGwuJ1J2gL0Tc1VXrY8aLeIPm0ROvk4T gKgTAzsa09TlGmWKRoiaArXPEcN2Zb3JWd4CYFuQ1Cp2ZYuqLdlWcm0CboJyigoBeXsHKXy+qUhOA ioq+COXPd6xINMbNH6zDDJE9k3Afdxorb1RMa4QAXQQo5rNykmEiYw3WzrrZ38DJDXi0NNOpmFIKd OElGdxw3w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1g2DjL-00043N-4K; Tue, 18 Sep 2018 10:59:43 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 65DB4202C1A38; Tue, 18 Sep 2018 12:59:39 +0200 (CEST) Date: Tue, 18 Sep 2018 12:59:39 +0200 From: Peter Zijlstra To: Zhenzhong Duan Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, konrad.wilk@oracle.com, x86@kernel.org, dwmw@amazon.co.uk, tglx@linutronix.de, Srinivas REDDY Eeda , bp@suse.de, hpa@zytor.com, dhaval.giani@oracle.com Subject: Re: [PATCH] x86/speculation: Use AMD specific retpoline for inline asm on AMD Message-ID: <20180918105939.GK24106@hirez.programming.kicks-ass.net> References: <87411705-893f-46d3-b899-b09ed9fa8d1b@default> <20180918095015.GE19234@hirez.programming.kicks-ass.net> <3fcc1453-1618-9a79-71c9-5eede0023775@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3fcc1453-1618-9a79-71c9-5eede0023775@oracle.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 06:31:07PM +0800, Zhenzhong Duan wrote: > On 2018/9/18 17:50, Peter Zijlstra wrote: > > On Mon, Sep 17, 2018 at 10:17:30PM -0700, Zhenzhong Duan wrote: > > > -#elif defined(CONFIG_X86_32) && defined(CONFIG_RETPOLINE) > > > +#elif defined(CONFIG_RETPOLINE) > > > > This doesn't make any sense.. > This change is used for x86_64 to have minimal Retpoline support when > CONFIG_RETPOLINE is defined but RETPOLINE isn't defined, or I missed > something? No it doesn't. #if defined(X86_64) && defined(RETPOLINE) /* x86_64 retpoline goes here */ #elif defined(RETPOLINE) /* !x86_64 retpoline goes here */ #else /* !retpoline goes here #endif