From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8986DC433F4 for ; Tue, 18 Sep 2018 16:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CB3B20C0E for ; Tue, 18 Sep 2018 16:26:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="TZ4HkeQF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CB3B20C0E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730066AbeIRWAI (ORCPT ); Tue, 18 Sep 2018 18:00:08 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:45695 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729739AbeIRWAI (ORCPT ); Tue, 18 Sep 2018 18:00:08 -0400 Received: by mail-pg1-f194.google.com with SMTP id x26-v6so1275624pge.12 for ; Tue, 18 Sep 2018 09:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gP+v8eyWtc4c/TPHWSj4r72R8Vik/jtjCaB3CZIRsEE=; b=TZ4HkeQFWCLfNvkqAO7HsITOuWD7Q/utF3a0/ZTpkGvermP1Lx3+uMH0Wk+yERK+nJ 6v3Rk4gR2kHriGReFyMnjDa6QMPvxDJdU6QqSJkGhGcyRREvxbjL5nVXyj8QAYuiMinr wpMQkFoEOAcHPDcJAOE7Cx0aNjv02qG19FgKc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gP+v8eyWtc4c/TPHWSj4r72R8Vik/jtjCaB3CZIRsEE=; b=kabPBiBLGhKXHS6OGspMorCD6/2seIfSJsmwN+TnCbVfzSswsxleP4Zfom8icvdn8J Q5wZA+CbAdsrdMREXioWn4sLzNQ7rDlope1mXTRdYIBpX2TznMSe2zZu/nBZ6Q+BK8kP ylCbC2ch6kTnYa0dIe8o+xpKLYaDXex+jRdBDHJrj9ELRUN1AiI1HHCv5LYAbWnwahEx HT0b3/MHtHDkIdpMNsAovc/aWSXjLZayk05lCuFGxSDuEm/6xOaTG9rw04VMXU5/Hjby 5CAfZ9BAg78BStoQO1TVzCWOvH0hqgb81FQGJM67rLnoJ261yTy22xXUh3fHv+WNJU6R WdxA== X-Gm-Message-State: APzg51AerC5S9Np0ZpQfXUibyI2j7A0NOMna79PcK0OnUz7fou/e+x2V f/lQyGBybZYHkPxlSlTOF8/PiQ== X-Google-Smtp-Source: ANB0VdaF3WXuckKRqjOF91oCxhJDsitYi0pBJbCCzBfOL0lfP6cxnHgZQ1+haNJTnlottKURYoiRzw== X-Received: by 2002:a65:5545:: with SMTP id t5-v6mr28436463pgr.157.1537288008094; Tue, 18 Sep 2018 09:26:48 -0700 (PDT) Received: from centauri ([209.121.128.187]) by smtp.gmail.com with ESMTPSA id r17-v6sm23293363pgu.83.2018.09.18.09.26.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Sep 2018 09:26:47 -0700 (PDT) Date: Tue, 18 Sep 2018 18:26:45 +0200 From: Niklas Cassel To: Bjorn Andersson Cc: Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 2/2] remoteproc: qcom: Rename Hexagon v5 modem driver Message-ID: <20180918162645.GB7753@centauri> References: <20180914173552.20370-1-bjorn.andersson@linaro.org> <20180914173552.20370-3-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180914173552.20370-3-bjorn.andersson@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 14, 2018 at 10:35:52AM -0700, Bjorn Andersson wrote: > The qcom_q6v5_pil implements support for the self-authenticating modem > subsystem. With the introduction of other q6v5 based non-TZ based > remoteproc driver the current name is cause for confusion, so rename it > to be more specific. > > No functional change. > > Signed-off-by: Bjorn Andersson > --- > drivers/remoteproc/Kconfig | 14 +++++++------- > drivers/remoteproc/Makefile | 2 +- > 2 files changed, 8 insertions(+), 8 deletions(-) Hello Bjorn, Patch 1/2 modifies platform_driver.driver.name and MODULE_DESCRIPTION. I would have expected this patch to do the same. Kind regards, Niklas > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig > index 425e502c6471..8894935583e2 100644 > --- a/drivers/remoteproc/Kconfig > +++ b/drivers/remoteproc/Kconfig > @@ -92,30 +92,30 @@ config QCOM_Q6V5_COMMON > depends on ARCH_QCOM > depends on QCOM_SMEM > > -config QCOM_Q6V5_PAS > - tristate "Qualcomm Hexagon v5 Peripheral Authentication Service support" > +config QCOM_Q6V5_MSS > + tristate "Qualcomm Hexagon V5 self-authenticating modem subsystem support" > depends on OF && ARCH_QCOM > depends on QCOM_SMEM > depends on RPMSG_QCOM_SMD || (COMPILE_TEST && RPMSG_QCOM_SMD=n) > depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n > depends on QCOM_SYSMON || QCOM_SYSMON=n > select MFD_SYSCON > - select QCOM_MDT_LOADER > select QCOM_Q6V5_COMMON > select QCOM_RPROC_COMMON > select QCOM_SCM > help > - Say y here to support the TrustZone based Peripherial Image Loader > - for the Qualcomm Hexagon v5 based remote processors. > + Say y here to support the Qualcomm self-authenticating modem > + subsystem based on Hexagon V5. > > -config QCOM_Q6V5_PIL > - tristate "Qualcomm Hexagon V5 Peripherial Image Loader" > +config QCOM_Q6V5_PAS > + tristate "Qualcomm Hexagon v5 Peripheral Authentication Service support" > depends on OF && ARCH_QCOM > depends on QCOM_SMEM > depends on RPMSG_QCOM_SMD || (COMPILE_TEST && RPMSG_QCOM_SMD=n) > depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n > depends on QCOM_SYSMON || QCOM_SYSMON=n > select MFD_SYSCON > + select QCOM_MDT_LOADER > select QCOM_Q6V5_COMMON > select QCOM_RPROC_COMMON > select QCOM_SCM > diff --git a/drivers/remoteproc/Makefile b/drivers/remoteproc/Makefile > index eb86c8ba5a87..050f41ac93b0 100644 > --- a/drivers/remoteproc/Makefile > +++ b/drivers/remoteproc/Makefile > @@ -16,8 +16,8 @@ obj-$(CONFIG_DA8XX_REMOTEPROC) += da8xx_remoteproc.o > obj-$(CONFIG_KEYSTONE_REMOTEPROC) += keystone_remoteproc.o > obj-$(CONFIG_QCOM_RPROC_COMMON) += qcom_common.o > obj-$(CONFIG_QCOM_Q6V5_COMMON) += qcom_q6v5.o > +obj-$(CONFIG_QCOM_Q6V5_MSS) += qcom_q6v5_mss.o > obj-$(CONFIG_QCOM_Q6V5_PAS) += qcom_q6v5_pas.o > -obj-$(CONFIG_QCOM_Q6V5_PIL) += qcom_q6v5_pil.o > obj-$(CONFIG_QCOM_Q6V5_WCSS) += qcom_q6v5_wcss.o > obj-$(CONFIG_QCOM_SYSMON) += qcom_sysmon.o > obj-$(CONFIG_QCOM_WCNSS_PIL) += qcom_wcnss_pil.o > -- > 2.18.0 >