From: Matthias Kaehlcke <mka@chromium.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>,
Evan Green <evgreen@chromium.org>,
Manoj Gupta <manojgupta@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global
Date: Tue, 18 Sep 2018 10:32:42 -0700 [thread overview]
Message-ID: <20180918173242.GP22824@google.com> (raw)
In-Reply-To: <32bf1760-4967-a37a-6a17-3f7d5f6e071e@suse.cz>
On Tue, Sep 18, 2018 at 11:51:55AM +0200, Jiri Slaby wrote:
> On 09/18/2018, 11:17 AM, Greg Kroah-Hartman wrote:
> > My question is why we just don't call panic() here instead of trying to
> > duplicate the logic of that function here. Why is that happening?
>
> Historically (before d6580a9f1), we had crash_kexec called() from here.
> To be honest, I see no reason not to call panic() or crash_kexec() again
> if there is any issue with the former (I cannot foresee one).
It seems in the end we don't need to change anything for Clang. With
-fno-delete-null-pointer-checks the NULL pointer access is not
'optimized' away, support for this option landed recently in upstream
LLVM, and it is already set in the kernel.
Using panic() instead of roll-your-own-crash still seems a desirable
improvement though.
next prev parent reply other threads:[~2018-09-18 17:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 21:33 [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global Matthias Kaehlcke
2018-09-18 6:09 ` Sai Prakash Ranjan
2018-09-18 6:11 ` Jiri Slaby
2018-09-18 6:58 ` Sai Prakash Ranjan
2018-09-18 7:20 ` Greg Kroah-Hartman
2018-09-18 9:05 ` Sai Prakash Ranjan
2018-09-18 9:17 ` Greg Kroah-Hartman
2018-09-18 9:53 ` Sai Prakash Ranjan
[not found] ` <32bf1760-4967-a37a-6a17-3f7d5f6e071e@suse.cz>
2018-09-18 17:32 ` Matthias Kaehlcke [this message]
2018-09-18 17:24 ` Matthias Kaehlcke
2018-09-18 11:46 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918173242.GP22824@google.com \
--to=mka@chromium.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=manojgupta@chromium.org \
--cc=ndesaulniers@google.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).